From 02729e89c082f62216ace355fac12fb46fef7e79 Mon Sep 17 00:00:00 2001 From: Florian Weingarten Date: Thu, 4 Jun 2015 11:55:52 -0400 Subject: [PATCH] make rubocop happy --- .rubocop.yml | 1 + .rubocop_todo.yml | 41 +++++++++++++++++++++-------------------- 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 2270ee9..f21c47c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -3,6 +3,7 @@ inherit_from: ./.rubocop_todo.yml AllCops: Exclude: - 'performance/shopify/*' + - 'pkg/**' Lint/AssignmentInCondition: Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 800c726..38b45a9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,5 +1,5 @@ # This configuration was generated by `rubocop --auto-gen-config` -# on 2015-05-13 19:54:01 +0000 using RuboCop version 0.31.0. +# on 2015-06-04 11:55:03 -0400 using RuboCop version 0.31.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -9,19 +9,15 @@ Lint/AmbiguousOperator: Enabled: false -# Offense count: 2 +# Offense count: 5 Lint/AmbiguousRegexpLiteral: Enabled: false -# Offense count: 1 -Lint/Eval: - Enabled: false - # Offense count: 4 Lint/ParenthesesAsGroupedExpression: Enabled: false -# Offense count: 3 +# Offense count: 11 # Cop supports --auto-correct. Lint/UnusedMethodArgument: Enabled: false @@ -36,7 +32,7 @@ Lint/UselessAssignment: # Offense count: 51 Metrics/AbcSize: - Max: 59 + Max: 58 # Offense count: 2 Metrics/BlockNesting: @@ -45,18 +41,18 @@ Metrics/BlockNesting: # Offense count: 16 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 304 + Max: 314 -# Offense count: 10 +# Offense count: 12 Metrics/CyclomaticComplexity: Max: 15 -# Offense count: 547 +# Offense count: 554 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: Max: 294 -# Offense count: 76 +# Offense count: 77 # Configuration parameters: CountComments. Metrics/MethodLength: Max: 46 @@ -64,7 +60,7 @@ Metrics/MethodLength: # Offense count: 1 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 216 + Max: 235 # Offense count: 6 Metrics/PerceivedComplexity: @@ -80,34 +76,34 @@ Style/AccessorMethodName: Style/AndOr: Enabled: false -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods. Style/BlockDelimiters: Enabled: false -# Offense count: 1 +# Offense count: 2 Style/DoubleNegation: Enabled: false -# Offense count: 1 +# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/EmptyLinesAroundClassBody: Enabled: false -# Offense count: 2 +# Offense count: 3 # Configuration parameters: MinBodyLength. Style/GuardClause: Enabled: false -# Offense count: 1 +# Offense count: 62 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues. Style/HashSyntax: Enabled: false -# Offense count: 13 +# Offense count: 4 # Configuration parameters: EnforcedStyle, SupportedStyles. Style/MethodName: Enabled: false @@ -126,6 +122,11 @@ Style/Next: Style/PredicateName: Enabled: false +# Offense count: 1 +# Cop supports --auto-correct. +Style/RedundantException: + Enabled: false + # Offense count: 1 Style/RescueModifier: Enabled: false @@ -136,7 +137,7 @@ Style/RescueModifier: Style/Semicolon: Enabled: false -# Offense count: 3 +# Offense count: 1 # Cop supports --auto-correct. Style/SpecialGlobalVars: Enabled: false