From 0b36461d80117cd8d4fad45eadc8144e01d2bad5 Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Sun, 9 Sep 2018 21:07:22 +0900 Subject: [PATCH] Suppress warning: `BigDecimal.new` is deprecated ## Summary `BigDecimal.new` is deprecated since BigDecimal 1.3.3 for Ruby 2.5. This PR suppresses the following warnings. ```console % ruby -v ruby 2.6.0dev (2018-09-06 trunk 64648) [x86_64-darwin17] % RUBYOPT=-w bundle exec rake (snip) /Users/koic/src/github.com/Shopify/liquid/lib/liquid/utils.rb:49: warning: BigDecimal.new is deprecated; use Kernel.BigDecimal method instead. /Users/koic/src/github.com/Shopify/liquid/lib/liquid/utils.rb:53: warning: BigDecimal.new is deprecated; use Kernel.BigDecimal method instead. ``` ## Other Information The following is a change of BigDecimal 1.3.3 for Ruby 2.5 related to this PR. - https://github.com/ruby/bigdecimal/commit/533737338db915b00dc7168c3602e4b462b23503 - https://github.com/ruby/bigdecimal/commit/16738ad0aca158d3c70123990d8caa5789818177 --- lib/liquid/utils.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/liquid/utils.rb b/lib/liquid/utils.rb index fc05ac5..516ac0c 100644 --- a/lib/liquid/utils.rb +++ b/lib/liquid/utils.rb @@ -46,11 +46,11 @@ module Liquid def self.to_number(obj) case obj when Float - BigDecimal.new(obj.to_s) + BigDecimal(obj.to_s) when Numeric obj when String - (obj.strip =~ /\A-?\d+\.\d+\z/) ? BigDecimal.new(obj) : obj.to_i + (obj.strip =~ /\A-?\d+\.\d+\z/) ? BigDecimal(obj) : obj.to_i else if obj.respond_to?(:to_number) obj.to_number