From 0c2db998cf39f488de30c0e3f27f28274dfcd151 Mon Sep 17 00:00:00 2001 From: ADTC Date: Thu, 25 Feb 2021 09:59:51 +0800 Subject: [PATCH 1/2] Add a line to Sign the CLA as the first step in Workflow If a pull request is created by someone who didn't sign the CLA yet, the tests will fail. It requires the contributor to submit a new PR or add an insignificant commit (like an empty commit) to force the tests to rerun on the same PR. If we gently nudge a new contributor to sign the CLA in advance, we can help them avoid the hassle. --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d6034c3..3be3245 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,6 +17,7 @@ ## Workflow +* [Sign the CLA](https://cla.shopify.com/) * Fork the Liquid repository * Create a new branch in your fork * If it makes sense, add tests for your code and/or run a performance benchmark From 15b2d193ec92795f45b5b8ef0f9b0e5438807db5 Mon Sep 17 00:00:00 2001 From: ADTC Date: Fri, 26 Feb 2021 16:31:16 +0800 Subject: [PATCH 2/2] Add a hint to sign CLA only if it's the first time The CLA isn't signed per repository. They might have done so for another repository. In which case, they won't need to do that again. Change attributed to @dylanahsmith Co-authored-by: Dylan Thacker-Smith --- CONTRIBUTING.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3be3245..75ad327 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,10 +17,9 @@ ## Workflow -* [Sign the CLA](https://cla.shopify.com/) +* [Sign the CLA](https://cla.shopify.com/) if you haven't already * Fork the Liquid repository * Create a new branch in your fork * If it makes sense, add tests for your code and/or run a performance benchmark * Make sure all tests pass (`bundle exec rake`) * Create a pull request -