From 8d5a907dc86b056fe5119f09c9fece99fb28166e Mon Sep 17 00:00:00 2001 From: Tanel Jakobsoo Date: Fri, 6 Nov 2015 16:32:02 +0200 Subject: [PATCH] Fixed issue where "nil" value for "escape" filter breaks rendering Closes #664 --- lib/liquid/standardfilters.rb | 2 +- test/integration/standard_filter_test.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb index 3be892a..ad3ca9b 100644 --- a/lib/liquid/standardfilters.rb +++ b/lib/liquid/standardfilters.rb @@ -33,7 +33,7 @@ module Liquid end def escape(input) - CGI.escapeHTML(input).untaint + CGI.escapeHTML(input).untaint unless input.nil? end alias_method :h, :escape diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb index a37e0af..0ac8291 100644 --- a/test/integration/standard_filter_test.rb +++ b/test/integration/standard_filter_test.rb @@ -118,6 +118,7 @@ class StandardFiltersTest < Minitest::Test def test_escape assert_equal '<strong>', @filters.escape('') + assert_equal nil, @filters.escape(nil) assert_equal '<strong>', @filters.h('') end