From dd455a63613e577ba0fa8cf5fa3b54f833c6a710 Mon Sep 17 00:00:00 2001
From: Justin Li <jli.justinli@gmail.com>
Date: Thu, 4 Dec 2014 17:48:26 -0500
Subject: [PATCH] Force user to require the profiler themselves

---
 lib/liquid.rb          |  2 --
 lib/liquid/profiler.rb | 17 +++++------------
 lib/liquid/template.rb |  2 +-
 test/test_helper.rb    |  2 +-
 4 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/lib/liquid.rb b/lib/liquid.rb
index 70d26de..d6334ec 100644
--- a/lib/liquid.rb
+++ b/lib/liquid.rb
@@ -73,5 +73,3 @@ require 'liquid/token'
 # Load all the tags of the standard library
 #
 Dir[File.dirname(__FILE__) + '/liquid/tags/*.rb'].each { |f| require f }
-
-require 'liquid/profiler'
diff --git a/lib/liquid/profiler.rb b/lib/liquid/profiler.rb
index f253e2d..67ad6fa 100644
--- a/lib/liquid/profiler.rb
+++ b/lib/liquid/profiler.rb
@@ -1,9 +1,12 @@
+require 'liquid/profiler/hooks'
+
 module Liquid
 
   # Profiler enables support for profiling template rendering to help track down performance issues.
   #
-  # To enable profiling, pass the <tt>profile: true</tt> option to <tt>Liquid::Template.parse</tt>. Then, after
-  # <tt>Liquid::Template#render</tt> is called, the template object makes available an instance of this
+  # To enable profiling, first require 'liquid/profiler'.
+  # Then, to profile a parse/render cycle, pass the <tt>profile: true</tt> option to <tt>Liquid::Template.parse</tt>.
+  # After <tt>Liquid::Template#render</tt> is called, the template object makes available an instance of this
   # class via the <tt>Liquid::Template#profiler</tt> method.
   #
   #   template = Liquid::Template.parse(template_content, profile: true)
@@ -70,16 +73,6 @@ module Liquid
       end
     end
 
-    def self.hooks_loaded
-      @hooks_loaded
-    end
-
-    def self.load_hooks
-      return if @hooks_loaded
-      require 'liquid/profiler/hooks'
-      @hooks_loaded = true
-    end
-
     def self.profile_token_render(token)
       if Profiler.current_profile && token.respond_to?(:render)
         Profiler.current_profile.start_token(token)
diff --git a/lib/liquid/template.rb b/lib/liquid/template.rb
index e10d429..a134962 100644
--- a/lib/liquid/template.rb
+++ b/lib/liquid/template.rb
@@ -250,7 +250,7 @@ module Liquid
 
     def with_profiling
       if @profiling && !@options[:included]
-        raise "Profiler hooks not loaded, call Liquid::Profiler.load_hooks first" unless Profiler.hooks_loaded
+        raise "Profiler not loaded, require 'liquid/profiler' first" unless defined?(Profiler)
 
         @profiler = Profiler.new
         @profiler.start
diff --git a/test/test_helper.rb b/test/test_helper.rb
index e56efee..438f075 100644
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -5,6 +5,7 @@ require 'spy/integration'
 
 $:.unshift(File.join(File.expand_path(File.dirname(__FILE__)), '..', 'lib'))
 require 'liquid.rb'
+require 'liquid/profiler'
 
 mode = :strict
 if env_mode = ENV['LIQUID_PARSER_MODE']
@@ -12,7 +13,6 @@ if env_mode = ENV['LIQUID_PARSER_MODE']
   mode = env_mode.to_sym
 end
 Liquid::Template.error_mode = mode
-Liquid::Profiler.load_hooks
 
 if Minitest.const_defined?('Test')
   # We're on Minitest 5+. Nothing to do here.