kemko/liquid
1
0
Fork 0
mirror of https://github.com/kemko/liquid.git synced 2026-01-06 02:05:41 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #583 from Shopify/slice-nil-offset

Browse Source 
Raise a Liquid::ArgumentError in slice filter for invalid integers.
This commit is contained in:
Dylan Thacker-Smith
2015-06-03 01:43:56 -04:00
parent 3dd6433e2f c84f4520cc
commit ea29f8b4b8
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/integration/standard_filter_test.rb
View File

@@ -76,6 +76,13 @@ class StandardFiltersTest < Minitest::Test
assert_equal '', @filters.slice(nil, 0)
assert_equal '', @filters.slice('foobar', 100, 10)
assert_equal '', @filters.slice('foobar', -100, 10)
assert_equal 'oob', @filters.slice('foobar', '1', '3')
assert_raises(Liquid::ArgumentError) do
@filters.slice('foobar', nil)
end
assert_raises(Liquid::ArgumentError) do
@filters.slice('foobar', 0, "")
end
end
def test_slice_on_arrays