From f5faa4858cec54823df83e5a3765f183a310f9b0 Mon Sep 17 00:00:00 2001 From: Dylan Thacker-Smith Date: Thu, 16 Oct 2014 23:06:25 -0400 Subject: [PATCH] Remove parsed expression cache. --- lib/liquid/context.rb | 3 +-- test/unit/context_unit_test.rb | 10 ---------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/lib/liquid/context.rb b/lib/liquid/context.rb index aab1def..179a466 100644 --- a/lib/liquid/context.rb +++ b/lib/liquid/context.rb @@ -24,7 +24,6 @@ module Liquid @resource_limits = resource_limits || Template.default_resource_limits.dup @resource_limits[:render_score_current] = 0 @resource_limits[:assign_score_current] = 0 - @parsed_expression = Hash.new{ |cache, markup| cache[markup] = Expression.parse(markup) } squash_instance_assigns_with_environments @this_stack_used = false @@ -170,7 +169,7 @@ module Liquid # Example: # products == empty #=> products.empty? def [](expression) - evaluate(@parsed_expression[expression]) + evaluate(Expression.parse(expression)) end def has_key?(key) diff --git a/test/unit/context_unit_test.rb b/test/unit/context_unit_test.rb index 848f66f..b649483 100644 --- a/test/unit/context_unit_test.rb +++ b/test/unit/context_unit_test.rb @@ -469,16 +469,6 @@ class ContextUnitTest < Minitest::Test refute mock_any.has_been_called? assert mock_empty.has_been_called? - end - - def test_variable_lookup_caches_markup - mock_scan = Spy.on_instance_method(String, :scan).and_return(["string"]) - - @context['string'] = 'string' - @context['string'] - @context['string'] - - assert_equal 1, mock_scan.calls.size end def test_context_initialization_with_a_proc_in_environment