Florian Weingarten
e761a6864e
clean up some rubocop stuff
2015-06-04 12:56:29 -04:00
Florian Weingarten
4c22cef341
blank and empty as variable names
2015-06-04 12:30:50 -04:00
Florian Weingarten
6ace095207
Avoid parallel assignments
2015-06-04 11:56:47 -04:00
Gaurav Chande
6b0f6401d0
Merge pull request #590 from Shopify/allow-template-tags
...
Local Tags
2015-06-04 11:19:24 -04:00
Gaurav Chande
fc8e6c8d3a
Change Tokenizer test to fetch tokens instead of exposing ivar
2015-06-04 15:10:01 +00:00
Gaurav Chande
79d7dd06df
Extract tag fetching into a method (which can be overriden then)
2015-06-04 04:39:54 +00:00
Gaurav Chande
3a907a4db7
Move DEFAULT_OPTIONS related logic to Document
2015-06-04 04:39:54 +00:00
Gaurav Chande
8b98f92c7f
Extract tokenize logic from Template to a RubyTokenizer
2015-06-04 04:39:30 +00:00
Dylan Thacker-Smith
8a2947865b
Avoid an exception from checking if a string contains a non-string.
2015-06-03 02:21:51 -04:00
Dylan Thacker-Smith
ea29f8b4b8
Merge pull request #583 from Shopify/slice-nil-offset
...
Raise a Liquid::ArgumentError in slice filter for invalid integers.
2015-06-03 01:43:56 -04:00
Dylan Thacker-Smith
c84f4520cc
Keep input out of error message and add test for slice Integer parsing.
2015-06-03 01:35:01 -04:00
Dylan Thacker-Smith
3dd6433e2f
Merge pull request #584 from Shopify/replace-non-string
...
Convert arguments to replace filters to strings to avoid exceptions.
2015-06-02 16:41:15 -04:00
Dylan Thacker-Smith
ab7109a335
Raise a Liquid::ArgumentError in slice filter for invalid integers.
2015-06-02 16:05:08 -04:00
Dylan Thacker-Smith
94fe050952
Convert arguments to replace filters to strings to avoid exceptions.
2015-06-02 15:59:29 -04:00
Justin Li
c290375aec
Remove unnecessary regex options
2015-06-02 15:17:36 -04:00
Justin Li
719a98a25e
Ensure raw tag has no arguments
2015-06-02 14:32:39 -04:00
Justin Li
b1ee9129e7
Raise SyntaxError if raw tag is unclosed
2015-06-02 10:56:51 -04:00
Justin Li
be2e41e4d5
Merge pull request #579 from Shopify/ast-match
...
Ensure For@reversed is a boolean
2015-05-28 16:45:09 -04:00
Justin Li
6c058823ad
Merge pull request #570 from Shopify/fix-strict-conditions
...
Fix condition parse order in strict mode
2015-05-28 16:33:54 -04:00
Dylan Thacker-Smith
27245c9eab
Merge pull request #577 from Shopify/table-row-blank-string-collection
...
Fix exception from using an empty string for the table row collection.
2015-05-28 16:20:42 -04:00
Justin Li
a639a13380
Use cleaner recursive solution
2015-05-28 16:16:30 -04:00
Justin Li
05a0fe56c8
Ensure For@reversed is a boolean
2015-05-28 16:09:26 -04:00
Dylan Thacker-Smith
c1eb694057
Remove the redundant iterable check in the for tag.
...
Just do it in slice_collection for consistency with the tablerow tag.
2015-05-28 16:04:50 -04:00
Dylan Thacker-Smith
363388e92f
Handle some more standard filter errors.
2015-05-28 14:18:53 -04:00
Dylan Thacker-Smith
873eddbb85
Split a line and use String#empty? for readability
2015-05-28 12:55:04 -04:00
Dylan Thacker-Smith
e790b60f60
Fix exception from using an empty string for the table row collection.
2015-05-28 12:11:39 -04:00
Dylan Thacker-Smith
8d5e71f856
Allow the exception handler to convert exceptions to hide error messages.
2015-05-27 18:59:51 -04:00
Dylan Thacker-Smith
6265c36ec9
Raise Liquid::ZeroDivisionError instead of ZeroDivisionError.
2015-05-25 15:40:17 -04:00
Dylan Thacker-Smith
36200ff704
Make liquid error rendering optional.
...
Although the author of the liquid template wants to see these errors, they
probably don't want the visitor to see the liquid errors. Probably the
best fallback when rendering the page for visitors is to render the empty
string for tags with errors.
2015-05-25 11:24:53 -04:00
Justin Li
a9c7df931f
Strict parse conditions in reverse order
2015-05-19 11:51:01 -04:00
Justin Li
070639daba
Push to for_stack at the beginning of For#render
2015-05-15 23:13:15 -04:00
Justin Li
dad98cfc89
Merge pull request #562 from Shopify/use-find_variable-for-parentloop
...
Use custom stack for forloop references
2015-05-15 21:48:57 -04:00
Justin Li
648a4888af
Pop the for_stack register in an ensure
2015-05-14 15:02:20 -04:00
Florian Weingarten
f4724f0db3
Remove support for liquid_methods Module extension
2015-05-14 14:44:19 +00:00
Florian Weingarten
3372ca8136
Rubocop
2015-05-14 14:37:18 +00:00
Jean Boussier
b31df0fb3d
Mordernize code base with __dir__ and require_relative
2015-05-13 15:33:00 -04:00
Florian Weingarten
9e815ec594
Merge pull request #563 from Shopify/webscale_exceptions
...
Prefer Class.new() where possible
2015-05-13 06:06:35 +02:00
Florian Weingarten
93b29b67ef
Prefer Class.new() where possible
2015-05-13 02:47:43 +00:00
Justin Li
863e8968f0
Use extra stack for forloop references
2015-05-12 17:04:34 -04:00
Justin Li
4c9d2009f9
Add find_own_variable method to look up internal context variables
2015-05-12 16:49:39 -04:00
Justin Li
239cfa5a44
Use find_variable for parentloop
2015-05-12 16:11:32 -04:00
Justin Li
9310640bdd
Merge pull request #554 from arthanzel/529-sort_natural
...
Merge pull request 554
2015-05-12 13:19:24 -04:00
Justin Li
247c51ac70
Call Context#find_variable directly
2015-05-11 18:22:15 -04:00
Justin Li
37dbec3610
Remove unnecessary parse
2015-05-11 18:10:38 -04:00
Justin Li
ff253a04c6
Lazily evaluate template name for context variable injection
2015-05-11 18:01:24 -04:00
Loren Hale
fa6cd6287e
date filter gracefully accepts empty string
2015-05-07 17:04:21 +08:00
Martin Hanzel
068791d698
Added method parens
2015-05-05 11:49:14 -04:00
Martin Hanzel
3a082ddbbd
Changed sort_natural filter to use casecmp. Strings only.
2015-05-04 11:55:14 -04:00
Martin Hanzel
03b3446119
Resolves #529 . Resolves #404 . Added natural sorting filter and tests.
2015-05-03 20:55:28 -04:00
James Reid-Smith
4592afcc8b
Updated History.md and removed a couple remaining methods using the old signature
2015-04-27 15:45:44 +00:00