Add support for iterating ranges with float boundaries.

The meaning I gave is to start at the lower bound and step by one. This has the
advantage of having (n..m) and ((n.to_f)..(m.to_f)) behave the same. Another
thing we could do that have this same property is to cast bounds to integer.
This would do the right thing if there is a floating point rounding error, but I
feel it is more surprising for cases such as (1.5..8).

Note that it is not possible to create ranges with floating point boundaries
directly in Liquid at the moment. However, since there is no distinction between
Ruby and Liquid ranges, a drop can introduce such a value by returning it.

.github/probots.yml

@@ -1,2 +0,0 @@
-enabled:
-  - cla

.gitignore

@@ -4,8 +4,6 @@
 pkg
 *.rbc
 .rvmrc
-.idea
 .ruby-version
 Gemfile.lock
 .bundle
-.byebug_history

.rubocop.yml

@@ -1,10 +1,125 @@
-inherit_from:
+inherit_from: ./.rubocop_todo.yml
-  - .rubocop.shopify.yml
 
-require: rubocop-performance
+AllCops:
+  Exclude:
+    - 'performance/shopify/*'
+    - 'pkg/**'
 
-Performance:
+Metrics/BlockNesting:
-  Enabled: true
+  Max: 3
+  Exclude:
+    - 'lib/liquid/block_body.rb'
 
-Metrics/LineLength:
+Metrics/ModuleLength:
-  Enabled: false
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Lint/AssignmentInCondition:
+  Enabled: false
+
+Lint/AmbiguousOperator:
+  Enabled: false
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: false
+
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+Lint/EndAlignment:
+  AlignWith: variable
+
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+
+Style/AndOr:
+  Enabled: false
+
+Style/SignalException:
+  Enabled: false
+
+Style/StringLiterals:
+  Enabled: false
+
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+Style/NumericLiterals:
+  Enabled: false
+
+Style/SpaceInsideBrackets:
+  Enabled: false
+
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/TrailingComma:
+  Enabled: false
+
+Style/IndentHash:
+  EnforcedStyle: consistent
+
+Style/FormatString:
+  Enabled: false
+
+Style/AlignParameters:
+  EnforcedStyle: with_fixed_indentation
+
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/RaiseArgs:
+  Enabled: false
+
+Style/DeprecatedHashMethods:
+  Enabled: false
+
+Style/RegexpLiteral:
+  Enabled: false
+
+Style/SymbolLiteral:
+  Enabled: false
+
+Performance/Count:
+  Enabled: false
+
+Style/ConstantName:
+  Enabled: false
+
+Style/CaseIndentation:
+  Enabled: false
+
+Style/ClassVars:
+  Enabled: false
+
+Style/PerlBackrefs:
+  Enabled: false
+
+Style/TrivialAccessors:
+  AllowPredicates: true
+
+Style/WordArray:
+  Enabled: false

.rubocop_todo.yml

@@ -0,0 +1,72 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-06-08 18:16:16 +0000 using RuboCop version 0.32.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 5
+Lint/NestedMethodDefinition:
+  Enabled: false
+
+# Offense count: 53
+Metrics/AbcSize:
+  Max: 58
+
+# Offense count: 12
+Metrics/CyclomaticComplexity:
+  Max: 15
+
+# Offense count: 553
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 294
+
+# Offense count: 77
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 46
+
+# Offense count: 6
+Metrics/PerceivedComplexity:
+  Max: 13
+
+# Offense count: 1
+Style/AccessorMethodName:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ClosingParenthesisIndentation:
+  Enabled: false
+
+# Offense count: 3
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Enabled: false
+
+# Offense count: 4
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+Style/MethodName:
+  Enabled: false
+
+# Offense count: 1
+Style/MultilineBlockChain:
+  Enabled: false
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+Style/Next:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/WhileUntilModifier:
+  Enabled: false

.travis.yml

@@ -1,13 +1,12 @@
 language: ruby
 
 rvm:
-  - 2.4
+  - 2.1
-  - 2.5
+  - 2.2
-  - 2.6
+  - 2.3.3
-  - 2.7
   - ruby-head
   - jruby-head
-  - truffleruby
+#  - rbx-2
 
 sudo: false
 
@@ -18,13 +17,13 @@ addons:
 
 matrix:
   allow_failures:
-    - rvm: ruby-head
     - rvm: jruby-head
 
 install:
+  - gem install rainbow -v 2.2.1
   - bundle install
 
-script: bundle exec rake
+script: "bundle exec rake"
 
 notifications:
   disable: true

Gemfile

@@ -1,26 +1,17 @@
-# frozen_string_literal: true
-
 source 'https://rubygems.org'
-git_source(:github) do |repo_name|
-  "https://github.com/#{repo_name}.git"
-end
 
 gemspec
 
+gem 'stackprof', platforms: :mri
+
 group :benchmark, :test do
   gem 'benchmark-ips'
-  gem 'memory_profiler'
-
-  install_if -> { RUBY_PLATFORM !~ /mingw|mswin|java/ && RUBY_ENGINE != 'truffleruby' } do
-    gem 'stackprof'
-  end
 end
 
 group :test do
-  gem 'rubocop', '~> 0.74.0', require: false
+  gem 'rubocop', '0.34.2'
-  gem 'rubocop-performance', require: false
 
-  platform :mri, :truffleruby do
+  platform :mri do
-    gem 'liquid-c', github: 'Shopify/liquid-c', ref: '7ba926791ef8411984d0f3e41c6353fd716041c6'
+    gem 'liquid-c', github: 'Shopify/liquid-c', ref: 'bd53db95de3d44d631e7c5a267c3d934e66107dd'
   end
 end

History.md

@@ -1,58 +1,5 @@
 # Liquid Change Log
 
-## 4.0.3 / 2019-03-12
-
-### Fixed
-* Fix break and continue tags inside included templates in loops (#1072) [Justin Li]
-
-## 4.0.2 / 2019-03-08
-
-### Changed
-* Add `where` filter (#1026) [Samuel Doiron]
-* Add `ParseTreeVisitor` to iterate the Liquid AST (#1025) [Stephen Paul Weber]
-* Improve `strip_html` performance (#1032) [printercu]
-
-### Fixed
-* Add error checking for invalid combinations of inputs to sort, sort_natural, where, uniq, map, compact filters (#1059) [Garland Zhang]
-* Validate the character encoding in url_decode (#1070) [Clayton Smith]
-
-## 4.0.1 / 2018-10-09
-
-### Changed
-* Add benchmark group in Gemfile (#855) [Jerry Liu]
-* Allow benchmarks to benchmark render by itself (#851) [Jerry Liu]
-* Avoid calling `line_number` on String node when rescuing a render error. (#860) [Dylan Thacker-Smith]
-* Avoid duck typing to detect whether to call render on a node. [Dylan Thacker-Smith]
-* Clarify spelling of `reversed` on `for` block tag (#843) [Mark Crossfield]
-* Replace recursion with loop to avoid potential stack overflow from malicious input (#891, #892) [Dylan Thacker-Smith]
-* Limit block tag nesting to 100 (#894) [Dylan Thacker-Smith]
-* Replace `assert_equal nil` with `assert_nil` (#895) [Dylan Thacker-Smith]
-* Remove Spy Gem (#896) [Dylan Thacker-Smith]
-* Add `collection_name` and `variable_name` reader to `For` block (#909)
-* Symbols render as strings (#920) [Justin Li]
-* Remove default value from Hash objects (#932) [Maxime Bedard]
-* Remove one level of nesting (#944) [Dylan Thacker-Smith]
-* Update Rubocop version (#952) [Justin Li]
-* Add `at_least` and `at_most` filters (#954, #958) [Nithin Bekal]
-* Add a regression test for a liquid-c trim mode bug (#972) [Dylan Thacker-Smith]
-* Use https rather than git protocol to fetch liquid-c [Dylan Thacker-Smith]
-* Add tests against Ruby 2.4 (#963) and 2.5 (#981)
-* Replace RegExp literals with constants (#988) [Ashwin Maroli]
-* Replace unnecessary `#each_with_index` with `#each` (#992) [Ashwin Maroli]
-* Improve the unexpected end delimiter message for block tags. (#1003) [Dylan Thacker-Smith]
-* Refactor and optimize rendering (#1005) [Christopher Aue]
-* Add installation instruction (#1006) [Ben Gift]
-* Remove Circle CI (#1010)
-* Rename deprecated `BigDecimal.new` to `BigDecimal` (#1024) [Koichi ITO]
-* Rename deprecated Rubocop name (#1027) [Justin Li]
-
-### Fixed
-* Handle `join` filter on non String joiners (#857) [Richard Monette]
-* Fix duplicate inclusion condition logic error of `Liquid::Strainer.add_filter` method (#861)
-* Fix `escape`, `url_encode`, `url_decode` not handling non-string values (#898) [Thierry Joyal]
-* Fix raise when variable is defined but nil when using `strict_variables` [Pascal Betz]
-* Fix `sort` and `sort_natural` to handle arrays with nils (#930) [Eric Chan]
-
 ## 4.0.0 / 2016-12-14 / branch "4-0-stable"
 
 ### Changed
@@ -274,7 +221,7 @@ Yanked from rubygems, as it contained too many changes that broke compatibility.
 * Fixed bad error reporting when a filter called a method which doesn't exist. Liquid told you that it couldn't find the filter which was obviously misleading [Tobias Luetke]
 * Removed count helper from standard lib. use size [Tobias Luetke]
 * Fixed bug with string filter parameters failing to tolerate commas in strings. [Paul Hammond]
-* Improved filter parameters. Filter parameters are now context sensitive; Types are resolved according to the rules of the context. Multiple parameters are now separated by the Liquid::ARGUMENT_SEPARATOR: , by default [Paul Hammond]
+* Improved filter parameters. Filter parameters are now context sensitive; Types are resolved according to the rules of the context. Multiple parameters are now separated by the Liquid::ArgumentSeparator: , by default [Paul Hammond]
     {{ 'Typo' | link_to: 'http://typo.leetsoft.com', 'Typo - a modern weblog engine' }}
 * Added Liquid::Drop. A base class which you can use for exporting proxy objects to liquid which can acquire more data when used in liquid. [Tobias Luetke]
 

README.md

@@ -42,8 +42,6 @@ Liquid is a template engine which was written with very specific requirements:
 
 ## How to use Liquid
 
-Install Liquid by adding `gem 'liquid'` to your gemfile.
-
 Liquid supports a very simple API based around the Liquid::Template class.
 For standard use you can just pass it the content of a file and call render with a parameters hash.
 

Rakefile

@@ -1,33 +1,29 @@
-# frozen_string_literal: true
-
 require 'rake'
 require 'rake/testtask'
-$LOAD_PATH.unshift(File.expand_path('lib', __dir__))
+$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
-require 'liquid/version'
+require "liquid/version"
 
-task(default: %i[test rubocop])
+task default: [:rubocop, :test]
 
-desc('run test suite with default parser')
+desc 'run test suite with default parser'
 Rake::TestTask.new(:base_test) do |t|
   t.libs << '.' << 'lib' << 'test'
   t.test_files = FileList['test/{integration,unit}/**/*_test.rb']
   t.verbose = false
 end
 
-desc('run test suite with warn error mode')
+desc 'run test suite with warn error mode'
 task :warn_test do
   ENV['LIQUID_PARSER_MODE'] = 'warn'
   Rake::Task['base_test'].invoke
 end
 
 task :rubocop do
-  if RUBY_ENGINE == 'ruby'
+  require 'rubocop/rake_task'
-    require 'rubocop/rake_task'
+  RuboCop::RakeTask.new
-    RuboCop::RakeTask.new
-  end
 end
 
-desc('runs test suite with both strict and lax parsers')
+desc 'runs test suite with both strict and lax parsers'
 task :test do
   ENV['LIQUID_PARSER_MODE'] = 'lax'
   Rake::Task['base_test'].invoke
@@ -36,9 +32,8 @@ task :test do
   Rake::Task['base_test'].reenable
   Rake::Task['base_test'].invoke
 
-  if RUBY_ENGINE == 'ruby' || RUBY_ENGINE == 'truffleruby'
+  if RUBY_ENGINE == 'ruby'
-
+    ENV['LIQUID-C'] = '1'
-    ENV['LIQUID_C'] = '1'
 
     ENV['LIQUID_PARSER_MODE'] = 'lax'
     Rake::Task['base_test'].reenable
@@ -50,9 +45,9 @@ task :test do
   end
 end
 
-task(gem: :build)
+task gem: :build
 task :build do
-  system 'gem build liquid.gemspec'
+  system "gem build liquid.gemspec"
 end
 
 task install: :build do
@@ -61,45 +56,38 @@ end
 
 task release: :build do
   system "git tag -a v#{Liquid::VERSION} -m 'Tagging #{Liquid::VERSION}'"
-  system 'git push --tags'
+  system "git push --tags"
   system "gem push liquid-#{Liquid::VERSION}.gem"
   system "rm liquid-#{Liquid::VERSION}.gem"
 end
 
 namespace :benchmark do
-  desc 'Run the liquid benchmark with lax parsing'
+  desc "Run the liquid benchmark with lax parsing"
   task :run do
-    ruby './performance/benchmark.rb lax'
+    ruby "./performance/benchmark.rb lax"
   end
 
-  desc 'Run the liquid benchmark with strict parsing'
+  desc "Run the liquid benchmark with strict parsing"
   task :strict do
-    ruby './performance/benchmark.rb strict'
+    ruby "./performance/benchmark.rb strict"
   end
 end
 
 namespace :profile do
-  desc 'Run the liquid profile/performance coverage'
+  desc "Run the liquid profile/performance coverage"
   task :run do
-    ruby './performance/profile.rb'
+    ruby "./performance/profile.rb"
   end
 
-  desc 'Run the liquid profile/performance coverage with strict parsing'
+  desc "Run the liquid profile/performance coverage with strict parsing"
   task :strict do
-    ruby './performance/profile.rb strict'
+    ruby "./performance/profile.rb strict"
   end
 end
 
-namespace :memory_profile do
+desc "Run example"
-  desc 'Run memory profiler'
-  task :run do
-    ruby './performance/memory_profile.rb'
-  end
-end
-
-desc('Run example')
 task :example do
-  ruby '-w -d -Ilib example/server/server.rb'
+  ruby "-w -d -Ilib example/server/server.rb"
 end
 
 task :console do

circle.yml

@@ -0,0 +1,3 @@
+machine:
+  ruby:
+    version: ruby-2.1

example/server/example_servlet.rb

@@ -1,8 +1,6 @@
-# frozen_string_literal: true
-
 module ProductsFilter
   def price(integer)
-    format('$%.2d USD', integer / 100.0)
+    sprintf("$%.2d USD", integer / 100.0)
   end
 
   def prettyprint(text)
@@ -30,17 +28,17 @@ class Servlet < LiquidServlet
   private
 
   def products_list
-    [{ 'name' => 'Arbor Draft', 'price' => 39_900, 'description' => 'the *arbor draft* is a excellent product' },
+    [{ 'name' => 'Arbor Draft', 'price' => 39900, 'description' => 'the *arbor draft* is a excellent product' },
-     { 'name' => 'Arbor Element', 'price' => 40_000, 'description' => 'the *arbor element* rocks for freestyling' },
+     { 'name' => 'Arbor Element', 'price' => 40000, 'description' => 'the *arbor element* rocks for freestyling' },
-     { 'name' => 'Arbor Diamond', 'price' => 59_900, 'description' => 'the *arbor diamond* is a made up product because im obsessed with arbor and have no creativity' }]
+     { 'name' => 'Arbor Diamond', 'price' => 59900, 'description' => 'the *arbor diamond* is a made up product because im obsessed with arbor and have no creativity' }]
   end
 
   def more_products_list
-    [{ 'name' => 'Arbor Catalyst', 'price' => 39_900, 'description' => 'the *arbor catalyst* is an advanced drop-through for freestyle and flatground performance and versatility' },
+    [{ 'name' => 'Arbor Catalyst', 'price' => 39900, 'description' => 'the *arbor catalyst* is an advanced drop-through for freestyle and flatground performance and versatility' },
-     { 'name' => 'Arbor Fish', 'price' => 40_000, 'description' => 'the *arbor fish* is a compact pin that features an extended wheelbase and time-honored teardrop shape' }]
+     { 'name' => 'Arbor Fish', 'price' => 40000, 'description' => 'the *arbor fish* is a compact pin that features an extended wheelbase and time-honored teardrop shape' }]
   end
 
   def description
-    'List of Products ~ This is a list of products with price and description.'
+    "List of Products ~ This is a list of products with price and description."
   end
 end

example/server/liquid_servlet.rb

@@ -1,28 +1,23 @@
-# frozen_string_literal: true
-
 class LiquidServlet < WEBrick::HTTPServlet::AbstractServlet
-  def get(req, res)
+  def do_GET(req, res)
     handle(:get, req, res)
   end
 
-  def post(req, res)
+  def do_POST(req, res)
     handle(:post, req, res)
   end
 
-  alias_method :do_GET, :get
-  alias_method :do_POST, :post
-
   private
 
-  def handle(_type, req, res)
+  def handle(type, req, res)
     @request = req
     @response = res
 
     @request.path_info =~ /(\w+)\z/
-    @action = Regexp.last_match(1) || 'index'
+    @action = $1 || 'index'
     @assigns = send(@action) if respond_to?(@action)
 
-    @response['Content-Type'] = 'text/html'
+    @response['Content-Type'] = "text/html"
     @response.status = 200
     @response.body = Liquid::Template.parse(read_template).render(@assigns, filters: [ProductsFilter])
   end

example/server/server.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'webrick'
 require 'rexml/document'
 
@@ -10,5 +8,5 @@ require_relative 'example_servlet'
 # Setup webrick
 server = WEBrick::HTTPServer.new(Port: ARGV[1] || 3000)
 server.mount('/', Servlet)
-trap('INT') { server.shutdown }
+trap("INT"){ server.shutdown }
 server.start

lib/liquid.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 # Copyright (c) 2005 Tobias Luetke
 #
 # Permission is hereby granted, free of charge, to any person obtaining
@@ -22,32 +20,31 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 module Liquid
-  FILTER_SEPARATOR = /\|/.freeze
+  FilterSeparator             = /\|/
-  ARGUMENT_SEPARATOR = ','
+  ArgumentSeparator           = ','.freeze
-  FILTER_ARGUMENT_SEPARATOR = ':'
+  FilterArgumentSeparator     = ':'.freeze
-  VARIABLE_ATTRIBUTE_SEPARATOR = '.'
+  VariableAttributeSeparator  = '.'.freeze
-  WHITESPACE_CONTROL = '-'
+  WhitespaceControl           = '-'.freeze
-  TAG_START = /\{\%/.freeze
+  TagStart                    = /\{\%/
-  TAG_END = /\%\}/.freeze
+  TagEnd                      = /\%\}/
-  VARIABLE_SIGNATURE = /\(?[\w\-\.\[\]]\)?/.freeze
+  VariableSignature           = /\(?[\w\-\.\[\]]\)?/
-  VARIABLE_SEGMENT = /[\w\-]/.freeze
+  VariableSegment             = /[\w\-]/
-  VARIABLE_START = /\{\{/.freeze
+  VariableStart               = /\{\{/
-  VARIABLE_END = /\}\}/.freeze
+  VariableEnd                 = /\}\}/
-  VARIABLE_INCOMPLETE_END = /\}\}?/.freeze
+  VariableIncompleteEnd       = /\}\}?/
-  QUOTED_STRING = /"[^"]*"|'[^']*'/.freeze
+  QuotedString                = /"[^"]*"|'[^']*'/
-  QUOTED_FRAGMENT = /#{QUOTED_STRING}|(?:[^\s,\|'"]|#{QUOTED_STRING})+/o.freeze
+  QuotedFragment              = /#{QuotedString}|(?:[^\s,\|'"]|#{QuotedString})+/o
-  TAG_ATTRIBUTES = /(\w+)\s*\:\s*(#{QUOTED_FRAGMENT})/o.freeze
+  TagAttributes               = /(\w+)\s*\:\s*(#{QuotedFragment})/o
-  ANY_STARTING_TAG = /#{TAG_START}|#{VARIABLE_START}/o.freeze
+  AnyStartingTag              = /#{TagStart}|#{VariableStart}/o
-  PARTIAL_TEMPLATE_PARSER = /#{TAG_START}.*?#{TAG_END}|#{VARIABLE_START}.*?#{VARIABLE_INCOMPLETE_END}/om.freeze
+  PartialTemplateParser       = /#{TagStart}.*?#{TagEnd}|#{VariableStart}.*?#{VariableIncompleteEnd}/om
-  TEMPLATE_PARSER = /(#{PARTIAL_TEMPLATE_PARSER}|#{ANY_STARTING_TAG})/om.freeze
+  TemplateParser              = /(#{PartialTemplateParser}|#{AnyStartingTag})/om
-  VARIABLE_PARSER = /\[[^\]]+\]|#{VARIABLE_SEGMENT}+\??/o.freeze
+  VariableParser              = /\[[^\]]+\]|#{VariableSegment}+\??/o
 
   singleton_class.send(:attr_accessor, :cache_classes)
   self.cache_classes = true
 end
 
-require 'liquid/version'
+require "liquid/version"
-require 'liquid/parse_tree_visitor'
 require 'liquid/lexer'
 require 'liquid/parser'
 require 'liquid/i18n'

lib/liquid/block.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class Block < Tag
     MAX_DEPTH = 100
@@ -15,7 +13,6 @@ module Liquid
       end
     end
 
-    # For backwards compatibility
     def render(context)
       @body.render(context)
     end
@@ -29,16 +26,16 @@ module Liquid
     end
 
     def unknown_tag(tag, _params, _tokens)
-      if tag == 'else'
+      case tag
-        raise SyntaxError, parse_context.locale.t('errors.syntax.unexpected_else',
+      when 'else'.freeze
-                                                  block_name: block_name)
+        raise SyntaxError.new(parse_context.locale.t("errors.syntax.unexpected_else".freeze,
-      elsif tag.start_with?('end')
+          block_name: block_name))
-        raise SyntaxError, parse_context.locale.t('errors.syntax.invalid_delimiter',
+      when 'end'.freeze
-                                                  tag: tag,
+        raise SyntaxError.new(parse_context.locale.t("errors.syntax.invalid_delimiter".freeze,
-                                                  block_name: block_name,
+          block_name: block_name,
-                                                  block_delimiter: block_delimiter)
+          block_delimiter: block_delimiter))
       else
-        raise SyntaxError, parse_context.locale.t('errors.syntax.unknown_tag', tag: tag)
+        raise SyntaxError.new(parse_context.locale.t("errors.syntax.unknown_tag".freeze, tag: tag))
       end
     end
 
@@ -53,15 +50,18 @@ module Liquid
     protected
 
     def parse_body(body, tokens)
-      raise StackLevelError, 'Nesting too deep' if parse_context.depth >= MAX_DEPTH
+      if parse_context.depth >= MAX_DEPTH
-
+        raise StackLevelError, "Nesting too deep".freeze
+      end
       parse_context.depth += 1
       begin
         body.parse(tokens, parse_context) do |end_tag_name, end_tag_params|
           @blank &&= body.blank?
 
           return false if end_tag_name == block_delimiter
-          raise SyntaxError, parse_context.locale.t('errors.syntax.tag_never_closed', block_name: block_name) unless end_tag_name
+          unless end_tag_name
+            raise SyntaxError.new(parse_context.locale.t("errors.syntax.tag_never_closed".freeze, block_name: block_name))
+          end
 
           # this tag is not registered with the system
           # pass it to the current block for special handling or error reporting

lib/liquid/block_body.rb

@@ -1,12 +1,9 @@
-# frozen_string_literal: true
-
 module Liquid
   class BlockBody
-    FULL_TOKEN = /\A#{TAG_START}#{WHITESPACE_CONTROL}?\s*(\w+)\s*(.*?)#{WHITESPACE_CONTROL}?#{TAG_END}\z/om.freeze
+    FullToken = /\A#{TagStart}#{WhitespaceControl}?\s*(\w+)\s*(.*?)#{WhitespaceControl}?#{TagEnd}\z/om
-    CONTENT_OF_VARIABLE = /\A#{VARIABLE_START}#{WHITESPACE_CONTROL}?(.*?)#{WHITESPACE_CONTROL}?#{VARIABLE_END}\z/om.freeze
+    ContentOfVariable = /\A#{VariableStart}#{WhitespaceControl}?(.*?)#{WhitespaceControl}?#{VariableEnd}\z/om
-    WHITESPACE_OR_NOTHING = /\A\s*\z/.freeze
+    TAGSTART = "{%".freeze
-    TAG_START = '{%'
+    VARSTART = "{{".freeze
-    VAR_START = '{{'
 
     attr_reader :nodelist
 
@@ -17,34 +14,39 @@ module Liquid
 
     def parse(tokenizer, parse_context)
       parse_context.line_number = tokenizer.line_number
-      while (token = tokenizer.shift)
+      while token = tokenizer.shift
-        next if token.empty?
+        unless token.empty?
-
+          case
-        case
+          when token.start_with?(TAGSTART)
-        when token.start_with?(TAG_START)
+            whitespace_handler(token, parse_context)
-          whitespace_handler(token, parse_context)
+            if token =~ FullToken
-          raise_missing_tag_terminator(token, parse_context) unless token =~ FULL_TOKEN
+              tag_name = $1
-          tag_name = Regexp.last_match(1)
+              markup = $2
-          markup = Regexp.last_match(2)
+              # fetch the tag from registered blocks
-          # fetch the tag from registered blocks
+              if tag = registered_tags[tag_name]
-          unless (tag = registered_tags[tag_name])
+                new_tag = tag.parse(tag_name, markup, tokenizer, parse_context)
-            # end parsing if we reach an unknown tag and let the caller decide
+                @blank &&= new_tag.blank?
-            # determine how to proceed
+                @nodelist << new_tag
-            return yield tag_name, markup
+              else
+                # end parsing if we reach an unknown tag and let the caller decide
+                # determine how to proceed
+                return yield tag_name, markup
+              end
+            else
+              raise_missing_tag_terminator(token, parse_context)
+            end
+          when token.start_with?(VARSTART)
+            whitespace_handler(token, parse_context)
+            @nodelist << create_variable(token, parse_context)
+            @blank = false
+          else
+            if parse_context.trim_whitespace
+              token.lstrip!
+            end
+            parse_context.trim_whitespace = false
+            @nodelist << token
+            @blank &&= !!(token =~ /\A\s*\z/)
           end
-
-          new_tag = tag.parse(tag_name, markup, tokenizer, parse_context)
-          @blank &&= new_tag.blank?
-          @nodelist << new_tag
-        when token.start_with?(VAR_START)
-          whitespace_handler(token, parse_context)
-          @nodelist << create_variable(token, parse_context)
-          @blank = false
-        else
-          token.lstrip! if parse_context.trim_whitespace
-          parse_context.trim_whitespace = false
-          @nodelist << token
-          @blank &&= token.match?(WHITESPACE_OR_NOTHING)
         end
         parse_context.line_number = tokenizer.line_number
       end
@@ -53,11 +55,13 @@ module Liquid
     end
 
     def whitespace_handler(token, parse_context)
-      if token[2] == WHITESPACE_CONTROL
+      if token[2] == WhitespaceControl
         previous_token = @nodelist.last
-        previous_token.rstrip! if previous_token.is_a?(String)
+        if previous_token.is_a? String
+          previous_token.rstrip!
+        end
       end
-      parse_context.trim_whitespace = (token[-3] == WHITESPACE_CONTROL)
+      parse_context.trim_whitespace = (token[-3] == WhitespaceControl)
     end
 
     def blank?
@@ -65,62 +69,56 @@ module Liquid
     end
 
     def render(context)
-      render_to_output_buffer(context, +'')
+      output = []
-    end
-
-    def render_to_output_buffer(context, output)
       context.resource_limits.render_score += @nodelist.length
 
-      idx = 0
+      @nodelist.each do |token|
-      while (node = @nodelist[idx])
+        # Break out if we have any unhanded interrupts.
-        previous_output_size = output.bytesize
+        break if context.interrupt?
 
-        case node
+        begin
-        when String
-          output << node
-        when Variable
-          render_node(context, output, node)
-        when Block
-          render_node(context, node.blank? ? +'' : output, node)
-          break if context.interrupt? # might have happened in a for-block
-        when Continue, Break
           # If we get an Interrupt that means the block must stop processing. An
           # Interrupt is any command that stops block execution such as {% break %}
           # or {% continue %}
-          context.push_interrupt(node.interrupt)
+          if token.is_a?(Continue) || token.is_a?(Break)
-          break
+            context.push_interrupt(token.interrupt)
-        else # Other non-Block tags
+            break
-          render_node(context, output, node)
+          end
-          break if context.interrupt? # might have happened through an include
-        end
-        idx += 1
 
-        raise_if_resource_limits_reached(context, output.bytesize - previous_output_size)
+          node_output = render_node(token, context)
+
+          unless token.is_a?(Block) && token.blank?
+            output << node_output
+          end
+        rescue MemoryError => e
+          raise e
+        rescue UndefinedVariable, UndefinedDropMethod, UndefinedFilter => e
+          context.handle_error(e, token.line_number)
+          output << nil
+        rescue ::StandardError => e
+          line_number = token.is_a?(String) ? nil : token.line_number
+          output << context.handle_error(e, line_number)
+        end
       end
 
-      output
+      output.join
     end
 
     private
 
-    def render_node(context, output, node)
+    def render_node(node, context)
-      node.render_to_output_buffer(context, output)
+      node_output = node.is_a?(String) ? node : node.render(context)
-    rescue UndefinedVariable, UndefinedDropMethod, UndefinedFilter => e
+      node_output = node_output.is_a?(Array) ? node_output.join : node_output.to_s
-      context.handle_error(e, node.line_number)
-    rescue ::StandardError => e
-      line_number = node.is_a?(String) ? nil : node.line_number
-      output << context.handle_error(e, line_number)
-    end
 
-    def raise_if_resource_limits_reached(context, length)
+      context.resource_limits.render_length += node_output.length
-      context.resource_limits.render_length += length
+      if context.resource_limits.reached?
-      return unless context.resource_limits.reached?
+        raise MemoryError.new("Memory limits exceeded".freeze)
-
+      end
-      raise MemoryError, 'Memory limits exceeded'
+      node_output
     end
 
     def create_variable(token, parse_context)
-      token.scan(CONTENT_OF_VARIABLE) do |content|
+      token.scan(ContentOfVariable) do |content|
         markup = content.first
         return Variable.new(markup, parse_context)
       end
@@ -128,11 +126,11 @@ module Liquid
     end
 
     def raise_missing_tag_terminator(token, parse_context)
-      raise SyntaxError, parse_context.locale.t('errors.syntax.tag_termination', token: token, tag_end: TAG_END.inspect)
+      raise SyntaxError.new(parse_context.locale.t("errors.syntax.tag_termination".freeze, token: token, tag_end: TagEnd.inspect))
     end
 
     def raise_missing_variable_terminator(token, parse_context)
-      raise SyntaxError, parse_context.locale.t('errors.syntax.variable_termination', token: token, tag_end: VARIABLE_END.inspect)
+      raise SyntaxError.new(parse_context.locale.t("errors.syntax.variable_termination".freeze, token: token, tag_end: VariableEnd.inspect))
     end
 
     def registered_tags

lib/liquid/condition.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Container for liquid nodes which conveniently wraps decision making logic
   #
@@ -9,36 +7,36 @@ module Liquid
   #   c.evaluate #=> true
   #
   class Condition #:nodoc:
-    @operators = {
+    @@operators = {
-      '==' => ->(cond, left, right) {  cond.send(:equal_variables, left, right) },
+      '=='.freeze => ->(cond, left, right) {  cond.send(:equal_variables, left, right) },
-      '!=' => ->(cond, left, right) { !cond.send(:equal_variables, left, right) },
+      '!='.freeze => ->(cond, left, right) { !cond.send(:equal_variables, left, right) },
-      '<>' => ->(cond, left, right) { !cond.send(:equal_variables, left, right) },
+      '<>'.freeze => ->(cond, left, right) { !cond.send(:equal_variables, left, right) },
-      '<' => :<,
+      '<'.freeze  => :<,
-      '>' => :>,
+      '>'.freeze  => :>,
-      '>=' => :>=,
+      '>='.freeze => :>=,
-      '<=' => :<=,
+      '<='.freeze => :<=,
-      'contains' => lambda do |_cond, left, right|
+      'contains'.freeze => lambda do |cond, left, right|
         if left && right && left.respond_to?(:include?)
           right = right.to_s if left.is_a?(String)
           left.include?(right)
         else
           false
         end
-      end,
+      end
     }
 
-    class << self
+    def self.operators
-      attr_accessor :operators
+      @@operators
     end
 
-    attr_reader :attachment, :child_condition
+    attr_reader :attachment
     attr_accessor :left, :operator, :right
 
     def initialize(left = nil, operator = nil, right = nil)
       @left = left
       @operator = operator
       @right = right
-      @child_relation = nil
+      @child_relation  = nil
       @child_condition = nil
     end
 
@@ -80,12 +78,12 @@ module Liquid
     end
 
     def inspect
-      "#<Condition #{[@left, @operator, @right].compact.join(' ')}>"
+      "#<Condition #{[@left, @operator, @right].compact.join(' '.freeze)}>"
     end
 
     protected
 
-    attr_reader :child_relation
+    attr_reader :child_relation, :child_condition
 
     private
 
@@ -118,7 +116,7 @@ module Liquid
       left = context.evaluate(left)
       right = context.evaluate(right)
 
-      operation = self.class.operators[op] || raise(Liquid::ArgumentError, "Unknown operator #{op}")
+      operation = self.class.operators[op] || raise(Liquid::ArgumentError.new("Unknown operator #{op}"))
 
       if operation.respond_to?(:call)
         operation.call(self, left, right)
@@ -126,19 +124,10 @@ module Liquid
         begin
           left.send(operation, right)
         rescue ::ArgumentError => e
-          raise Liquid::ArgumentError, e.message
+          raise Liquid::ArgumentError.new(e.message)
         end
       end
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        [
-          @node.left, @node.right,
-          @node.child_condition, @node.attachment
-        ].compact
-      end
-    end
   end
 
   class ElseCondition < Condition

lib/liquid/context.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Context keeps the variable stack and resolves variables, as well as keywords
   #
@@ -30,7 +28,9 @@ module Liquid
       @this_stack_used = false
 
       self.exception_renderer = Template.default_exception_renderer
-      self.exception_renderer = ->(_e) { raise } if rethrow_errors
+      if rethrow_errors
+        self.exception_renderer = ->(e) { raise }
+      end
 
       @interrupts = []
       @filters = []
@@ -89,7 +89,7 @@ module Liquid
     # Push new local scope on the stack. use <tt>Context#stack</tt> instead
     def push(new_scope = {})
       @scopes.unshift(new_scope)
-      raise StackLevelError, 'Nesting too deep' if @scopes.length > Block::MAX_DEPTH
+      raise StackLevelError, "Nesting too deep".freeze if @scopes.length > Block::MAX_DEPTH
     end
 
     # Merge a hash of variables in the current local scope
@@ -100,7 +100,6 @@ module Liquid
     # Pop from the stack. use <tt>Context#stack</tt> instead
     def pop
       raise ContextError if @scopes.size == 1
-
       @scopes.shift
     end
 
@@ -172,9 +171,7 @@ module Liquid
       if scope.nil?
         @environments.each do |e|
           variable = lookup_and_evaluate(e, key, raise_on_not_found: raise_on_not_found)
-          # When lookup returned a value OR there is no value but the lookup also did not raise
+          unless variable.nil?
-          # then it is the value we are looking for.
-          if !variable.nil? || @strict_variables && raise_on_not_found
             scope = e
             break
           end
@@ -191,12 +188,14 @@ module Liquid
     end
 
     def lookup_and_evaluate(obj, key, raise_on_not_found: true)
-      raise Liquid::UndefinedVariable, "undefined variable #{key}" if @strict_variables && raise_on_not_found && obj.respond_to?(:key?) && !obj.key?(key)
+      if @strict_variables && raise_on_not_found && obj.respond_to?(:key?) && !obj.key?(key)
+        raise Liquid::UndefinedVariable, "undefined variable #{key}"
+      end
 
       value = obj[key]
 
       if value.is_a?(Proc) && obj.respond_to?(:[]=)
-        obj[key] = value.arity == 0 ? value.call : value.call(self)
+        obj[key] = (value.arity == 0) ? value.call : value.call(self)
       else
         value
       end
@@ -207,8 +206,8 @@ module Liquid
     def internal_error
       # raise and catch to set backtrace and cause on exception
       raise Liquid::InternalError, 'internal'
-    rescue Liquid::InternalError => e
+    rescue Liquid::InternalError => exc
-      e
+      exc
     end
 
     def squash_instance_assigns_with_environments

lib/liquid/document.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class Document < BlockBody
     def self.parse(tokens, parse_context)
@@ -9,7 +7,7 @@ module Liquid
     end
 
     def parse(tokens, parse_context)
-      super do |end_tag_name, _end_tag_params|
+      super do |end_tag_name, end_tag_params|
         unknown_tag(end_tag_name, parse_context) if end_tag_name
       end
     rescue SyntaxError => e
@@ -19,10 +17,10 @@ module Liquid
 
     def unknown_tag(tag, parse_context)
       case tag
-      when 'else', 'end'
+      when 'else'.freeze, 'end'.freeze
-        raise SyntaxError, parse_context.locale.t('errors.syntax.unexpected_outer_tag', tag: tag)
+        raise SyntaxError.new(parse_context.locale.t("errors.syntax.unexpected_outer_tag".freeze, tag: tag))
       else
-        raise SyntaxError, parse_context.locale.t('errors.syntax.unknown_tag', tag: tag)
+        raise SyntaxError.new(parse_context.locale.t("errors.syntax.unknown_tag".freeze, tag: tag))
       end
     end
   end

lib/liquid/drop.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'set'
 
 module Liquid
@@ -27,8 +25,7 @@ module Liquid
 
     # Catch all for the method
     def liquid_method_missing(method)
-      return nil unless @context&.strict_variables
+      return nil unless @context && @context.strict_variables
-
       raise Liquid::UndefinedDropMethod, "undefined method #{method}"
     end
 
@@ -70,7 +67,7 @@ module Liquid
 
         if include?(Enumerable)
           blacklist += Enumerable.public_instance_methods
-          blacklist -= %i[sort count first min max include?]
+          blacklist -= [:sort, :count, :first, :min, :max, :include?]
         end
 
         whitelist = [:to_liquid] + (public_instance_methods - blacklist)

lib/liquid/errors.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class Error < ::StandardError
     attr_accessor :line_number
@@ -7,12 +5,12 @@ module Liquid
     attr_accessor :markup_context
 
     def to_s(with_prefix = true)
-      str = +''
+      str = ""
       str << message_prefix if with_prefix
       str << super()
 
       if markup_context
-        str << ' '
+        str << " "
         str << markup_context
       end
 
@@ -22,20 +20,20 @@ module Liquid
     private
 
     def message_prefix
-      str = +''
+      str = ""
-      str << if is_a?(SyntaxError)
+      if is_a?(SyntaxError)
-        'Liquid syntax error'
+        str << "Liquid syntax error"
       else
-        'Liquid error'
+        str << "Liquid error"
       end
 
       if line_number
-        str << ' ('
+        str << " ("
-        str << template_name << ' ' if template_name
+        str << template_name << " " if template_name
-        str << 'line ' << line_number.to_s << ')'
+        str << "line " << line_number.to_s << ")"
       end
 
-      str << ': '
+      str << ": "
       str
     end
   end

lib/liquid/expression.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class Expression
     class MethodLiteral
@@ -16,32 +14,28 @@ module Liquid
     end
 
     LITERALS = {
-      nil => nil, 'nil' => nil, 'null' => nil, '' => nil,
+      nil => nil, 'nil'.freeze => nil, 'null'.freeze => nil, ''.freeze => nil,
-      'true' => true,
+      'true'.freeze  => true,
-      'false' => false,
+      'false'.freeze => false,
-      'blank' => MethodLiteral.new(:blank?, '').freeze,
+      'blank'.freeze => MethodLiteral.new(:blank?, '').freeze,
-      'empty' => MethodLiteral.new(:empty?, '').freeze
+      'empty'.freeze => MethodLiteral.new(:empty?, '').freeze
-    }.freeze
+    }
-
-    SINGLE_QUOTED_STRING = /\A'(.*)'\z/m.freeze
-    DOUBLE_QUOTED_STRING = /\A"(.*)"\z/m.freeze
-    INTEGERS_REGEX       = /\A(-?\d+)\z/.freeze
-    FLOATS_REGEX         = /\A(-?\d[\d\.]+)\z/.freeze
-    RANGES_REGEX         = /\A\((\S+)\.\.(\S+)\)\z/.freeze
 
     def self.parse(markup)
       if LITERALS.key?(markup)
         LITERALS[markup]
       else
         case markup
-        when SINGLE_QUOTED_STRING, DOUBLE_QUOTED_STRING
+        when /\A'(.*)'\z/m # Single quoted strings
-          Regexp.last_match(1)
+          $1
-        when INTEGERS_REGEX
+        when /\A"(.*)"\z/m # Double quoted strings
-          Regexp.last_match(1).to_i
+          $1
-        when RANGES_REGEX
+        when /\A(-?\d+)\z/ # Integer and floats
-          RangeLookup.parse(Regexp.last_match(1), Regexp.last_match(2))
+          $1.to_i
-        when FLOATS_REGEX
+        when /\A\((\S+)\.\.(\S+)\)\z/ # Ranges
-          Regexp.last_match(1).to_f
+          RangeLookup.parse($1, $2)
+        when /\A(-?\d[\d\.]+)\z/ # Floats
+          $1.to_f
         else
           VariableLookup.parse(markup)
         end

lib/liquid/extensions.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'time'
 require 'date'
 
@@ -9,12 +7,6 @@ class String # :nodoc:
   end
 end
 
-class Symbol # :nodoc:
-  def to_liquid
-    to_s
-  end
-end
-
 class Array # :nodoc:
   def to_liquid
     self

lib/liquid/file_system.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # A Liquid file system is a way to let your templates retrieve other templates for use with the include tag.
   #
@@ -17,7 +15,7 @@ module Liquid
   class BlankFileSystem
     # Called by Liquid to retrieve a template file
     def read_template_file(_template_path)
-      raise FileSystemError, 'This liquid context does not allow includes.'
+      raise FileSystemError, "This liquid context does not allow includes."
     end
   end
 
@@ -46,7 +44,7 @@ module Liquid
   class LocalFileSystem
     attr_accessor :root
 
-    def initialize(root, pattern = '_%s.liquid')
+    def initialize(root, pattern = "_%s.liquid".freeze)
       @root = root
       @pattern = pattern
     end
@@ -59,9 +57,9 @@ module Liquid
     end
 
     def full_path(template_path)
-      raise FileSystemError, "Illegal template name '#{template_path}'" unless template_path =~ %r{\A[^./][a-zA-Z0-9_/]+\z}
+      raise FileSystemError, "Illegal template name '#{template_path}'" unless template_path =~ /\A[^.\/][a-zA-Z0-9_\/]+\z/
 
-      full_path = if template_path.include?('/')
+      full_path = if template_path.include?('/'.freeze)
         File.join(root, File.dirname(template_path), @pattern % File.basename(template_path))
       else
         File.join(root, @pattern % template_path)

lib/liquid/forloop_drop.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class ForloopDrop < Drop
     def initialize(name, length, parentloop)

lib/liquid/i18n.rb

@@ -1,10 +1,8 @@
-# frozen_string_literal: true
-
 require 'yaml'
 
 module Liquid
   class I18n
-    DEFAULT_LOCALE = File.join(File.expand_path(__dir__), 'locales', 'en.yml')
+    DEFAULT_LOCALE = File.join(File.expand_path(__dir__), "locales", "en.yml")
 
     TranslationError = Class.new(StandardError)
 
@@ -28,13 +26,13 @@ module Liquid
     def interpolate(name, vars)
       name.gsub(/%\{(\w+)\}/) do
         # raise TranslationError, "Undefined key #{$1} for interpolation in translation #{name}"  unless vars[$1.to_sym]
-        (vars[Regexp.last_match(1).to_sym]).to_s
+        "#{vars[$1.to_sym]}"
       end
     end
 
     def deep_fetch_translation(name)
-      name.split('.').reduce(locale) do |level, cur|
+      name.split('.'.freeze).reduce(locale) do |level, cur|
-        level[cur] || raise(TranslationError, "Translation for #{name} does not exist in locale #{path}")
+        level[cur] or raise TranslationError, "Translation for #{name} does not exist in locale #{path}"
       end
     end
   end

lib/liquid/interrupts.rb

@@ -1,18 +1,16 @@
-# frozen_string_literal: true
-
 module Liquid
   # An interrupt is any command that breaks processing of a block (ex: a for loop).
   class Interrupt
     attr_reader :message
 
     def initialize(message = nil)
-      @message = message || 'interrupt'
+      @message = message || "interrupt".freeze
     end
   end
 
   # Interrupt that is thrown whenever a {% break %} is called.
-  class BreakInterrupt < RuntimeError; end
+  class BreakInterrupt < Interrupt; end
 
   # Interrupt that is thrown whenever a {% continue %} is called.
-  class ContinueInterrupt < RuntimeError; end
+  class ContinueInterrupt < Interrupt; end
 end

lib/liquid/legacy.rb

@@ -1,79 +0,0 @@
-# frozen_string_literal: true
-
-module Liquid
-  FilterSeparator = FILTER_SEPARATOR
-  ArgumentSeparator = ARGUMENT_SEPARATOR
-  FilterArgumentSeparator = FILTER_ARGUMENT_SEPARATOR
-  VariableAttributeSeparator = VARIABLE_ATTRIBUTE_SEPARATOR
-  WhitespaceControl = WHITESPACE_CONTROL
-  TagStart = TAG_START
-  TagEnd = TAG_END
-  VariableSignature = VARIABLE_SIGNATURE
-  VariableSegment = VARIABLE_SEGMENT
-  VariableStart = VARIABLE_START
-  VariableEnd = VARIABLE_END
-  VariableIncompleteEnd = VARIABLE_INCOMPLETE_END
-  QuotedString = QUOTED_STRING
-  QuotedFragment = QUOTED_FRAGMENT
-  TagAttributes = TAG_ATTRIBUTES
-  AnyStartingTag = ANY_STARTING_TAG
-  PartialTemplateParser = PARTIAL_TEMPLATE_PARSER
-  TemplateParser = TEMPLATE_PARSER
-  VariableParser = VARIABLE_PARSER
-
-  class BlockBody
-    FullToken = FULL_TOKEN
-    ContentOfVariable = CONTENT_OF_VARIABLE
-    WhitespaceOrNothing = WHITESPACE_OR_NOTHING
-    TAGSTART = TAG_START
-    VARSTART = VAR_START
-  end
-
-  class Assign < Tag
-    Syntax = SYNTAX
-  end
-
-  class Capture < Block
-    Syntax = SYNTAX
-  end
-
-  class Case < Block
-    Syntax     = SYNTAX
-    WhenSyntax = WHEN_SYNTAX
-  end
-
-  class Cycle < Tag
-    SimpleSyntax = SIMPLE_SYNTAX
-    NamedSyntax  = NAMED_SYNTAX
-  end
-
-  class For < Block
-    Syntax = SYNTAX
-  end
-
-  class If < Block
-    Syntax = SYNTAX
-    ExpressionsAndOperators = EXPRESSIONS_AND_OPERATORS
-  end
-
-  class Include < Tag
-    Syntax = SYNTAX
-  end
-
-  class Raw < Block
-    Syntax = SYNTAX
-    FullTokenPossiblyInvalid = FULL_TOKEN_POSSIBLY_INVALID
-  end
-
-  class TableRow < Block
-    Syntax = SYNTAX
-  end
-
-  class Variable
-    FilterMarkupRegex = FILTER_MARKUP_REGEX
-    FilterParser = FILTER_PARSER
-    FilterArgsRegex = FILTER_ARGS_REGEX
-    JustTagAttributes = JUST_TAG_ATTRIBUTES
-    MarkupWithQuotedFragment = MARKUP_WITH_QUOTED_FRAGMENT
-  end
-end

lib/liquid/lexer.rb

@@ -1,27 +1,24 @@
-# frozen_string_literal: true
+require "strscan"
-
-require 'strscan'
 module Liquid
   class Lexer
     SPECIALS = {
-      '|' => :pipe,
+      '|'.freeze => :pipe,
-      '.' => :dot,
+      '.'.freeze => :dot,
-      ':' => :colon,
+      ':'.freeze => :colon,
-      ',' => :comma,
+      ','.freeze => :comma,
-      '[' => :open_square,
+      '['.freeze => :open_square,
-      ']' => :close_square,
+      ']'.freeze => :close_square,
-      '(' => :open_round,
+      '('.freeze => :open_round,
-      ')' => :close_round,
+      ')'.freeze => :close_round,
-      '?' => :question,
+      '?'.freeze => :question,
-      '-' => :dash,
+      '-'.freeze => :dash
-    }.freeze
+    }
-    IDENTIFIER = /[a-zA-Z_][\w-]*\??/.freeze
+    IDENTIFIER = /[a-zA-Z_][\w-]*\??/
-    SINGLE_STRING_LITERAL = /'[^\']*'/.freeze
+    SINGLE_STRING_LITERAL = /'[^\']*'/
-    DOUBLE_STRING_LITERAL = /"[^\"]*"/.freeze
+    DOUBLE_STRING_LITERAL = /"[^\"]*"/
-    NUMBER_LITERAL = /-?\d+(\.\d+)?/.freeze
+    NUMBER_LITERAL = /-?\d+(\.\d+)?/
-    DOTDOT = /\.\./.freeze
+    DOTDOT = /\.\./
-    COMPARISON_OPERATOR = /==|!=|<>|<=?|>=?|contains(?=\s)/.freeze
+    COMPARISON_OPERATOR = /==|!=|<>|<=?|>=?|contains(?=\s)/
-    WHITESPACE_OR_NOTHING = /\s*/.freeze
 
     def initialize(input)
       @ss = StringScanner.new(input)
@@ -31,18 +28,18 @@ module Liquid
       @output = []
 
       until @ss.eos?
-        @ss.skip(WHITESPACE_OR_NOTHING)
+        @ss.skip(/\s*/)
         break if @ss.eos?
-
+        tok = case
-        tok = if (t = @ss.scan(COMPARISON_OPERATOR)) then [:comparison, t]
+        when t = @ss.scan(COMPARISON_OPERATOR) then [:comparison, t]
-        elsif (t = @ss.scan(SINGLE_STRING_LITERAL)) then [:string, t]
+        when t = @ss.scan(SINGLE_STRING_LITERAL) then [:string, t]
-        elsif (t = @ss.scan(DOUBLE_STRING_LITERAL)) then [:string, t]
+        when t = @ss.scan(DOUBLE_STRING_LITERAL) then [:string, t]
-        elsif (t = @ss.scan(NUMBER_LITERAL)) then [:number, t]
+        when t = @ss.scan(NUMBER_LITERAL) then [:number, t]
-        elsif (t = @ss.scan(IDENTIFIER)) then [:id, t]
+        when t = @ss.scan(IDENTIFIER) then [:id, t]
-        elsif (t = @ss.scan(DOTDOT)) then [:dotdot, t]
+        when t = @ss.scan(DOTDOT) then [:dotdot, t]
         else
           c = @ss.getch
-          if (s = SPECIALS[c])
+          if s = SPECIALS[c]
             [s, c]
           else
             raise SyntaxError, "Unexpected character #{c}"

lib/liquid/locales/en.yml

@@ -14,7 +14,7 @@
       if: "Syntax Error in tag 'if' - Valid syntax: if [expression]"
       include: "Error in tag 'include' - Valid syntax: include '[template]' (with|for) [object|collection]"
       unknown_tag: "Unknown tag '%{tag}'"
-      invalid_delimiter: "'%{tag}' is not a valid delimiter for %{block_name} tags. use %{block_delimiter}"
+      invalid_delimiter: "'end' is not a valid delimiter for %{block_name} tags. use %{block_delimiter}"
       unexpected_else: "%{block_name} tag does not expect 'else' tag"
       unexpected_outer_tag: "Unexpected outer '%{tag}' tag"
       tag_termination: "Tag '%{token}' was not properly terminated with regexp: %{tag_end}"

lib/liquid/parse_context.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class ParseContext
     attr_accessor :locale, :line_number, :trim_whitespace, :depth
@@ -21,6 +19,7 @@ module Liquid
       @partial = value
       @options = value ? partial_options : @template_options
       @error_mode = @options[:error_mode] || Template.error_mode
+      value
     end
 
     def partial_options
@@ -29,7 +28,7 @@ module Liquid
         if dont_pass == true
           { locale: locale }
         elsif dont_pass.is_a?(Array)
-          @template_options.reject { |k, _v| dont_pass.include?(k) }
+          @template_options.reject { |k, v| dont_pass.include?(k) }
         else
           @template_options
         end

lib/liquid/parse_tree_visitor.rb

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-module Liquid
-  class ParseTreeVisitor
-    def self.for(node, callbacks = Hash.new(proc {}))
-      if defined?(node.class::ParseTreeVisitor)
-        node.class::ParseTreeVisitor
-      else
-        self
-      end.new(node, callbacks)
-    end
-
-    def initialize(node, callbacks)
-      @node = node
-      @callbacks = callbacks
-    end
-
-    def add_callback_for(*classes, &block)
-      callback = block
-      callback = ->(node, _) { yield node } if block.arity.abs == 1
-      callback = ->(_, _) { yield } if block.arity.zero?
-      classes.each { |klass| @callbacks[klass] = callback }
-      self
-    end
-
-    def visit(context = nil)
-      children.map do |node|
-        item, new_context = @callbacks[node.class].call(node, context)
-        [
-          item,
-          ParseTreeVisitor.for(node, @callbacks).visit(new_context || context),
-        ]
-      end
-    end
-
-    protected
-
-    def children
-      @node.respond_to?(:nodelist) ? Array(@node.nodelist) : []
-    end
-  end
-end

lib/liquid/parser.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class Parser
     def initialize(input)
@@ -14,8 +12,9 @@ module Liquid
 
     def consume(type = nil)
       token = @tokens[@p]
-      raise SyntaxError, "Expected #{type} but found #{@tokens[@p].first}" if type && token[0] != type
+      if type && token[0] != type
-
+        raise SyntaxError, "Expected #{type} but found #{@tokens[@p].first}"
+      end
       @p += 1
       token[1]
     end
@@ -26,7 +25,6 @@ module Liquid
     def consume?(type)
       token = @tokens[@p]
       return false unless token && token[0] == type
-
       @p += 1
       token[1]
     end
@@ -36,7 +34,6 @@ module Liquid
       token = @tokens[@p]
       return false unless token && token[0] == :id
       return false unless token[1] == str
-
       @p += 1
       token[1]
     end
@@ -44,18 +41,14 @@ module Liquid
     def look(type, ahead = 0)
       tok = @tokens[@p + ahead]
       return false unless tok
-
       tok[0] == type
     end
 
-    SINGLE_TOKEN_EXPRESSION_TYPES = %i[string number].freeze
-    private_constant :SINGLE_TOKEN_EXPRESSION_TYPES
-
     def expression
       token = @tokens[@p]
       if token[0] == :id
         variable_signature
-      elsif SINGLE_TOKEN_EXPRESSION_TYPES.include?(token[0])
+      elsif [:string, :number].include? token[0]
         consume
       elsif token.first == :open_round
         consume
@@ -70,9 +63,11 @@ module Liquid
     end
 
     def argument
-      str = +''
+      str = ""
       # might be a keyword argument (identifier: expression)
-      str << consume << consume << ' ' if look(:id) && look(:colon, 1)
+      if look(:id) && look(:colon, 1)
+        str << consume << consume << ' '.freeze
+      end
 
       str << expression
       str

lib/liquid/parser_switching.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   module ParserSwitching
     def parse_with_selected_parser(markup)

lib/liquid/profiler.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'liquid/profiler/hooks'
 
 module Liquid
@@ -99,9 +97,9 @@ module Liquid
     end
 
     def initialize
-      @partial_stack = ['<root>']
+      @partial_stack = ["<root>"]
 
-      @root_timing = Timing.new('', current_partial)
+      @root_timing = Timing.new("", current_partial)
       @timing_stack = [@root_timing]
 
       @render_start_at = Time.now

lib/liquid/profiler/hooks.rb

@@ -1,10 +1,8 @@
-# frozen_string_literal: true
-
 module Liquid
   class BlockBody
-    def render_node_with_profiling(context, output, node)
+    def render_node_with_profiling(node, context)
       Profiler.profile_node_render(node) do
-        render_node_without_profiling(context, output, node)
+        render_node_without_profiling(node, context)
       end
     end
 
@@ -13,13 +11,13 @@ module Liquid
   end
 
   class Include < Tag
-    def render_to_output_buffer_with_profiling(context, output)
+    def render_with_profiling(context)
       Profiler.profile_children(context.evaluate(@template_name_expr).to_s) do
-        render_to_output_buffer_without_profiling(context, output)
+        render_without_profiling(context)
       end
     end
 
-    alias_method :render_to_output_buffer_without_profiling, :render_to_output_buffer
+    alias_method :render_without_profiling, :render
-    alias_method :render_to_output_buffer, :render_to_output_buffer_with_profiling
+    alias_method :render, :render_with_profiling
   end
 end

lib/liquid/range_lookup.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class RangeLookup
     def self.parse(start_markup, end_markup)

lib/liquid/resource_limits.rb

@@ -1,9 +1,7 @@
-# frozen_string_literal: true
-
 module Liquid
   class ResourceLimits
     attr_accessor :render_length, :render_score, :assign_score,
-                  :render_length_limit, :render_score_limit, :assign_score_limit
+      :render_length_limit, :render_score_limit, :assign_score_limit
 
     def initialize(limits)
       @render_length_limit = limits[:render_length_limit]

lib/liquid/standardfilters.rb

@@ -1,24 +1,16 @@
-# frozen_string_literal: true
-
 require 'cgi'
 require 'bigdecimal'
 
 module Liquid
   module StandardFilters
     HTML_ESCAPE = {
-      '&' => '&',
+      '&'.freeze => '&'.freeze,
-      '>' => '>',
+      '>'.freeze => '>'.freeze,
-      '<' => '&lt;',
+      '<'.freeze => '&lt;'.freeze,
-      '"' => '&quot;',
+      '"'.freeze => '&quot;'.freeze,
-      "'" => '&#39;',
+      "'".freeze => '&#39;'.freeze
-    }.freeze
+    }
-    HTML_ESCAPE_ONCE_REGEXP = /["><']|&(?!([a-zA-Z]+|(#\d+));)/.freeze
+    HTML_ESCAPE_ONCE_REGEXP = /["><']|&(?!([a-zA-Z]+|(#\d+));)/
-    STRIP_HTML_BLOCKS = Regexp.union(
-      %r{<script.*?</script>}m,
-      /<!--.*?-->/m,
-      %r{<style.*?</style>}m
-    )
-    STRIP_HTML_TAGS = /<.*?>/m.freeze
 
     # Return the size of an array or of an string
     def size(input)
@@ -54,12 +46,7 @@ module Liquid
     end
 
     def url_decode(input)
-      return if input.nil?
+      CGI.unescape(input.to_s) unless input.nil?
-
-      result = CGI.unescape(input.to_s)
-      raise Liquid::ArgumentError, "invalid byte sequence in #{result.encoding}" unless result.valid_encoding?
-
-      result
     end
 
     def slice(input, offset, length = nil)
@@ -74,25 +61,23 @@ module Liquid
     end
 
     # Truncate a string down to x characters
-    def truncate(input, length = 50, truncate_string = '...')
+    def truncate(input, length = 50, truncate_string = "...".freeze)
       return if input.nil?
-
       input_str = input.to_s
       length = Utils.to_integer(length)
       truncate_string_str = truncate_string.to_s
       l = length - truncate_string_str.length
       l = 0 if l < 0
-      input_str.length > length ? input_str[0...l].concat(truncate_string_str) : input_str
+      input_str.length > length ? input_str[0...l] + truncate_string_str : input_str
     end
 
-    def truncatewords(input, words = 15, truncate_string = '...')
+    def truncatewords(input, words = 15, truncate_string = "...".freeze)
       return if input.nil?
-
       wordlist = input.to_s.split
       words = Utils.to_integer(words)
       l = words - 1
       l = 0 if l < 0
-      wordlist.length > l ? wordlist[0..l].join(' ').concat(truncate_string.to_s) : input
+      wordlist.length > l ? wordlist[0..l].join(" ".freeze) + truncate_string.to_s : input
     end
 
     # Split input string into an array of substrings separated by given pattern.
@@ -117,19 +102,17 @@ module Liquid
     end
 
     def strip_html(input)
-      empty = ''
+      empty = ''.freeze
-      result = input.to_s.gsub(STRIP_HTML_BLOCKS, empty)
+      input.to_s.gsub(/<script.*?<\/script>/m, empty).gsub(/<!--.*?-->/m, empty).gsub(/<style.*?<\/style>/m, empty).gsub(/<.*?>/m, empty)
-      result.gsub!(STRIP_HTML_TAGS, empty)
-      result
     end
 
     # Remove all newlines from the string
     def strip_newlines(input)
-      input.to_s.gsub(/\r?\n/, '')
+      input.to_s.gsub(/\r?\n/, ''.freeze)
     end
 
     # Join elements of the array with certain character between them
-    def join(input, glue = ' ')
+    def join(input, glue = ' '.freeze)
       InputIterator.new(input).join(glue)
     end
 
@@ -137,18 +120,19 @@ module Liquid
     # provide optional property with which to sort an array of hashes or drops
     def sort(input, property = nil)
       ary = InputIterator.new(input)
-
-      return [] if ary.empty?
-
       if property.nil?
+        ary.sort
+      elsif ary.empty? # The next two cases assume a non-empty array.
+        []
+      elsif ary.first.respond_to?(:[]) && !ary.first[property].nil?
         ary.sort do |a, b|
-          nil_safe_compare(a, b)
+          a = a[property]
-        end
+          b = b[property]
-      elsif ary.all? { |el| el.respond_to?(:[]) }
+          if a && b
-        begin
+            a <=> b
-          ary.sort { |a, b| nil_safe_compare(a[property], b[property]) }
+          else
-        rescue TypeError
+            a ? -1 : 1
-          raise_property_error(property)
+          end
         end
       end
     end
@@ -158,40 +142,12 @@ module Liquid
     def sort_natural(input, property = nil)
       ary = InputIterator.new(input)
 
-      return [] if ary.empty?
-
       if property.nil?
-        ary.sort do |a, b|
+        ary.sort { |a, b| a.casecmp(b) }
-          nil_safe_casecmp(a, b)
+      elsif ary.empty? # The next two cases assume a non-empty array.
-        end
-      elsif ary.all? { |el| el.respond_to?(:[]) }
-        begin
-          ary.sort { |a, b| nil_safe_casecmp(a[property], b[property]) }
-        rescue TypeError
-          raise_property_error(property)
-        end
-      end
-    end
-
-    # Filter the elements of an array to those with a certain property value.
-    # By default the target is any truthy value.
-    def where(input, property, target_value = nil)
-      ary = InputIterator.new(input)
-
-      if ary.empty?
         []
-      elsif ary.first.respond_to?(:[]) && target_value.nil?
+      elsif ary.first.respond_to?(:[]) && !ary.first[property].nil?
-        begin
+        ary.sort { |a, b| a[property].casecmp(b[property]) }
-          ary.select { |item| item[property] }
-        rescue TypeError
-          raise_property_error(property)
-        end
-      elsif ary.first.respond_to?(:[])
-        begin
-          ary.select { |item| item[property] == target_value }
-        rescue TypeError
-          raise_property_error(property)
-        end
       end
     end
 
@@ -205,11 +161,7 @@ module Liquid
       elsif ary.empty? # The next two cases assume a non-empty array.
         []
       elsif ary.first.respond_to?(:[])
-        begin
+        ary.uniq{ |a| a[property] }
-          ary.uniq { |a| a[property] }
-        rescue TypeError
-          raise_property_error(property)
-        end
       end
     end
 
@@ -224,15 +176,13 @@ module Liquid
       InputIterator.new(input).map do |e|
         e = e.call if e.is_a?(Proc)
 
-        if property == 'to_liquid'
+        if property == "to_liquid".freeze
           e
         elsif e.respond_to?(:[])
           r = e[property]
           r.is_a?(Proc) ? r.call : r
         end
       end
-    rescue TypeError
-      raise_property_error(property)
     end
 
     # Remove nils within an array
@@ -245,32 +195,28 @@ module Liquid
       elsif ary.empty? # The next two cases assume a non-empty array.
         []
       elsif ary.first.respond_to?(:[])
-        begin
+        ary.reject{ |a| a[property].nil? }
-          ary.reject { |a| a[property].nil? }
-        rescue TypeError
-          raise_property_error(property)
-        end
       end
     end
 
     # Replace occurrences of a string with another
-    def replace(input, string, replacement = '')
+    def replace(input, string, replacement = ''.freeze)
       input.to_s.gsub(string.to_s, replacement.to_s)
     end
 
     # Replace the first occurrences of a string with another
-    def replace_first(input, string, replacement = '')
+    def replace_first(input, string, replacement = ''.freeze)
       input.to_s.sub(string.to_s, replacement.to_s)
     end
 
     # remove a substring
     def remove(input, string)
-      input.to_s.gsub(string.to_s, '')
+      input.to_s.gsub(string.to_s, ''.freeze)
     end
 
     # remove the first occurrences of a substring
     def remove_first(input, string)
-      input.to_s.sub(string.to_s, '')
+      input.to_s.sub(string.to_s, ''.freeze)
     end
 
     # add one string to another
@@ -279,8 +225,9 @@ module Liquid
     end
 
     def concat(input, array)
-      raise ArgumentError, 'concat filter requires an array argument' unless array.respond_to?(:to_ary)
+      unless array.respond_to?(:to_ary)
-
+        raise ArgumentError.new("concat filter requires an array argument")
+      end
       InputIterator.new(input).concat(array)
     end
 
@@ -291,7 +238,7 @@ module Liquid
 
     # Add <br /> tags in front of all newlines in input string
     def newline_to_br(input)
-      input.to_s.gsub(/\n/, "<br />\n")
+      input.to_s.gsub(/\n/, "<br />\n".freeze)
     end
 
     # Reformat a date using Ruby's core Time#strftime( string ) -> string
@@ -328,7 +275,7 @@ module Liquid
     def date(input, format)
       return input if format.to_s.empty?
 
-      return input unless (date = Utils.to_date(input))
+      return input unless date = Utils.to_date(input)
 
       date.strftime(format.to_s)
     end
@@ -406,23 +353,7 @@ module Liquid
       raise Liquid::FloatDomainError, e.message
     end
 
-    def at_least(input, n)
+    def default(input, default_value = ''.freeze)
-      min_value = Utils.to_number(n)
-
-      result = Utils.to_number(input)
-      result = min_value if min_value > result
-      result.is_a?(BigDecimal) ? result.to_f : result
-    end
-
-    def at_most(input, n)
-      max_value = Utils.to_number(n)
-
-      result = Utils.to_number(input)
-      result = max_value if max_value < result
-      result.is_a?(BigDecimal) ? result.to_f : result
-    end
-
-    def default(input, default_value = '')
       if !input || input.respond_to?(:empty?) && input.empty?
         default_value
       else
@@ -432,31 +363,11 @@ module Liquid
 
     private
 
-    def raise_property_error(property)
-      raise Liquid::ArgumentError, "cannot select the property '#{property}'"
-    end
-
     def apply_operation(input, operand, operation)
       result = Utils.to_number(input).send(operation, Utils.to_number(operand))
       result.is_a?(BigDecimal) ? result.to_f : result
     end
 
-    def nil_safe_compare(a, b)
-      if !a.nil? && !b.nil?
-        a <=> b
-      else
-        a.nil? ? 1 : -1
-      end
-    end
-
-    def nil_safe_casecmp(a, b)
-      if !a.nil? && !b.nil?
-        a.to_s.casecmp(b.to_s)
-      else
-        a.nil? ? 1 : -1
-      end
-    end
-
     class InputIterator
       include Enumerable
 

lib/liquid/strainer.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'set'
 
 module Liquid
@@ -9,12 +7,12 @@ module Liquid
   # The Strainer only allows method calls defined in filters given to it via Strainer.global_filter,
   # Context#add_filters or Template.register_filter
   class Strainer #:nodoc:
-    @global_strainer = Class.new(Strainer) do
+    @@global_strainer = Class.new(Strainer) do
       @filter_methods = Set.new
     end
-    @strainer_class_cache = Hash.new do |hash, filters|
+    @@strainer_class_cache = Hash.new do |hash, filters|
-      hash[filters] = Class.new(@global_strainer) do
+      hash[filters] = Class.new(@@global_strainer) do
-        @filter_methods = Strainer.global_strainer.filter_methods.dup
+        @filter_methods = @@global_strainer.filter_methods.dup
         filters.each { |f| add_filter(f) }
       end
     end
@@ -24,14 +22,12 @@ module Liquid
     end
 
     class << self
-      attr_accessor :strainer_class_cache, :global_strainer
       attr_reader :filter_methods
     end
 
     def self.add_filter(filter)
       raise ArgumentError, "Expected module but got: #{filter.class}" unless filter.is_a?(Module)
-
+      unless self.include?(filter)
-      unless include?(filter)
         invokable_non_public_methods = (filter.private_instance_methods + filter.protected_instance_methods).select { |m| invokable?(m) }
         if invokable_non_public_methods.any?
           raise MethodOverrideError, "Filter overrides registered public methods as non public: #{invokable_non_public_methods.join(', ')}"
@@ -43,8 +39,8 @@ module Liquid
     end
 
     def self.global_filter(filter)
-      @strainer_class_cache.clear
+      @@strainer_class_cache.clear
-      @global_strainer.add_filter(filter)
+      @@global_strainer.add_filter(filter)
     end
 
     def self.invokable?(method)
@@ -52,13 +48,13 @@ module Liquid
     end
 
     def self.create(context, filters = [])
-      @strainer_class_cache[filters].new(context)
+      @@strainer_class_cache[filters].new(context)
     end
 
     def invoke(method, *args)
       if self.class.invokable?(method)
         send(method, *args)
-      elsif @context&.strict_filters
+      elsif @context && @context.strict_filters
         raise Liquid::UndefinedFilter, "undefined filter #{method}"
       else
         args.first

lib/liquid/tablerowloop_drop.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class TablerowloopDrop < Drop
     def initialize(length, cols)

lib/liquid/tag.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class Tag
     attr_reader :nodelist, :tag_name, :line_number, :parse_context
@@ -23,7 +21,8 @@ module Liquid
       @line_number = parse_context.line_number
     end
 
-    def parse(_tokens); end
+    def parse(_tokens)
+    end
 
     def raw
       "#{@tag_name} #{@markup}"
@@ -34,15 +33,7 @@ module Liquid
     end
 
     def render(_context)
-      ''
+      ''.freeze
-    end
-
-    # For backwards compatibility with custom tags. In a future release, the semantics
-    # of the `render_to_output_buffer` method will become the default and the `render`
-    # method will be removed.
-    def render_to_output_buffer(context, output)
-      output << render(context)
-      output
     end
 
     def blank?

lib/liquid/tags/assign.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Assign sets a variable in your template.
   #
@@ -10,25 +8,23 @@ module Liquid
   #  {{ foo }}
   #
   class Assign < Tag
-    SYNTAX = /(#{VARIABLE_SIGNATURE}+)\s*=\s*(.*)\s*/om.freeze
+    Syntax = /(#{VariableSignature}+)\s*=\s*(.*)\s*/om
-
-    attr_reader :to, :from
 
     def initialize(tag_name, markup, options)
       super
-      if markup =~ SYNTAX
+      if markup =~ Syntax
-        @to = Regexp.last_match(1)
+        @to = $1
-        @from = Variable.new(Regexp.last_match(2), options)
+        @from = Variable.new($2, options)
       else
-        raise SyntaxError, options[:locale].t('errors.syntax.assign')
+        raise SyntaxError.new options[:locale].t("errors.syntax.assign".freeze)
       end
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
       val = @from.render(context)
       context.scopes.last[@to] = val
       context.resource_limits.assign_score += assign_score_of(val)
-      output
+      ''.freeze
     end
 
     def blank?
@@ -39,7 +35,7 @@ module Liquid
 
     def assign_score_of(val)
       if val.instance_of?(String)
-        val.bytesize
+        val.length
       elsif val.instance_of?(Array) || val.instance_of?(Hash)
         sum = 1
         # Uses #each to avoid extra allocations.
@@ -49,13 +45,7 @@ module Liquid
         1
       end
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        [@node.from]
-      end
-    end
   end
 
-  Template.register_tag('assign', Assign)
+  Template.register_tag('assign'.freeze, Assign)
 end

lib/liquid/tags/break.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Break tag to be used to break out of a for loop.
   #
@@ -16,5 +14,5 @@ module Liquid
     end
   end
 
-  Template.register_tag('break', Break)
+  Template.register_tag('break'.freeze, Break)
 end

lib/liquid/tags/capture.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Capture stores the result of a block into a variable without rendering it inplace.
   #
@@ -13,23 +11,22 @@ module Liquid
   # in a sidebar or footer.
   #
   class Capture < Block
-    SYNTAX = /(#{VARIABLE_SIGNATURE}+)/o.freeze
+    Syntax = /(#{VariableSignature}+)/o
 
     def initialize(tag_name, markup, options)
       super
-      if markup =~ SYNTAX
+      if markup =~ Syntax
-        @to = Regexp.last_match(1)
+        @to = $1
       else
-        raise SyntaxError, options[:locale].t('errors.syntax.capture')
+        raise SyntaxError.new(options[:locale].t("errors.syntax.capture"))
       end
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
-      previous_output_size = output.bytesize
+      output = super
-      super
       context.scopes.last[@to] = output
-      context.resource_limits.assign_score += (output.bytesize - previous_output_size)
+      context.resource_limits.assign_score += output.length
-      output
+      ''.freeze
     end
 
     def blank?
@@ -37,5 +34,5 @@ module Liquid
     end
   end
 
-  Template.register_tag('capture', Capture)
+  Template.register_tag('capture'.freeze, Capture)
 end

lib/liquid/tags/case.rb

@@ -1,26 +1,24 @@
-# frozen_string_literal: true
-
 module Liquid
   class Case < Block
-    SYNTAX = /(#{QUOTED_FRAGMENT})/o.freeze
+    Syntax     = /(#{QuotedFragment})/o
-    WHEN_SYNTAX = /(#{QUOTED_FRAGMENT})(?:(?:\s+or\s+|\s*\,\s*)(#{QUOTED_FRAGMENT}.*))?/om.freeze
+    WhenSyntax = /(#{QuotedFragment})(?:(?:\s+or\s+|\s*\,\s*)(#{QuotedFragment}.*))?/om
-
-    attr_reader :blocks, :left
 
     def initialize(tag_name, markup, options)
       super
       @blocks = []
 
-      if markup =~ SYNTAX
+      if markup =~ Syntax
-        @left = Expression.parse(Regexp.last_match(1))
+        @left = Expression.parse($1)
       else
-        raise SyntaxError, options[:locale].t('errors.syntax.case')
+        raise SyntaxError.new(options[:locale].t("errors.syntax.case".freeze))
       end
     end
 
     def parse(tokens)
       body = BlockBody.new
-      body = @blocks.last.attachment while parse_body(body, tokens)
+      while parse_body(body, tokens)
+        body = @blocks.last.attachment
+      end
     end
 
     def nodelist
@@ -29,30 +27,30 @@ module Liquid
 
     def unknown_tag(tag, markup, tokens)
       case tag
-      when 'when'
+      when 'when'.freeze
         record_when_condition(markup)
-      when 'else'
+      when 'else'.freeze
         record_else_condition(markup)
       else
         super
       end
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
       context.stack do
         execute_else_block = true
 
+        output = ''
         @blocks.each do |block|
           if block.else?
-            block.attachment.render_to_output_buffer(context, output) if execute_else_block
+            return block.attachment.render(context) if execute_else_block
           elsif block.evaluate(context)
             execute_else_block = false
-            block.attachment.render_to_output_buffer(context, output)
+            output << block.attachment.render(context)
           end
         end
+        output
       end
-
-      output
     end
 
     private
@@ -61,30 +59,28 @@ module Liquid
       body = BlockBody.new
 
       while markup
-        raise SyntaxError, options[:locale].t('errors.syntax.case_invalid_when') unless markup =~ WHEN_SYNTAX
+        unless markup =~ WhenSyntax
+          raise SyntaxError.new(options[:locale].t("errors.syntax.case_invalid_when".freeze))
+        end
 
-        markup = Regexp.last_match(2)
+        markup = $2
 
-        block = Condition.new(@left, '==', Expression.parse(Regexp.last_match(1)))
+        block = Condition.new(@left, '=='.freeze, Expression.parse($1))
         block.attach(body)
         @blocks << block
       end
     end
 
     def record_else_condition(markup)
-      raise SyntaxError, options[:locale].t('errors.syntax.case_invalid_else') unless markup.strip.empty?
+      unless markup.strip.empty?
+        raise SyntaxError.new(options[:locale].t("errors.syntax.case_invalid_else".freeze))
+      end
 
       block = ElseCondition.new
       block.attach(BlockBody.new)
       @blocks << block
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        [@node.left] + @node.blocks
-      end
-    end
   end
 
-  Template.register_tag('case', Case)
+  Template.register_tag('case'.freeze, Case)
 end

lib/liquid/tags/comment.rb

@@ -1,17 +1,16 @@
-# frozen_string_literal: true
-
 module Liquid
   class Comment < Block
-    def render_to_output_buffer(_context, output)
+    def render(_context)
-      output
+      ''.freeze
     end
 
-    def unknown_tag(_tag, _markup, _tokens); end
+    def unknown_tag(_tag, _markup, _tokens)
+    end
 
     def blank?
       true
     end
   end
 
-  Template.register_tag('comment', Comment)
+  Template.register_tag('comment'.freeze, Comment)
 end

lib/liquid/tags/continue.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Continue tag to be used to break out of a for loop.
   #
@@ -16,5 +14,5 @@ module Liquid
     end
   end
 
-  Template.register_tag('continue', Continue)
+  Template.register_tag('continue'.freeze, Continue)
 end

lib/liquid/tags/cycle.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Cycle is usually used within a loop to alternate between values, like colors or DOM classes.
   #
@@ -14,64 +12,45 @@ module Liquid
   #    <div class="green"> Item five</div>
   #
   class Cycle < Tag
-    SIMPLE_SYNTAX = /\A#{QUOTED_FRAGMENT}+/o.freeze
+    SimpleSyntax = /\A#{QuotedFragment}+/o
-    NAMED_SYNTAX  = /\A(#{QUOTED_FRAGMENT})\s*\:\s*(.*)/om.freeze
+    NamedSyntax  = /\A(#{QuotedFragment})\s*\:\s*(.*)/om
-
-    attr_reader :variables
 
     def initialize(tag_name, markup, options)
       super
       case markup
-      when NAMED_SYNTAX
+      when NamedSyntax
-        @variables = variables_from_string(Regexp.last_match(2))
+        @variables = variables_from_string($2)
-        @name = Expression.parse(Regexp.last_match(1))
+        @name = Expression.parse($1)
-      when SIMPLE_SYNTAX
+      when SimpleSyntax
         @variables = variables_from_string(markup)
         @name = @variables.to_s
       else
-        raise SyntaxError, options[:locale].t('errors.syntax.cycle')
+        raise SyntaxError.new(options[:locale].t("errors.syntax.cycle".freeze))
       end
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
-      context.registers[:cycle] ||= {}
+      context.registers[:cycle] ||= Hash.new(0)
 
       context.stack do
         key = context.evaluate(@name)
-        iteration = context.registers[:cycle][key].to_i
+        iteration = context.registers[:cycle][key]
-
+        result = context.evaluate(@variables[iteration])
-        val = context.evaluate(@variables[iteration])
-
-        if val.is_a?(Array)
-          val = val.join
-        elsif !val.is_a?(String)
-          val = val.to_s
-        end
-
-        output << val
-
         iteration += 1
         iteration  = 0 if iteration >= @variables.size
         context.registers[:cycle][key] = iteration
+        result
       end
-
-      output
     end
 
     private
 
     def variables_from_string(markup)
       markup.split(',').collect do |var|
-        var =~ /\s*(#{QUOTED_FRAGMENT})\s*/o
+        var =~ /\s*(#{QuotedFragment})\s*/o
-        Regexp.last_match(1) ? Expression.parse(Regexp.last_match(1)) : nil
+        $1 ? Expression.parse($1) : nil
       end.compact
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        Array(@node.variables)
-      end
-    end
   end
 
   Template.register_tag('cycle', Cycle)

lib/liquid/tags/decrement.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # decrement is used in a place where one needs to insert a counter
   #     into a template, and needs the counter to survive across
@@ -25,14 +23,13 @@ module Liquid
       @variable = markup.strip
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
       value = context.environments.first[@variable] ||= 0
       value -= 1
       context.environments.first[@variable] = value
-      output << value.to_s
+      value.to_s
-      output
     end
   end
 
-  Template.register_tag('decrement', Decrement)
+  Template.register_tag('decrement'.freeze, Decrement)
 end

lib/liquid/tags/for.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # "For" iterates over an array or collection.
   # Several useful variables are available to you within the loop.
@@ -46,9 +44,10 @@ module Liquid
   # forloop.parentloop:: Provides access to the parent loop, if present.
   #
   class For < Block
-    SYNTAX = /\A(#{VARIABLE_SEGMENT}+)\s+in\s+(#{QUOTED_FRAGMENT}+)\s*(reversed)?/o.freeze
+    Syntax = /\A(#{VariableSegment}+)\s+in\s+(#{QuotedFragment}+)\s*(reversed)?/o
 
-    attr_reader :collection_name, :variable_name, :limit, :from
+    attr_reader :collection_name
+    attr_reader :variable_name
 
     def initialize(tag_name, markup, options)
       super
@@ -60,7 +59,6 @@ module Liquid
 
     def parse(tokens)
       return unless parse_body(@for_block, tokens)
-
       parse_body(@else_block, tokens)
     end
 
@@ -69,55 +67,50 @@ module Liquid
     end
 
     def unknown_tag(tag, markup, tokens)
-      return super unless tag == 'else'
+      return super unless tag == 'else'.freeze
-
       @else_block = BlockBody.new
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
       segment = collection_segment(context)
 
       if segment.empty?
-        render_else(context, output)
+        render_else(context)
       else
-        render_segment(context, output, segment)
+        render_segment(context, segment)
       end
-
-      output
     end
 
     protected
 
     def lax_parse(markup)
-      if markup =~ SYNTAX
+      if markup =~ Syntax
-        @variable_name = Regexp.last_match(1)
+        @variable_name = $1
-        collection_name = Regexp.last_match(2)
+        collection_name = $2
-        @reversed = !!Regexp.last_match(3)
+        @reversed = !!$3
         @name = "#{@variable_name}-#{collection_name}"
         @collection_name = Expression.parse(collection_name)
-        markup.scan(TAG_ATTRIBUTES) do |key, value|
+        markup.scan(TagAttributes) do |key, value|
           set_attribute(key, value)
         end
       else
-        raise SyntaxError, options[:locale].t('errors.syntax.for')
+        raise SyntaxError.new(options[:locale].t("errors.syntax.for".freeze))
       end
     end
 
     def strict_parse(markup)
       p = Parser.new(markup)
       @variable_name = p.consume(:id)
-      raise SyntaxError, options[:locale].t('errors.syntax.for_invalid_in') unless p.id?('in')
+      raise SyntaxError.new(options[:locale].t("errors.syntax.for_invalid_in".freeze)) unless p.id?('in'.freeze)
-
       collection_name = p.expression
       @name = "#{@variable_name}-#{collection_name}"
       @collection_name = Expression.parse(collection_name)
-      @reversed = p.id?('reversed')
+      @reversed = p.id?('reversed'.freeze)
 
       while p.look(:id) && p.look(:colon, 1)
-        unless (attribute = p.id?('limit') || p.id?('offset'))
+        unless attribute = p.id?('limit'.freeze) || p.id?('offset'.freeze)
-          raise SyntaxError, options[:locale].t('errors.syntax.for_invalid_attribute')
+          raise SyntaxError.new(options[:locale].t("errors.syntax.for_invalid_attribute".freeze))
         end
-
         p.consume
         set_attribute(attribute, p.expression)
       end
@@ -127,28 +120,19 @@ module Liquid
     private
 
     def collection_segment(context)
-      offsets = context.registers[:for] ||= {}
+      offsets = context.registers[:for] ||= Hash.new(0)
 
       from = if @from == :continue
         offsets[@name].to_i
       else
-        from_value = context.evaluate(@from)
+        context.evaluate(@from).to_i
-        if from_value.nil?
-          0
-        else
-          Utils.to_integer(from_value)
-        end
       end
 
       collection = context.evaluate(@collection_name)
-      collection = collection.to_a if collection.is_a?(Range)
+      collection = collection.step(1).to_a if collection.is_a?(Range)
 
-      limit_value = context.evaluate(@limit)
+      limit = context.evaluate(@limit)
-      to = if limit_value.nil?
+      to = limit ? limit.to_i + from : nil
-        nil
-      else
-        Utils.to_integer(limit_value) + from
-      end
 
       segment = Utils.slice_collection(collection, from, to)
       segment.reverse! if @reversed
@@ -158,65 +142,57 @@ module Liquid
       segment
     end
 
-    def render_segment(context, output, segment)
+    def render_segment(context, segment)
       for_stack = context.registers[:for_stack] ||= []
       length = segment.length
 
+      result = ''
+
       context.stack do
         loop_vars = Liquid::ForloopDrop.new(@name, length, for_stack[-1])
 
         for_stack.push(loop_vars)
 
         begin
-          context['forloop'] = loop_vars
+          context['forloop'.freeze] = loop_vars
 
-          segment.each do |item|
+          segment.each_with_index do |item, index|
             context[@variable_name] = item
-            @for_block.render_to_output_buffer(context, output)
+            result << @for_block.render(context)
             loop_vars.send(:increment!)
 
             # Handle any interrupts if they exist.
-            next unless context.interrupt?
+            if context.interrupt?
-
+              interrupt = context.pop_interrupt
-            interrupt = context.pop_interrupt
+              break if interrupt.is_a? BreakInterrupt
-            break if interrupt.is_a?(BreakInterrupt)
+              next if interrupt.is_a? ContinueInterrupt
-            next if interrupt.is_a?(ContinueInterrupt)
+            end
           end
         ensure
           for_stack.pop
         end
       end
 
-      output
+      result
     end
 
     def set_attribute(key, expr)
       case key
-      when 'offset'
+      when 'offset'.freeze
-        @from = if expr == 'continue'
+        @from = if expr == 'continue'.freeze
           :continue
         else
           Expression.parse(expr)
         end
-      when 'limit'
+      when 'limit'.freeze
         @limit = Expression.parse(expr)
       end
     end
 
-    def render_else(context, output)
+    def render_else(context)
-      if @else_block
+      @else_block ? @else_block.render(context) : ''.freeze
-        @else_block.render_to_output_buffer(context, output)
-      else
-        output
-      end
-    end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        (super + [@node.limit, @node.from, @node.collection_name]).compact
-      end
     end
   end
 
-  Template.register_tag('for', For)
+  Template.register_tag('for'.freeze, For)
 end

lib/liquid/tags/if.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # If is the conditional block
   #
@@ -12,20 +10,14 @@ module Liquid
   #    There are {% if count < 5 %} less {% else %} more {% endif %} items than you need.
   #
   class If < Block
-    SYNTAX = /(#{QUOTED_FRAGMENT})\s*([=!<>a-z_]+)?\s*(#{QUOTED_FRAGMENT})?/o.freeze
+    Syntax = /(#{QuotedFragment})\s*([=!<>a-z_]+)?\s*(#{QuotedFragment})?/o
-    EXPRESSIONS_AND_OPERATORS = /(?:\b(?:\s?and\s?|\s?or\s?)\b|(?:\s*(?!\b(?:\s?and\s?|\s?or\s?)\b)(?:#{QUOTED_FRAGMENT}|\S+)\s*)+)/o.freeze
+    ExpressionsAndOperators = /(?:\b(?:\s?and\s?|\s?or\s?)\b|(?:\s*(?!\b(?:\s?and\s?|\s?or\s?)\b)(?:#{QuotedFragment}|\S+)\s*)+)/o
-    BOOLEAN_OPERATORS = %w[and or].freeze
+    BOOLEAN_OPERATORS = %w(and or)
-
-    attr_reader :blocks
 
     def initialize(tag_name, markup, options)
       super
       @blocks = []
-      push_block('if', markup)
+      push_block('if'.freeze, markup)
-    end
-
-    def nodelist
-      @blocks.map(&:attachment)
     end
 
     def parse(tokens)
@@ -33,28 +25,33 @@ module Liquid
       end
     end
 
+    def nodelist
+      @blocks.map(&:attachment)
+    end
+
     def unknown_tag(tag, markup, tokens)
-      if %w[elsif else].include?(tag)
+      if ['elsif'.freeze, 'else'.freeze].include?(tag)
         push_block(tag, markup)
       else
         super
       end
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
       context.stack do
         @blocks.each do |block|
-          return block.attachment.render_to_output_buffer(context, output) if block.evaluate(context)
+          if block.evaluate(context)
+            return block.attachment.render(context)
+          end
         end
+        ''.freeze
       end
-
-      output
     end
 
     private
 
     def push_block(tag, markup)
-      block = if tag == 'else'
+      block = if tag == 'else'.freeze
         ElseCondition.new
       else
         parse_with_selected_parser(markup)
@@ -65,19 +62,18 @@ module Liquid
     end
 
     def lax_parse(markup)
-      expressions = markup.scan(EXPRESSIONS_AND_OPERATORS)
+      expressions = markup.scan(ExpressionsAndOperators)
-      raise SyntaxError, options[:locale].t('errors.syntax.if') unless expressions.pop =~ SYNTAX
+      raise(SyntaxError.new(options[:locale].t("errors.syntax.if".freeze))) unless expressions.pop =~ Syntax
 
-      condition = Condition.new(Expression.parse(Regexp.last_match(1)), Regexp.last_match(2), Expression.parse(Regexp.last_match(3)))
+      condition = Condition.new(Expression.parse($1), $2, Expression.parse($3))
 
       until expressions.empty?
         operator = expressions.pop.to_s.strip
 
-        raise SyntaxError, options[:locale].t('errors.syntax.if') unless expressions.pop.to_s =~ SYNTAX
+        raise(SyntaxError.new(options[:locale].t("errors.syntax.if".freeze))) unless expressions.pop.to_s =~ Syntax
-
-        new_condition = Condition.new(Expression.parse(Regexp.last_match(1)), Regexp.last_match(2), Expression.parse(Regexp.last_match(3)))
-        raise SyntaxError, options[:locale].t('errors.syntax.if') unless BOOLEAN_OPERATORS.include?(operator)
 
+        new_condition = Condition.new(Expression.parse($1), $2, Expression.parse($3))
+        raise(SyntaxError.new(options[:locale].t("errors.syntax.if".freeze))) unless BOOLEAN_OPERATORS.include?(operator)
         new_condition.send(operator, condition)
         condition = new_condition
       end
@@ -95,7 +91,7 @@ module Liquid
     def parse_binary_comparisons(p)
       condition = parse_comparison(p)
       first_condition = condition
-      while (op = (p.id?('and') || p.id?('or')))
+      while op = (p.id?('and'.freeze) || p.id?('or'.freeze))
         child_condition = parse_comparison(p)
         condition.send(op, child_condition)
         condition = child_condition
@@ -105,20 +101,14 @@ module Liquid
 
     def parse_comparison(p)
       a = Expression.parse(p.expression)
-      if (op = p.consume?(:comparison))
+      if op = p.consume?(:comparison)
         b = Expression.parse(p.expression)
         Condition.new(a, op, b)
       else
         Condition.new(a)
       end
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        @node.blocks
-      end
-    end
   end
 
-  Template.register_tag('if', If)
+  Template.register_tag('if'.freeze, If)
 end

lib/liquid/tags/ifchanged.rb

@@ -1,21 +1,18 @@
-# frozen_string_literal: true
-
 module Liquid
   class Ifchanged < Block
-    def render_to_output_buffer(context, output)
+    def render(context)
       context.stack do
-        block_output = +''
+        output = super
-        super(context, block_output)
 
-        if block_output != context.registers[:ifchanged]
+        if output != context.registers[:ifchanged]
-          context.registers[:ifchanged] = block_output
+          context.registers[:ifchanged] = output
-          output << block_output
+          output
+        else
+          ''.freeze
         end
       end
-
-      output
     end
   end
 
-  Template.register_tag('ifchanged', Ifchanged)
+  Template.register_tag('ifchanged'.freeze, Ifchanged)
 end

lib/liquid/tags/include.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Include allows templates to relate with other templates
   #
@@ -16,39 +14,38 @@ module Liquid
   #   {% include 'product' for products %}
   #
   class Include < Tag
-    SYNTAX = /(#{QUOTED_FRAGMENT}+)(\s+(?:with|for)\s+(#{QUOTED_FRAGMENT}+))?/o.freeze
+    Syntax = /(#{QuotedFragment}+)(\s+(?:with|for)\s+(#{QuotedFragment}+))?/o
-
-    attr_reader :template_name_expr, :variable_name_expr, :attributes
 
     def initialize(tag_name, markup, options)
       super
 
-      if markup =~ SYNTAX
+      if markup =~ Syntax
 
-        template_name = Regexp.last_match(1)
+        template_name = $1
-        variable_name = Regexp.last_match(3)
+        variable_name = $3
 
         @variable_name_expr = variable_name ? Expression.parse(variable_name) : nil
         @template_name_expr = Expression.parse(template_name)
         @attributes = {}
 
-        markup.scan(TAG_ATTRIBUTES) do |key, value|
+        markup.scan(TagAttributes) do |key, value|
           @attributes[key] = Expression.parse(value)
         end
 
       else
-        raise SyntaxError, options[:locale].t('errors.syntax.include')
+        raise SyntaxError.new(options[:locale].t("errors.syntax.include".freeze))
       end
     end
 
-    def parse(_tokens); end
+    def parse(_tokens)
+    end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
       template_name = context.evaluate(@template_name_expr)
-      raise ArgumentError, options[:locale].t('errors.argument.include') unless template_name
+      raise ArgumentError.new(options[:locale].t("errors.argument.include")) unless template_name
 
       partial = load_cached_partial(template_name, context)
-      context_variable_name = template_name.split('/').last
+      context_variable_name = template_name.split('/'.freeze).last
 
       variable = if @variable_name_expr
         context.evaluate(@variable_name_expr)
@@ -67,21 +64,19 @@ module Liquid
           end
 
           if variable.is_a?(Array)
-            variable.each do |var|
+            variable.collect do |var|
               context[context_variable_name] = var
-              partial.render_to_output_buffer(context, output)
+              partial.render(context)
             end
           else
             context[context_variable_name] = variable
-            partial.render_to_output_buffer(context, output)
+            partial.render(context)
           end
         end
       ensure
         context.template_name = old_template_name
         context.partial = old_partial
       end
-
-      output
     end
 
     private
@@ -92,10 +87,9 @@ module Liquid
     def load_cached_partial(template_name, context)
       cached_partials = context.registers[:cached_partials] || {}
 
-      if (cached = cached_partials[template_name])
+      if cached = cached_partials[template_name]
         return cached
       end
-
       source = read_template_from_file_system(context)
       begin
         parse_context.partial = true
@@ -113,16 +107,7 @@ module Liquid
 
       file_system.read_template_file(context.evaluate(@template_name_expr))
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        [
-          @node.template_name_expr,
-          @node.variable_name_expr,
-        ] + @node.attributes.values
-      end
-    end
   end
 
-  Template.register_tag('include', Include)
+  Template.register_tag('include'.freeze, Include)
 end

lib/liquid/tags/increment.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # increment is used in a place where one needs to insert a counter
   #     into a template, and needs the counter to survive across
@@ -22,13 +20,12 @@ module Liquid
       @variable = markup.strip
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
       value = context.environments.first[@variable] ||= 0
       context.environments.first[@variable] = value + 1
-      output << value.to_s
+      value.to_s
-      output
     end
   end
 
-  Template.register_tag('increment', Increment)
+  Template.register_tag('increment'.freeze, Increment)
 end

lib/liquid/tags/raw.rb

@@ -1,9 +1,7 @@
-# frozen_string_literal: true
-
 module Liquid
   class Raw < Block
-    SYNTAX = /\A\s*\z/.freeze
+    Syntax = /\A\s*\z/
-    FULL_TOKEN_POSSIBLY_INVALID = /\A(.*)#{TAG_START}\s*(\w+)\s*(.*)?#{TAG_END}\z/om.freeze
+    FullTokenPossiblyInvalid = /\A(.*)#{TagStart}\s*(\w+)\s*(.*)?#{TagEnd}\z/om
 
     def initialize(tag_name, markup, parse_context)
       super
@@ -12,21 +10,20 @@ module Liquid
     end
 
     def parse(tokens)
-      @body = +''
+      @body = ''
-      while (token = tokens.shift)
+      while token = tokens.shift
-        if token =~ FULL_TOKEN_POSSIBLY_INVALID
+        if token =~ FullTokenPossiblyInvalid
-          @body << Regexp.last_match(1) if Regexp.last_match(1) != ''
+          @body << $1 if $1 != "".freeze
-          return if block_delimiter == Regexp.last_match(2)
+          return if block_delimiter == $2
         end
         @body << token unless token.empty?
       end
 
-      raise SyntaxError, parse_context.locale.t('errors.syntax.tag_never_closed', block_name: block_name)
+      raise SyntaxError.new(parse_context.locale.t("errors.syntax.tag_never_closed".freeze, block_name: block_name))
     end
 
-    def render_to_output_buffer(_context, output)
+    def render(_context)
-      output << @body
+      @body
-      output
     end
 
     def nodelist
@@ -40,9 +37,11 @@ module Liquid
     protected
 
     def ensure_valid_markup(tag_name, markup, parse_context)
-      raise SyntaxError, parse_context.locale.t('errors.syntax.tag_unexpected_args', tag: tag_name) unless markup =~ SYNTAX
+      unless markup =~ Syntax
+        raise SyntaxError.new(parse_context.locale.t("errors.syntax.tag_unexpected_args".freeze, tag: tag_name))
+      end
     end
   end
 
-  Template.register_tag('raw', Raw)
+  Template.register_tag('raw'.freeze, Raw)
 end

lib/liquid/tags/table_row.rb

@@ -1,65 +1,54 @@
-# frozen_string_literal: true
-
 module Liquid
   class TableRow < Block
-    SYNTAX = /(\w+)\s+in\s+(#{QUOTED_FRAGMENT}+)/o.freeze
+    Syntax = /(\w+)\s+in\s+(#{QuotedFragment}+)/o
-
-    attr_reader :variable_name, :collection_name, :attributes
 
     def initialize(tag_name, markup, options)
       super
-      if markup =~ SYNTAX
+      if markup =~ Syntax
-        @variable_name = Regexp.last_match(1)
+        @variable_name = $1
-        @collection_name = Expression.parse(Regexp.last_match(2))
+        @collection_name = Expression.parse($2)
         @attributes = {}
-        markup.scan(TAG_ATTRIBUTES) do |key, value|
+        markup.scan(TagAttributes) do |key, value|
           @attributes[key] = Expression.parse(value)
         end
       else
-        raise SyntaxError, options[:locale].t('errors.syntax.table_row')
+        raise SyntaxError.new(options[:locale].t("errors.syntax.table_row".freeze))
       end
     end
 
-    def render_to_output_buffer(context, output)
+    def render(context)
-      (collection = context.evaluate(@collection_name)) || (return '')
+      collection = context.evaluate(@collection_name) or return ''.freeze
 
-      from = @attributes.key?('offset') ? context.evaluate(@attributes['offset']).to_i : 0
+      from = @attributes.key?('offset'.freeze) ? context.evaluate(@attributes['offset'.freeze]).to_i : 0
-      to = @attributes.key?('limit') ? from + context.evaluate(@attributes['limit']).to_i : nil
+      to = @attributes.key?('limit'.freeze) ? from + context.evaluate(@attributes['limit'.freeze]).to_i : nil
 
       collection = Utils.slice_collection(collection, from, to)
 
       length = collection.length
 
-      cols = context.evaluate(@attributes['cols']).to_i
+      cols = context.evaluate(@attributes['cols'.freeze]).to_i
 
-      output << "<tr class=\"row1\">\n"
+      result = "<tr class=\"row1\">\n"
       context.stack do
         tablerowloop = Liquid::TablerowloopDrop.new(length, cols)
-        context['tablerowloop'] = tablerowloop
+        context['tablerowloop'.freeze] = tablerowloop
 
-        collection.each do |item|
+        collection.each_with_index do |item, index|
           context[@variable_name] = item
 
-          output << "<td class=\"col#{tablerowloop.col}\">"
+          result << "<td class=\"col#{tablerowloop.col}\">" << super << '</td>'
-          super
-          output << '</td>'
 
-          output << "</tr>\n<tr class=\"row#{tablerowloop.row + 1}\">" if tablerowloop.col_last && !tablerowloop.last
+          if tablerowloop.col_last && !tablerowloop.last
+            result << "</tr>\n<tr class=\"row#{tablerowloop.row + 1}\">"
+          end
 
           tablerowloop.send(:increment!)
         end
       end
-
+      result << "</tr>\n"
-      output << "</tr>\n"
+      result
-      output
-    end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        super + @node.attributes.values + [@node.collection_name]
-      end
     end
   end
 
-  Template.register_tag('tablerow', TableRow)
+  Template.register_tag('tablerow'.freeze, TableRow)
 end

lib/liquid/tags/unless.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require_relative 'if'
 
 module Liquid
@@ -8,21 +6,25 @@ module Liquid
   #   {% unless x < 0 %} x is greater than zero {% endunless %}
   #
   class Unless < If
-    def render_to_output_buffer(context, output)
+    def render(context)
       context.stack do
         # First condition is interpreted backwards ( if not )
         first_block = @blocks.first
-        return first_block.attachment.render_to_output_buffer(context, output) unless first_block.evaluate(context)
+        unless first_block.evaluate(context)
+          return first_block.attachment.render(context)
+        end
 
         # After the first condition unless works just like if
         @blocks[1..-1].each do |block|
-          return block.attachment.render_to_output_buffer(context, output) if block.evaluate(context)
+          if block.evaluate(context)
+            return block.attachment.render(context)
+          end
         end
-      end
 
-      output
+        ''.freeze
+      end
     end
   end
 
-  Template.register_tag('unless', Unless)
+  Template.register_tag('unless'.freeze, Unless)
 end

lib/liquid/template.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Templates are central to liquid.
   # Interpretating templates is a two step process. First you compile the
@@ -18,11 +16,7 @@ module Liquid
     attr_accessor :root
     attr_reader :resource_limits, :warnings
 
-    @file_system = BlankFileSystem.new
+    @@file_system = BlankFileSystem.new
-
-    class << self
-      attr_accessor :file_system
-    end
 
     class TagRegistry
       include Enumerable
@@ -56,7 +50,7 @@ module Liquid
       private
 
       def lookup_class(name)
-        Object.const_get(name)
+        name.split("::").reject(&:empty?).reduce(Object) { |scope, const| scope.const_get(const) }
       end
     end
 
@@ -80,6 +74,14 @@ module Liquid
         exception
       end
 
+      def file_system
+        @@file_system
+      end
+
+      def file_system=(obj)
+        @@file_system = obj
+      end
+
       def register_tag(name, klass)
         tags[name.to_s] = klass
       end
@@ -163,13 +165,15 @@ module Liquid
     #    filters and tags and might be useful to integrate liquid more with its host application
     #
     def render(*args)
-      return '' if @root.nil?
+      return ''.freeze if @root.nil?
 
       context = case args.first
       when Liquid::Context
         c = args.shift
 
-        c.exception_renderer = ->(_e) { raise } if @rethrow_errors
+        if @rethrow_errors
+          c.exception_renderer = ->(e) { raise }
+        end
 
         c
       when Liquid::Drop
@@ -180,15 +184,12 @@ module Liquid
       when nil
         Context.new(assigns, instance_assigns, registers, @rethrow_errors, @resource_limits)
       else
-        raise ArgumentError, 'Expected Hash or Liquid::Context as parameter'
+        raise ArgumentError, "Expected Hash or Liquid::Context as parameter"
       end
 
-      output = nil
-
       case args.last
       when Hash
         options = args.pop
-        output = options[:output] if options[:output]
 
         registers.merge!(options[:registers]) if options[:registers].is_a?(Hash)
 
@@ -203,9 +204,10 @@ module Liquid
       begin
         # render the nodelist.
         # for performance reasons we get an array back here. join will make a string out of it.
-        with_profiling(context) do
+        result = with_profiling(context) do
-          @root.render_to_output_buffer(context, output || +'')
+          @root.render(context)
         end
+        result.respond_to?(:join) ? result.join : result
       rescue Liquid::MemoryError => e
         context.handle_error(e)
       ensure
@@ -218,10 +220,6 @@ module Liquid
       render(*args)
     end
 
-    def render_to_output_buffer(context, output)
-      render(context, output: output)
-    end
-
     private
 
     def tokenize(source)

lib/liquid/tokenizer.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   class Tokenizer
     attr_reader :line_number
@@ -22,10 +20,10 @@ module Liquid
       @source = @source.source if @source.respond_to?(:source)
       return [] if @source.to_s.empty?
 
-      tokens = @source.split(TEMPLATE_PARSER)
+      tokens = @source.split(TemplateParser)
 
       # removes the rogue empty element at the beginning of the array
-      tokens.shift if tokens[0]&.empty?
+      tokens.shift if tokens[0] && tokens[0].empty?
 
       tokens
     end

lib/liquid/utils.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   module Utils
     def self.slice_collection(collection, from, to)
@@ -21,9 +19,13 @@ module Liquid
       return [] unless collection.respond_to?(:each)
 
       collection.each do |item|
-        break if to && to <= index
+        if to && to <= index
+          break
+        end
 
-        segments << item if from <= index
+        if from <= index
+          segments << item
+        end
 
         index += 1
       end
@@ -33,23 +35,22 @@ module Liquid
 
     def self.to_integer(num)
       return num if num.is_a?(Integer)
-
       num = num.to_s
       begin
         Integer(num)
       rescue ::ArgumentError
-        raise Liquid::ArgumentError, 'invalid integer'
+        raise Liquid::ArgumentError, "invalid integer"
       end
     end
 
     def self.to_number(obj)
       case obj
       when Float
-        BigDecimal(obj.to_s)
+        BigDecimal.new(obj.to_s)
       when Numeric
         obj
       when String
-        obj.strip =~ /\A-?\d+\.\d+\z/ ? BigDecimal(obj) : obj.to_i
+        (obj.strip =~ /\A-?\d+\.\d+\z/) ? BigDecimal.new(obj) : obj.to_i
       else
         if obj.respond_to?(:to_number)
           obj.to_number
@@ -64,12 +65,11 @@ module Liquid
 
       if obj.is_a?(String)
         return nil if obj.empty?
-
         obj = obj.downcase
       end
 
       case obj
-      when 'now', 'today'
+      when 'now'.freeze, 'today'.freeze
         Time.now
       when /\A\d+\z/, Integer
         Time.at(obj.to_i)

lib/liquid/variable.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module Liquid
   # Holds variables. Variables are only loaded "just in time"
   # and are not evaluated as part of the render stage
@@ -12,16 +10,10 @@ module Liquid
   #   {{ user | link }}
   #
   class Variable
-    FILTER_MARKUP_REGEX = /#{FILTER_SEPARATOR}\s*(.*)/om.freeze
+    FilterParser = /(?:\s+|#{QuotedFragment}|#{ArgumentSeparator})+/o
-    FILTER_PARSER = /(?:\s+|#{QUOTED_FRAGMENT}|#{ARGUMENT_SEPARATOR})+/o.freeze
-    FILTER_ARGS_REGEX = /(?:#{FILTER_ARGUMENT_SEPARATOR}|#{ARGUMENT_SEPARATOR})\s*((?:\w+\s*\:\s*)?#{QUOTED_FRAGMENT})/o.freeze
-    JUST_TAG_ATTRIBUTES = /\A#{TAG_ATTRIBUTES}\z/o.freeze
-    MARKUP_WITH_QUOTED_FRAGMENT = /(#{QUOTED_FRAGMENT})(.*)/om.freeze
-
     attr_accessor :filters, :name, :line_number
     attr_reader :parse_context
     alias_method :options, :parse_context
-
     include ParserSwitching
 
     def initialize(markup, parse_context)
@@ -43,18 +35,17 @@ module Liquid
 
     def lax_parse(markup)
       @filters = []
-      return unless markup =~ MARKUP_WITH_QUOTED_FRAGMENT
+      return unless markup =~ /(#{QuotedFragment})(.*)/om
 
-      name_markup = Regexp.last_match(1)
+      name_markup = $1
-      filter_markup = Regexp.last_match(2)
+      filter_markup = $2
       @name = Expression.parse(name_markup)
-      if filter_markup =~ FILTER_MARKUP_REGEX
+      if filter_markup =~ /#{FilterSeparator}\s*(.*)/om
-        filters = Regexp.last_match(1).scan(FILTER_PARSER)
+        filters = $1.scan(FilterParser)
         filters.each do |f|
           next unless f =~ /\w+/
-
           filtername = Regexp.last_match(0)
-          filterargs = f.scan(FILTER_ARGS_REGEX).flatten
+          filterargs = f.scan(/(?:#{FilterArgumentSeparator}|#{ArgumentSeparator})\s*((?:\w+\s*\:\s*)?#{QuotedFragment})/o).flatten
           @filters << parse_filter_expressions(filtername, filterargs)
         end
       end
@@ -88,43 +79,31 @@ module Liquid
       end
 
       obj = context.apply_global_filter(obj)
+
       taint_check(context, obj)
+
       obj
     end
 
-    def render_to_output_buffer(context, output)
-      obj = render(context)
-
-      if obj.is_a?(Array)
-        output << obj.join
-      elsif obj.nil?
-      else
-        output << obj.to_s
-      end
-
-      output
-    end
-
     private
 
     def parse_filter_expressions(filter_name, unparsed_args)
       filter_args = []
-      keyword_args = nil
+      keyword_args = {}
       unparsed_args.each do |a|
-        if (matches = a.match(JUST_TAG_ATTRIBUTES))
+        if matches = a.match(/\A#{TagAttributes}\z/o)
-          keyword_args ||= {}
           keyword_args[matches[1]] = Expression.parse(matches[2])
         else
           filter_args << Expression.parse(a)
         end
       end
       result = [filter_name, filter_args]
-      result << keyword_args if keyword_args
+      result << keyword_args unless keyword_args.empty?
       result
     end
 
     def evaluate_filter_expressions(context, filter_args, filter_kwargs)
-      parsed_args = filter_args.map { |expr| context.evaluate(expr) }
+      parsed_args = filter_args.map{ |expr| context.evaluate(expr) }
       if filter_kwargs
         parsed_kwargs = {}
         filter_kwargs.each do |key, expr|
@@ -139,7 +118,7 @@ module Liquid
       return unless obj.tainted?
       return if Template.taint_mode == :lax
 
-      @markup =~ QUOTED_FRAGMENT
+      @markup =~ QuotedFragment
       name = Regexp.last_match(0)
 
       error = TaintedError.new("variable '#{name}' is tainted and was not escaped")
@@ -153,11 +132,5 @@ module Liquid
         raise error
       end
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        [@node.name] + @node.filters.flatten
-      end
-    end
   end
 end

lib/liquid/variable_lookup.rb

@@ -1,9 +1,7 @@
-# frozen_string_literal: true
-
 module Liquid
   class VariableLookup
-    SQUARE_BRACKETED = /\A\[(.*)\]\z/m.freeze
+    SQUARE_BRACKETED = /\A\[(.*)\]\z/m
-    COMMAND_METHODS = %w[size first last].freeze
+    COMMAND_METHODS = ['size'.freeze, 'first'.freeze, 'last'.freeze]
 
     attr_reader :name, :lookups
 
@@ -12,10 +10,12 @@ module Liquid
     end
 
     def initialize(markup)
-      lookups = markup.scan(VARIABLE_PARSER)
+      lookups = markup.scan(VariableParser)
 
       name = lookups.shift
-      name = Expression.parse(Regexp.last_match(1)) if name =~ SQUARE_BRACKETED
+      if name =~ SQUARE_BRACKETED
+        name = Expression.parse($1)
+      end
       @name = name
 
       @lookups = lookups
@@ -24,7 +24,7 @@ module Liquid
       @lookups.each_index do |i|
         lookup = lookups[i]
         if lookup =~ SQUARE_BRACKETED
-          lookups[i] = Expression.parse(Regexp.last_match(1))
+          lookups[i] = Expression.parse($1)
         elsif COMMAND_METHODS.include?(lookup)
           @command_flags |= 1 << i
         end
@@ -41,8 +41,8 @@ module Liquid
         # If object is a hash- or array-like object we look for the
         # presence of the key and if its available we return it
         if object.respond_to?(:[]) &&
-           ((object.respond_to?(:key?) && object.key?(key)) ||
+            ((object.respond_to?(:key?) && object.key?(key)) ||
-            (object.respond_to?(:fetch) && key.is_a?(Integer)))
+             (object.respond_to?(:fetch) && key.is_a?(Integer)))
 
           # if its a proc we will replace the entry with the proc
           res = context.lookup_and_evaluate(object, key)
@@ -59,7 +59,6 @@ module Liquid
           # raise an exception if `strict_variables` option is set to true
         else
           return nil unless context.strict_variables
-
           raise Liquid::UndefinedVariable, "undefined variable #{key}"
         end
 
@@ -79,11 +78,5 @@ module Liquid
     def state
       [@name, @lookups, @command_flags]
     end
-
-    class ParseTreeVisitor < Liquid::ParseTreeVisitor
-      def children
-        @node.lookups
-      end
-    end
   end
 end

lib/liquid/version.rb

@@ -1,5 +1,4 @@
-# frozen_string_literal: true
+# encoding: utf-8
-
 module Liquid
-  VERSION = '4.0.3'
+  VERSION = "4.0.0"
 end

liquid.gemspec

@@ -1,31 +1,30 @@
-# frozen_string_literal: true
+# encoding: utf-8
+lib = File.expand_path('../lib/', __FILE__)
+$LOAD_PATH.unshift lib unless $LOAD_PATH.include?(lib)
 
-lib = File.expand_path('lib', __dir__)
+require "liquid/version"
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-
-require 'liquid/version'
 
 Gem::Specification.new do |s|
-  s.name        = 'liquid'
+  s.name        = "liquid"
   s.version     = Liquid::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.summary     = 'A secure, non-evaling end user template engine with aesthetic markup.'
+  s.summary     = "A secure, non-evaling end user template engine with aesthetic markup."
-  s.authors     = ['Tobias Lütke']
+  s.authors     = ["Tobias Lütke"]
-  s.email       = ['tobi@leetsoft.com']
+  s.email       = ["tobi@leetsoft.com"]
-  s.homepage    = 'http://www.liquidmarkup.org'
+  s.homepage    = "http://www.liquidmarkup.org"
-  s.license     = 'MIT'
+  s.license     = "MIT"
   # s.description = "A secure, non-evaling end user template engine with aesthetic markup."
 
-  s.required_ruby_version     = '>= 2.4.0'
+  s.required_ruby_version     = ">= 2.1.0"
-  s.required_rubygems_version = '>= 1.3.7'
+  s.required_rubygems_version = ">= 1.3.7"
 
-  s.test_files  = Dir.glob('{test}/**/*')
+  s.test_files  = Dir.glob("{test}/**/*")
-  s.files       = Dir.glob('{lib}/**/*') + %w[LICENSE README.md]
+  s.files       = Dir.glob("{lib}/**/*") + %w(LICENSE README.md)
 
-  s.extra_rdoc_files = ['History.md', 'README.md']
+  s.extra_rdoc_files = ["History.md", "README.md"]
 
-  s.require_path = 'lib'
+  s.require_path = "lib"
 
-  s.add_development_dependency('minitest')
+  s.add_development_dependency 'rake', '~> 11.3'
-  s.add_development_dependency('rake', '~> 11.3')
+  s.add_development_dependency 'minitest'
 end

performance/benchmark.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'benchmark/ips'
 require_relative 'theme_runner'
 
@@ -14,7 +12,7 @@ Benchmark.ips do |x|
   puts "Running benchmark for #{x.time} seconds (with #{x.warmup} seconds warmup)."
   puts
 
-  x.report('parse:') { profiler.compile }
+  x.report("parse:") { profiler.compile }
-  x.report('render:') { profiler.render }
+  x.report("render:") { profiler.render }
-  x.report('parse & render:') { profiler.run }
+  x.report("parse & render:") { profiler.run }
 end

performance/memory_profile.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-require 'benchmark/ips'
-require 'memory_profiler'
-require_relative 'theme_runner'
-
-def profile(phase, &block)
-  puts
-  puts "#{phase}:"
-  puts
-
-  report = MemoryProfiler.report(&block)
-
-  report.pretty_print(
-    color_output: true,
-    scale_bytes: true,
-    detailed_report: true
-  )
-end
-
-Liquid::Template.error_mode = ARGV.first.to_sym if ARGV.first
-
-profiler = ThemeRunner.new
-
-profile('Parsing') { profiler.compile }
-profile('Rendering') { profiler.render }

performance/profile.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'stackprof'
 require_relative 'theme_runner'
 
@@ -7,7 +5,7 @@ Liquid::Template.error_mode = ARGV.first.to_sym if ARGV.first
 profiler = ThemeRunner.new
 profiler.run
 
-%i[cpu object].each do |profile_type|
+[:cpu, :object].each do |profile_type|
   puts "Profiling in #{profile_type} mode..."
   results = StackProf.run(mode: profile_type) do
     200.times do
@@ -15,12 +13,12 @@ profiler.run
     end
   end
 
-  if profile_type == :cpu && (graph_filename = ENV['GRAPH_FILENAME'])
+  if profile_type == :cpu && graph_filename = ENV['GRAPH_FILENAME']
     File.open(graph_filename, 'w') do |f|
       StackProf::Report.new(results).print_graphviz(nil, f)
     end
   end
 
   StackProf::Report.new(results).print_text(false, 20)
-  File.write(ENV['FILENAME'] + '.' + profile_type.to_s, Marshal.dump(results)) if ENV['FILENAME']
+  File.write(ENV['FILENAME'] + "." + profile_type.to_s, Marshal.dump(results)) if ENV['FILENAME']
 end

performance/shopify/comment_form.rb

@@ -1,20 +1,18 @@
-# frozen_string_literal: true
-
 class CommentForm < Liquid::Block
-  SYNTAX = /(#{Liquid::VARIABLE_SIGNATURE}+)/.freeze
+  Syntax = /(#{Liquid::VariableSignature}+)/
 
   def initialize(tag_name, markup, options)
     super
 
-    if markup =~ SYNTAX
+    if markup =~ Syntax
-      @variable_name = Regexp.last_match(1)
+      @variable_name = $1
       @attributes = {}
     else
-      raise SyntaxError, "Syntax Error in 'comment_form' - Valid syntax: comment_form [article]"
+      raise SyntaxError.new("Syntax Error in 'comment_form' - Valid syntax: comment_form [article]")
     end
   end
 
-  def render_to_output_buffer(context, output)
+  def render(context)
     article = context[@variable_name]
 
     context.stack do
@@ -22,12 +20,10 @@ class CommentForm < Liquid::Block
         'posted_successfully?' => context.registers[:posted_successfully],
         'errors' => context['comment.errors'],
         'author' => context['comment.author'],
-        'email' => context['comment.email'],
+        'email'  => context['comment.email'],
-        'body' => context['comment.body'],
+        'body'   => context['comment.body']
       }
-
+      wrap_in_form(article, render_all(@nodelist, context))
-      output << wrap_in_form(article, render_all(@nodelist, context, output))
-      output
     end
   end
 

performance/shopify/database.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'yaml'
 
 module Database
@@ -18,11 +16,8 @@ module Database
       end
 
       # key the tables by handles, as this is how liquid expects it.
-      db = db.each_with_object({}) do |(key, values), assigns|
+      db = db.inject({}) do |assigns, (key, values)|
-        assigns[key] = values.each_with_object({}) do |v, h|
+        assigns[key] = values.inject({}) { |h, v| h[v['handle']] = v; h; }
-          h[v['handle']] = v
-          h
-        end
         assigns
       end
 
@@ -34,9 +29,9 @@ module Database
       db['article']    = db['blog']['articles'].first
 
       db['cart']       = {
-        'total_price' => db['line_items'].values.inject(0) { |sum, item| sum + item['line_price'] * item['quantity'] },
+        'total_price' => db['line_items'].values.inject(0) { |sum, item| sum += item['line_price'] * item['quantity'] },
-        'item_count' => db['line_items'].values.inject(0) { |sum, item| sum + item['quantity'] },
+        'item_count'  => db['line_items'].values.inject(0) { |sum, item| sum += item['quantity'] },
-        'items' => db['line_items'].values,
+        'items'       => db['line_items'].values
       }
 
       db
@@ -45,6 +40,6 @@ module Database
 end
 
 if __FILE__ == $PROGRAM_NAME
-  p(Database.tables['collections']['frontpage'].keys)
+  p Database.tables['collections']['frontpage'].keys
   # p Database.tables['blog']['articles']
 end

performance/shopify/json_filter.rb

@@ -1,9 +1,7 @@
-# frozen_string_literal: true
-
 require 'json'
 
 module JsonFilter
   def json(object)
-    JSON.dump(object.reject { |k, _v| k == 'collections' })
+    JSON.dump(object.reject { |k, v| k == "collections" })
   end
 end

performance/shopify/liquid.rb

@@ -1,6 +1,4 @@
-# frozen_string_literal: true
+$:.unshift __dir__ + '/../../lib'
-
-$LOAD_PATH.unshift(__dir__ + '/../../lib')
 require_relative '../../lib/liquid'
 
 require_relative 'comment_form'
@@ -11,11 +9,11 @@ require_relative 'shop_filter'
 require_relative 'tag_filter'
 require_relative 'weight_filter'
 
-Liquid::Template.register_tag('paginate', Paginate)
+Liquid::Template.register_tag 'paginate', Paginate
-Liquid::Template.register_tag('form', CommentForm)
+Liquid::Template.register_tag 'form', CommentForm
 
-Liquid::Template.register_filter(JsonFilter)
+Liquid::Template.register_filter JsonFilter
-Liquid::Template.register_filter(MoneyFilter)
+Liquid::Template.register_filter MoneyFilter
-Liquid::Template.register_filter(WeightFilter)
+Liquid::Template.register_filter WeightFilter
-Liquid::Template.register_filter(ShopFilter)
+Liquid::Template.register_filter ShopFilter
-Liquid::Template.register_filter(TagFilter)
+Liquid::Template.register_filter TagFilter

performance/shopify/money_filter.rb

@@ -1,16 +1,12 @@
-# frozen_string_literal: true
-
 module MoneyFilter
   def money_with_currency(money)
     return '' if money.nil?
-
+    sprintf("$ %.2f USD", money / 100.0)
-    format('$ %.2f USD', money / 100.0)
   end
 
   def money(money)
     return '' if money.nil?
-
+    sprintf("$ %.2f", money / 100.0)
-    format('$ %.2f', money / 100.0)
   end
 
   private

performance/shopify/paginate.rb

@@ -1,51 +1,49 @@
-# frozen_string_literal: true
-
 class Paginate < Liquid::Block
-  SYNTAX = /(#{Liquid::QUOTED_FRAGMENT})\s*(by\s*(\d+))?/.freeze
+  Syntax     = /(#{Liquid::QuotedFragment})\s*(by\s*(\d+))?/
 
   def initialize(tag_name, markup, options)
     super
 
-    if markup =~ SYNTAX
+    if markup =~ Syntax
-      @collection_name = Regexp.last_match(1)
+      @collection_name = $1
-      @page_size = if Regexp.last_match(2)
+      @page_size = if $2
-        Regexp.last_match(3).to_i
+        $3.to_i
       else
         20
       end
 
       @attributes = { 'window_size' => 3 }
-      markup.scan(Liquid::TAG_ATTRIBUTES) do |key, value|
+      markup.scan(Liquid::TagAttributes) do |key, value|
         @attributes[key] = value
       end
     else
-      raise SyntaxError, "Syntax Error in tag 'paginate' - Valid syntax: paginate [collection] by number"
+      raise SyntaxError.new("Syntax Error in tag 'paginate' - Valid syntax: paginate [collection] by number")
     end
   end
 
-  def render_to_output_buffer(context, output)
+  def render(context)
     @context = context
 
     context.stack do
-      current_page = context['current_page'].to_i
+      current_page  = context['current_page'].to_i
 
       pagination = {
-        'page_size' => @page_size,
+        'page_size'      => @page_size,
-        'current_page' => 5,
+        'current_page'   => 5,
-        'current_offset' => @page_size * 5,
+        'current_offset' => @page_size * 5
       }
 
       context['paginate'] = pagination
 
-      collection_size = context[@collection_name].size
+      collection_size  = context[@collection_name].size
 
-      raise ArgumentError, "Cannot paginate array '#{@collection_name}'. Not found." if collection_size.nil?
+      raise ArgumentError.new("Cannot paginate array '#{@collection_name}'. Not found.") if collection_size.nil?
 
       page_count = (collection_size.to_f / @page_size.to_f).to_f.ceil + 1
 
       pagination['items']      = collection_size
       pagination['pages']      = page_count - 1
-      pagination['previous']   = link('&laquo; Previous', current_page - 1)  unless current_page <= 1
+      pagination['previous']   = link('&laquo; Previous', current_page - 1)  unless 1 >= current_page
       pagination['next']       = link('Next &raquo;', current_page + 1)      unless page_count <= current_page + 1
       pagination['parts']      = []
 
@@ -61,7 +59,6 @@ class Paginate < Liquid::Block
             pagination['parts'] << link(page, page)
           elsif page <= current_page - @attributes['window_size'] || page >= current_page + @attributes['window_size']
             next if hellip_break
-
             pagination['parts'] << no_link('&hellip;')
             hellip_break = true
             next
@@ -88,6 +85,6 @@ class Paginate < Liquid::Block
   end
 
   def current_url
-    '/collections/frontpage'
+    "/collections/frontpage"
   end
 end

performance/shopify/shop_filter.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module ShopFilter
   def asset_url(input)
     "/files/1/[shop_id]/[shop_id]/assets/#{input}"
@@ -17,15 +15,15 @@ module ShopFilter
     %(<script src="#{url}" type="text/javascript"></script>)
   end
 
-  def stylesheet_tag(url, media = 'all')
+  def stylesheet_tag(url, media = "all")
     %(<link href="#{url}" rel="stylesheet" type="text/css"  media="#{media}"  />)
   end
 
-  def link_to(link, url, title = '')
+  def link_to(link, url, title = "")
     %(<a href="#{url}" title="#{title}">#{link}</a>)
   end
 
-  def img_tag(url, alt = '')
+  def img_tag(url, alt = "")
     %(<img src="#{url}" alt="#{alt}" />)
   end
 
@@ -54,13 +52,15 @@ module ShopFilter
   end
 
   def product_img_url(url, style = 'small')
-    raise ArgumentError, 'filter "size" can only be called on product images' unless url =~ %r{\Aproducts/([\w\-\_]+)\.(\w{2,4})}
+    unless url =~ /\Aproducts\/([\w\-\_]+)\.(\w{2,4})/
+      raise ArgumentError, 'filter "size" can only be called on product images'
+    end
 
     case style
     when 'original'
       return '/files/shops/random_number/' + url
     when 'grande', 'large', 'medium', 'compact', 'small', 'thumb', 'icon'
-      "/files/shops/random_number/products/#{Regexp.last_match(1)}_#{style}.#{Regexp.last_match(2)}"
+      "/files/shops/random_number/products/#{$1}_#{style}.#{$2}"
     else
       raise ArgumentError, 'valid parameters for filter "size" are: original, grande, large, medium, compact, small, thumb and icon '
     end
@@ -70,14 +70,16 @@ module ShopFilter
     html = []
     html << %(<span class="prev">#{link_to(paginate['previous']['title'], paginate['previous']['url'])}</span>) if paginate['previous']
 
-    paginate['parts'].each do |part|
+    for part in paginate['parts']
-      html << if part['is_link']
+
-        %(<span class="page">#{link_to(part['title'], part['url'])}</span>)
+      if part['is_link']
+        html << %(<span class="page">#{link_to(part['title'], part['url'])}</span>)
       elsif part['title'].to_i == paginate['current_page'].to_i
-        %(<span class="page current">#{part['title']}</span>)
+        html << %(<span class="page current">#{part['title']}</span>)
       else
-        %(<span class="deco">#{part['title']}</span>)
+        html << %(<span class="deco">#{part['title']}</span>)
       end
+
     end
 
     html << %(<span class="next">#{link_to(paginate['next']['title'], paginate['next']['url'])}</span>) if paginate['next']

performance/shopify/tag_filter.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 module TagFilter
   def link_to_tag(label, tag)
     "<a title=\"Show tag #{tag}\" href=\"/collections/#{@context['handle']}/#{tag}\">#{label}</a>"
@@ -15,11 +13,11 @@ module TagFilter
 
   def link_to_add_tag(label, tag)
     tags = (@context['current_tags'] + [tag]).uniq
-    "<a title=\"Show tag #{tag}\" href=\"/collections/#{@context['handle']}/#{tags.join('+')}\">#{label}</a>"
+    "<a title=\"Show tag #{tag}\" href=\"/collections/#{@context['handle']}/#{tags.join("+")}\">#{label}</a>"
   end
 
   def link_to_remove_tag(label, tag)
     tags = (@context['current_tags'] - [tag]).uniq
-    "<a title=\"Show tag #{tag}\" href=\"/collections/#{@context['handle']}/#{tags.join('+')}\">#{label}</a>"
+    "<a title=\"Show tag #{tag}\" href=\"/collections/#{@context['handle']}/#{tags.join("+")}\">#{label}</a>"
   end
 end

performance/shopify/weight_filter.rb

@@ -1,8 +1,6 @@
-# frozen_string_literal: true
-
 module WeightFilter
   def weight(grams)
-    format('%.2f', grams / 1000)
+    sprintf("%.2f", grams / 1000)
   end
 
   def weight_with_unit(grams)

performance/theme_runner.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 # This profiler run simulates Shopify.
 # We are looking in the tests directory for liquid files and render them within the designated layout file.
 # We will also export a substantial database to liquid which the templates can render values of.
@@ -33,7 +31,7 @@ class ThemeRunner
       {
         liquid: File.read(test),
         layout: (File.file?(theme_path) ? File.read(theme_path) : nil),
-        template_name: test,
+        template_name: test
       }
     end.compact
 

test/integration/assign_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class AssignTest < Minitest::Test
@@ -12,29 +10,29 @@ class AssignTest < Minitest::Test
     END_TEMPLATE
     template = Template.parse(template_source)
     rendered = template.render!
-    assert_equal 'Print this-thing', rendered.strip
+    assert_equal "Print this-thing", rendered.strip
   end
 
   def test_assigned_variable
     assert_template_result('.foo.',
-                           '{% assign foo = values %}.{{ foo[0] }}.',
+      '{% assign foo = values %}.{{ foo[0] }}.',
-                           'values' => %w[foo bar baz])
+      'values' => %w(foo bar baz))
 
     assert_template_result('.bar.',
-                           '{% assign foo = values %}.{{ foo[1] }}.',
+      '{% assign foo = values %}.{{ foo[1] }}.',
-                           'values' => %w[foo bar baz])
+      'values' => %w(foo bar baz))
   end
 
   def test_assign_with_filter
     assert_template_result('.bar.',
-                           '{% assign foo = values | split: "," %}.{{ foo[1] }}.',
+      '{% assign foo = values | split: "," %}.{{ foo[1] }}.',
-                           'values' => 'foo,bar,baz')
+      'values' => "foo,bar,baz")
   end
 
   def test_assign_syntax_error
     assert_match_syntax_error(/assign/,
-                              '{% assign foo not values %}.',
+      '{% assign foo not values %}.',
-                              'values' => 'foo,bar,baz')
+      'values' => "foo,bar,baz")
   end
 
   def test_assign_uses_error_mode

test/integration/blank_test.rb

@@ -1,12 +1,11 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class FoobarTag < Liquid::Tag
-  def render_to_output_buffer(_context, output)
+  def render(*args)
-    output << ' '
+    " "
-    output
   end
+
+  Liquid::Template.register_tag('foobar', FoobarTag)
 end
 
 class BlankTestFileSystem
@@ -32,78 +31,76 @@ class BlankTest < Minitest::Test
   end
 
   def test_new_tags_are_not_blank_by_default
-    with_custom_tag('foobar', FoobarTag) do
+    assert_template_result(" " * N, wrap_in_for("{% foobar %}"))
-      assert_template_result(' ' * N, wrap_in_for('{% foobar %}'))
-    end
   end
 
   def test_loops_are_blank
-    assert_template_result('', wrap_in_for(' '))
+    assert_template_result("", wrap_in_for(" "))
   end
 
   def test_if_else_are_blank
-    assert_template_result('', '{% if true %} {% elsif false %} {% else %} {% endif %}')
+    assert_template_result("", "{% if true %} {% elsif false %} {% else %} {% endif %}")
   end
 
   def test_unless_is_blank
-    assert_template_result('', wrap('{% unless true %} {% endunless %}'))
+    assert_template_result("", wrap("{% unless true %} {% endunless %}"))
   end
 
   def test_mark_as_blank_only_during_parsing
-    assert_template_result(' ' * (N + 1), wrap(' {% if false %} this never happens, but still, this block is not blank {% endif %}'))
+    assert_template_result(" " * (N + 1), wrap(" {% if false %} this never happens, but still, this block is not blank {% endif %}"))
   end
 
   def test_comments_are_blank
-    assert_template_result('', wrap(' {% comment %} whatever {% endcomment %} '))
+    assert_template_result("", wrap(" {% comment %} whatever {% endcomment %} "))
   end
 
   def test_captures_are_blank
-    assert_template_result('', wrap(' {% capture foo %} whatever {% endcapture %} '))
+    assert_template_result("", wrap(" {% capture foo %} whatever {% endcapture %} "))
   end
 
   def test_nested_blocks_are_blank_but_only_if_all_children_are
-    assert_template_result('', wrap(wrap(' ')))
+    assert_template_result("", wrap(wrap(" ")))
     assert_template_result("\n       but this is not " * (N + 1),
-                           wrap('{% if true %} {% comment %} this is blank {% endcomment %} {% endif %}
+      wrap('{% if true %} {% comment %} this is blank {% endcomment %} {% endif %}
       {% if true %} but this is not {% endif %}'))
   end
 
   def test_assigns_are_blank
-    assert_template_result('', wrap(' {% assign foo = "bar" %} '))
+    assert_template_result("", wrap(' {% assign foo = "bar" %} '))
   end
 
   def test_whitespace_is_blank
-    assert_template_result('', wrap(' '))
+    assert_template_result("", wrap(" "))
-    assert_template_result('', wrap("\t"))
+    assert_template_result("", wrap("\t"))
   end
 
   def test_whitespace_is_not_blank_if_other_stuff_is_present
-    body = '     x '
+    body = "     x "
     assert_template_result(body * (N + 1), wrap(body))
   end
 
   def test_increment_is_not_blank
-    assert_template_result(' 0' * 2 * (N + 1), wrap('{% assign foo = 0 %} {% increment foo %} {% decrement foo %}'))
+    assert_template_result(" 0" * 2 * (N + 1), wrap("{% assign foo = 0 %} {% increment foo %} {% decrement foo %}"))
   end
 
   def test_cycle_is_not_blank
-    assert_template_result('  ' * ((N + 1) / 2) + ' ', wrap("{% cycle ' ', ' ' %}"))
+    assert_template_result("  " * ((N + 1) / 2) + " ", wrap("{% cycle ' ', ' ' %}"))
   end
 
   def test_raw_is_not_blank
-    assert_template_result('  ' * (N + 1), wrap(' {% raw %} {% endraw %}'))
+    assert_template_result("  " * (N + 1), wrap(" {% raw %} {% endraw %}"))
   end
 
   def test_include_is_blank
     Liquid::Template.file_system = BlankTestFileSystem.new
-    assert_template_result 'foobar' * (N + 1), wrap("{% include 'foobar' %}")
+    assert_template_result "foobar" * (N + 1), wrap("{% include 'foobar' %}")
-    assert_template_result ' foobar ' * (N + 1), wrap("{% include ' foobar ' %}")
+    assert_template_result " foobar " * (N + 1), wrap("{% include ' foobar ' %}")
-    assert_template_result '   ' * (N + 1), wrap(" {% include ' ' %} ")
+    assert_template_result "   " * (N + 1), wrap(" {% include ' ' %} ")
   end
 
   def test_case_is_blank
-    assert_template_result('', wrap(" {% assign foo = 'bar' %} {% case foo %} {% when 'bar' %} {% when 'whatever' %} {% else %} {% endcase %} "))
+    assert_template_result("", wrap(" {% assign foo = 'bar' %} {% case foo %} {% when 'bar' %} {% when 'whatever' %} {% else %} {% endcase %} "))
-    assert_template_result('', wrap(" {% assign foo = 'else' %} {% case foo %} {% when 'bar' %} {% when 'whatever' %} {% else %} {% endcase %} "))
+    assert_template_result("", wrap(" {% assign foo = 'else' %} {% case foo %} {% when 'bar' %} {% when 'whatever' %} {% else %} {% endcase %} "))
-    assert_template_result('   x  ' * (N + 1), wrap(" {% assign foo = 'else' %} {% case foo %} {% when 'bar' %} {% when 'whatever' %} {% else %} x {% endcase %} "))
+    assert_template_result("   x  " * (N + 1), wrap(" {% assign foo = 'else' %} {% case foo %} {% when 'bar' %} {% when 'whatever' %} {% else %} x {% endcase %} "))
   end
 end

test/integration/block_test.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-
-class BlockTest < Minitest::Test
-  include Liquid
-
-  def test_unexpected_end_tag
-    exc = assert_raises(SyntaxError) do
-      Template.parse('{% if true %}{% endunless %}')
-    end
-    assert_equal exc.message, "Liquid syntax error: 'endunless' is not a valid delimiter for if tags. use endif"
-  end
-end

test/integration/capture_test.rb

@@ -1,12 +1,10 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class CaptureTest < Minitest::Test
   include Liquid
 
   def test_captures_block_content_in_variable
-    assert_template_result('test string', "{% capture 'var' %}test string{% endcapture %}{{var}}", {})
+    assert_template_result("test string", "{% capture 'var' %}test string{% endcapture %}{{var}}", {})
   end
 
   def test_capture_with_hyphen_in_variable_name
@@ -16,7 +14,7 @@ class CaptureTest < Minitest::Test
     END_TEMPLATE
     template = Template.parse(template_source)
     rendered = template.render!
-    assert_equal 'Print this-thing', rendered.strip
+    assert_equal "Print this-thing", rendered.strip
   end
 
   def test_capture_to_variable_from_outer_scope_if_existing
@@ -32,7 +30,7 @@ class CaptureTest < Minitest::Test
     END_TEMPLATE
     template = Template.parse(template_source)
     rendered = template.render!
-    assert_equal 'test-string', rendered.gsub(/\s/, '')
+    assert_equal "test-string", rendered.gsub(/\s/, '')
   end
 
   def test_assigning_from_capture
@@ -47,6 +45,6 @@ class CaptureTest < Minitest::Test
     END_TEMPLATE
     template = Template.parse(template_source)
     rendered = template.render!
-    assert_equal '3-3', rendered.gsub(/\s/, '')
+    assert_equal "3-3", rendered.gsub(/\s/, '')
   end
 end # CaptureTest

test/integration/context_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class ContextTest < Minitest::Test

test/integration/document_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class DocumentTest < Minitest::Test
@@ -7,14 +5,14 @@ class DocumentTest < Minitest::Test
 
   def test_unexpected_outer_tag
     exc = assert_raises(SyntaxError) do
-      Template.parse('{% else %}')
+      Template.parse("{% else %}")
     end
     assert_equal exc.message, "Liquid syntax error: Unexpected outer 'else' tag"
   end
 
   def test_unknown_tag
     exc = assert_raises(SyntaxError) do
-      Template.parse('{% foo %}')
+      Template.parse("{% foo %}")
     end
     assert_equal exc.message, "Liquid syntax error: Unknown tag 'foo'"
   end

test/integration/drop_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class ContextDrop < Liquid::Drop
@@ -23,7 +21,7 @@ end
 class ProductDrop < Liquid::Drop
   class TextDrop < Liquid::Drop
     def array
-      %w[text1 text2]
+      ['text1', 'text2']
     end
 
     def text
@@ -33,7 +31,7 @@ class ProductDrop < Liquid::Drop
 
   class CatchallDrop < Liquid::Drop
     def liquid_method_missing(method)
-      +'catchall_method: ' << method.to_s
+      'catchall_method: ' << method.to_s
     end
   end
 
@@ -50,13 +48,13 @@ class ProductDrop < Liquid::Drop
   end
 
   def user_input
-    (+'foo').taint
+    "foo".taint
   end
 
   protected
 
   def callmenot
-    'protected'
+    "protected"
   end
 end
 
@@ -141,17 +139,17 @@ class DropsTest < Minitest::Test
   end
 
   def test_drop_does_only_respond_to_whitelisted_methods
-    assert_equal '', Liquid::Template.parse('{{ product.inspect }}').render!('product' => ProductDrop.new)
+    assert_equal "", Liquid::Template.parse("{{ product.inspect }}").render!('product' => ProductDrop.new)
-    assert_equal '', Liquid::Template.parse('{{ product.pretty_inspect }}').render!('product' => ProductDrop.new)
+    assert_equal "", Liquid::Template.parse("{{ product.pretty_inspect }}").render!('product' => ProductDrop.new)
-    assert_equal '', Liquid::Template.parse('{{ product.whatever }}').render!('product' => ProductDrop.new)
+    assert_equal "", Liquid::Template.parse("{{ product.whatever }}").render!('product' => ProductDrop.new)
-    assert_equal '', Liquid::Template.parse('{{ product | map: "inspect" }}').render!('product' => ProductDrop.new)
+    assert_equal "", Liquid::Template.parse('{{ product | map: "inspect" }}').render!('product' => ProductDrop.new)
-    assert_equal '', Liquid::Template.parse('{{ product | map: "pretty_inspect" }}').render!('product' => ProductDrop.new)
+    assert_equal "", Liquid::Template.parse('{{ product | map: "pretty_inspect" }}').render!('product' => ProductDrop.new)
-    assert_equal '', Liquid::Template.parse('{{ product | map: "whatever" }}').render!('product' => ProductDrop.new)
+    assert_equal "", Liquid::Template.parse('{{ product | map: "whatever" }}').render!('product' => ProductDrop.new)
   end
 
   def test_drops_respond_to_to_liquid
-    assert_equal 'text1', Liquid::Template.parse('{{ product.to_liquid.texts.text }}').render!('product' => ProductDrop.new)
+    assert_equal "text1", Liquid::Template.parse("{{ product.to_liquid.texts.text }}").render!('product' => ProductDrop.new)
-    assert_equal 'text1', Liquid::Template.parse('{{ product | map: "to_liquid" | map: "texts" | map: "text" }}').render!('product' => ProductDrop.new)
+    assert_equal "text1", Liquid::Template.parse('{{ product | map: "to_liquid" | map: "texts" | map: "text" }}').render!('product' => ProductDrop.new)
   end
 
   def test_text_drop
@@ -175,12 +173,12 @@ class DropsTest < Minitest::Test
   end
 
   def test_context_drop
-    output = Liquid::Template.parse(' {{ context.bar }} ').render!('context' => ContextDrop.new, 'bar' => 'carrot')
+    output = Liquid::Template.parse(' {{ context.bar }} ').render!('context' => ContextDrop.new, 'bar' => "carrot")
     assert_equal ' carrot ', output
   end
 
   def test_nested_context_drop
-    output = Liquid::Template.parse(' {{ product.context.foo }} ').render!('product' => ProductDrop.new, 'foo' => 'monkey')
+    output = Liquid::Template.parse(' {{ product.context.foo }} ').render!('product' => ProductDrop.new, 'foo' => "monkey")
     assert_equal ' monkey ', output
   end
 
@@ -190,7 +188,7 @@ class DropsTest < Minitest::Test
   end
 
   def test_object_methods_not_allowed
-    %i[dup clone singleton_class eval class_eval inspect].each do |method|
+    [:dup, :clone, :singleton_class, :eval, :class_eval, :inspect].each do |method|
       output = Liquid::Template.parse(" {{ product.#{method} }} ").render!('product' => ProductDrop.new)
       assert_equal '  ', output
     end
@@ -203,9 +201,9 @@ class DropsTest < Minitest::Test
   end
 
   def test_scope_though_proc
-    assert_equal '1', Liquid::Template.parse('{{ s }}').render!('context' => ContextDrop.new, 's' => proc { |c| c['context.scopes'] })
+    assert_equal '1', Liquid::Template.parse('{{ s }}').render!('context' => ContextDrop.new, 's' => proc{ |c| c['context.scopes'] })
-    assert_equal '2', Liquid::Template.parse('{%for i in dummy%}{{ s }}{%endfor%}').render!('context' => ContextDrop.new, 's' => proc { |c| c['context.scopes'] }, 'dummy' => [1])
+    assert_equal '2', Liquid::Template.parse('{%for i in dummy%}{{ s }}{%endfor%}').render!('context' => ContextDrop.new, 's' => proc{ |c| c['context.scopes'] }, 'dummy' => [1])
-    assert_equal '3', Liquid::Template.parse('{%for i in dummy%}{%for i in dummy%}{{ s }}{%endfor%}{%endfor%}').render!('context' => ContextDrop.new, 's' => proc { |c| c['context.scopes'] }, 'dummy' => [1])
+    assert_equal '3', Liquid::Template.parse('{%for i in dummy%}{%for i in dummy%}{{ s }}{%endfor%}{%endfor%}').render!('context' => ContextDrop.new, 's' => proc{ |c| c['context.scopes'] }, 'dummy' => [1])
   end
 
   def test_scope_with_assigns
@@ -234,7 +232,7 @@ class DropsTest < Minitest::Test
   end
 
   def test_enumerable_drop_will_invoke_liquid_method_missing_for_clashing_method_names
-    %w[select each map cycle].each do |method|
+    ["select", "each", "map", "cycle"].each do |method|
       assert_equal method.to_s, Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => EnumerableDrop.new)
       assert_equal method.to_s, Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => EnumerableDrop.new)
       assert_equal method.to_s, Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => RealEnumerableDrop.new)
@@ -243,20 +241,20 @@ class DropsTest < Minitest::Test
   end
 
   def test_some_enumerable_methods_still_get_invoked
-    %i[count max].each do |method|
+    [ :count, :max ].each do |method|
-      assert_equal '3', Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => RealEnumerableDrop.new)
+      assert_equal "3", Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => RealEnumerableDrop.new)
-      assert_equal '3', Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => RealEnumerableDrop.new)
+      assert_equal "3", Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => RealEnumerableDrop.new)
-      assert_equal '3', Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => EnumerableDrop.new)
+      assert_equal "3", Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => EnumerableDrop.new)
-      assert_equal '3', Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => EnumerableDrop.new)
+      assert_equal "3", Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => EnumerableDrop.new)
     end
 
-    assert_equal 'yes', Liquid::Template.parse('{% if collection contains 3 %}yes{% endif %}').render!('collection' => RealEnumerableDrop.new)
+    assert_equal "yes", Liquid::Template.parse("{% if collection contains 3 %}yes{% endif %}").render!('collection' => RealEnumerableDrop.new)
 
-    %i[min first].each do |method|
+    [ :min, :first ].each do |method|
-      assert_equal '1', Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => RealEnumerableDrop.new)
+      assert_equal "1", Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => RealEnumerableDrop.new)
-      assert_equal '1', Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => RealEnumerableDrop.new)
+      assert_equal "1", Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => RealEnumerableDrop.new)
-      assert_equal '1', Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => EnumerableDrop.new)
+      assert_equal "1", Liquid::Template.parse("{{collection.#{method}}}").render!('collection' => EnumerableDrop.new)
-      assert_equal '1', Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => EnumerableDrop.new)
+      assert_equal "1", Liquid::Template.parse("{{collection[\"#{method}\"]}}").render!('collection' => EnumerableDrop.new)
     end
   end
 
@@ -269,7 +267,7 @@ class DropsTest < Minitest::Test
   end
 
   def test_default_to_s_on_drops
-    assert_equal 'ProductDrop', Liquid::Template.parse('{{ product }}').render!('product' => ProductDrop.new)
+    assert_equal 'ProductDrop', Liquid::Template.parse("{{ product }}").render!('product' => ProductDrop.new)
     assert_equal 'EnumerableDrop', Liquid::Template.parse('{{ collection }}').render!('collection' => EnumerableDrop.new)
   end
 end # DropsTest

test/integration/error_handling_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class ErrorHandlingTest < Minitest::Test
@@ -85,14 +83,15 @@ class ErrorHandlingTest < Minitest::Test
 
   def test_with_line_numbers_adds_numbers_to_parser_errors
     err = assert_raises(SyntaxError) do
-      Liquid::Template.parse('
+      Liquid::Template.parse(%q(
           foobar
 
           {% "cat" | foobar %}
 
           bla
-        ',
+        ),
-                             line_numbers: true)
+        line_numbers: true
+      )
     end
 
     assert_match(/Liquid syntax error \(line 4\)/, err.message)
@@ -100,14 +99,15 @@ class ErrorHandlingTest < Minitest::Test
 
   def test_with_line_numbers_adds_numbers_to_parser_errors_with_whitespace_trim
     err = assert_raises(SyntaxError) do
-      Liquid::Template.parse('
+      Liquid::Template.parse(%q(
           foobar
 
           {%- "cat" | foobar -%}
 
           bla
-        ',
+        ),
-                             line_numbers: true)
+        line_numbers: true
+      )
     end
 
     assert_match(/Liquid syntax error \(line 4\)/, err.message)
@@ -121,11 +121,12 @@ class ErrorHandlingTest < Minitest::Test
 
         bla
             ',
-                                      error_mode: :warn,
+      error_mode: :warn,
-                                      line_numbers: true)
+      line_numbers: true
+                                     )
 
     assert_equal ['Liquid syntax error (line 4): Unexpected character = in "1 =! 2"'],
-                 template.warnings.map(&:message)
+      template.warnings.map(&:message)
   end
 
   def test_parsing_strict_with_line_numbers_adds_numbers_to_lexer_errors
@@ -137,8 +138,9 @@ class ErrorHandlingTest < Minitest::Test
 
           bla
                 ',
-                             error_mode: :strict,
+        error_mode: :strict,
-                             line_numbers: true)
+        line_numbers: true
+                            )
     end
 
     assert_equal 'Liquid syntax error (line 4): Unexpected character = in "1 =! 2"', err.message
@@ -155,7 +157,8 @@ class ErrorHandlingTest < Minitest::Test
 
           bla
                 ',
-                             line_numbers: true)
+        line_numbers: true
+                            )
     end
 
     assert_equal "Liquid syntax error (line 5): Unknown tag 'foo'", err.message
@@ -202,7 +205,7 @@ class ErrorHandlingTest < Minitest::Test
   def test_default_exception_renderer_with_internal_error
     template = Liquid::Template.parse('This is a runtime error: {{ errors.runtime_error }}', line_numbers: true)
 
-    output = template.render('errors' => ErrorDrop.new)
+    output = template.render({ 'errors' => ErrorDrop.new })
 
     assert_equal 'This is a runtime error: Liquid error (line 1): internal', output
     assert_equal [Liquid::InternalError], template.errors.map(&:class)
@@ -211,13 +214,10 @@ class ErrorHandlingTest < Minitest::Test
   def test_setting_default_exception_renderer
     old_exception_renderer = Liquid::Template.default_exception_renderer
     exceptions = []
-    Liquid::Template.default_exception_renderer = lambda { |e|
+    Liquid::Template.default_exception_renderer = ->(e) { exceptions << e; '' }
-      exceptions << e
-      ''
-    }
     template = Liquid::Template.parse('This is a runtime error: {{ errors.argument_error }}')
 
-    output = template.render('errors' => ErrorDrop.new)
+    output = template.render({ 'errors' => ErrorDrop.new })
 
     assert_equal 'This is a runtime error: ', output
     assert_equal [Liquid::ArgumentError], template.errors.map(&:class)
@@ -228,10 +228,7 @@ class ErrorHandlingTest < Minitest::Test
   def test_exception_renderer_exposing_non_liquid_error
     template = Liquid::Template.parse('This is a runtime error: {{ errors.runtime_error }}', line_numbers: true)
     exceptions = []
-    handler = lambda { |e|
+    handler = ->(e) { exceptions << e; e.cause }
-      exceptions << e
-      e.cause
-    }
 
     output = template.render({ 'errors' => ErrorDrop.new }, exception_renderer: handler)
 
@@ -242,8 +239,8 @@ class ErrorHandlingTest < Minitest::Test
   end
 
   class TestFileSystem
-    def read_template_file(_template_path)
+    def read_template_file(template_path)
-      '{{ errors.argument_error }}'
+      "{{ errors.argument_error }}"
     end
   end
 
@@ -258,6 +255,6 @@ class ErrorHandlingTest < Minitest::Test
       Liquid::Template.file_system = old_file_system
     end
     assert_equal "Argument error:\nLiquid error (product line 1): argument error", page
-    assert_equal 'product', template.errors.first.template_name
+    assert_equal "product", template.errors.first.template_name
   end
 end

test/integration/filter_test.rb

@@ -1,26 +1,24 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 module MoneyFilter
   def money(input)
-    format(' %d$ ', input)
+    sprintf(' %d$ ', input)
   end
 
   def money_with_underscore(input)
-    format(' %d$ ', input)
+    sprintf(' %d$ ', input)
   end
 end
 
 module CanadianMoneyFilter
   def money(input)
-    format(' %d$ CAD ', input)
+    sprintf(' %d$ CAD ', input)
   end
 end
 
 module SubstituteFilter
   def substitute(input, params = {})
-    input.gsub(/%\{(\w+)\}/) { |_match| params[Regexp.last_match(1)] }
+    input.gsub(/%\{(\w+)\}/) { |match| params[$1] }
   end
 end
 
@@ -28,8 +26,8 @@ class FiltersTest < Minitest::Test
   include Liquid
 
   module OverrideObjectMethodFilter
-    def tap(_input)
+    def tap(input)
-      'tap overridden'
+      "tap overridden"
     end
   end
 
@@ -41,13 +39,13 @@ class FiltersTest < Minitest::Test
     @context['var'] = 1000
     @context.add_filters(MoneyFilter)
 
-    assert_equal ' 1000$ ', Template.parse('{{var | money}}').render(@context)
+    assert_equal ' 1000$ ', Template.parse("{{var | money}}").render(@context)
   end
 
   def test_underscore_in_filter_name
     @context['var'] = 1000
     @context.add_filters(MoneyFilter)
-    assert_equal ' 1000$ ', Template.parse('{{var | money_with_underscore}}').render(@context)
+    assert_equal ' 1000$ ', Template.parse("{{var | money_with_underscore}}").render(@context)
   end
 
   def test_second_filter_overwrites_first
@@ -55,43 +53,43 @@ class FiltersTest < Minitest::Test
     @context.add_filters(MoneyFilter)
     @context.add_filters(CanadianMoneyFilter)
 
-    assert_equal ' 1000$ CAD ', Template.parse('{{var | money}}').render(@context)
+    assert_equal ' 1000$ CAD ', Template.parse("{{var | money}}").render(@context)
   end
 
   def test_size
     @context['var'] = 'abcd'
     @context.add_filters(MoneyFilter)
 
-    assert_equal '4', Template.parse('{{var | size}}').render(@context)
+    assert_equal '4', Template.parse("{{var | size}}").render(@context)
   end
 
   def test_join
     @context['var'] = [1, 2, 3, 4]
 
-    assert_equal '1 2 3 4', Template.parse('{{var | join}}').render(@context)
+    assert_equal "1 2 3 4", Template.parse("{{var | join}}").render(@context)
   end
 
   def test_sort
     @context['value'] = 3
     @context['numbers'] = [2, 1, 4, 3]
-    @context['words'] = %w[expected as alphabetic]
+    @context['words'] = ['expected', 'as', 'alphabetic']
-    @context['arrays'] = %w[flower are]
+    @context['arrays'] = ['flower', 'are']
-    @context['case_sensitive'] = %w[sensitive Expected case]
+    @context['case_sensitive'] = ['sensitive', 'Expected', 'case']
 
-    assert_equal '1 2 3 4', Template.parse('{{numbers | sort | join}}').render(@context)
+    assert_equal '1 2 3 4', Template.parse("{{numbers | sort | join}}").render(@context)
-    assert_equal 'alphabetic as expected', Template.parse('{{words | sort | join}}').render(@context)
+    assert_equal 'alphabetic as expected', Template.parse("{{words | sort | join}}").render(@context)
-    assert_equal '3', Template.parse('{{value | sort}}').render(@context)
+    assert_equal '3', Template.parse("{{value | sort}}").render(@context)
-    assert_equal 'are flower', Template.parse('{{arrays | sort | join}}').render(@context)
+    assert_equal 'are flower', Template.parse("{{arrays | sort | join}}").render(@context)
-    assert_equal 'Expected case sensitive', Template.parse('{{case_sensitive | sort | join}}').render(@context)
+    assert_equal 'Expected case sensitive', Template.parse("{{case_sensitive | sort | join}}").render(@context)
   end
 
   def test_sort_natural
-    @context['words'] = %w[case Assert Insensitive]
+    @context['words'] = ['case', 'Assert', 'Insensitive']
     @context['hashes'] = [{ 'a' => 'A' }, { 'a' => 'b' }, { 'a' => 'C' }]
     @context['objects'] = [TestObject.new('A'), TestObject.new('b'), TestObject.new('C')]
 
     # Test strings
-    assert_equal 'Assert case Insensitive', Template.parse('{{words | sort_natural | join}}').render(@context)
+    assert_equal 'Assert case Insensitive', Template.parse("{{words | sort_natural | join}}").render(@context)
 
     # Test hashes
     assert_equal 'A b C', Template.parse("{{hashes | sort_natural: 'a' | map: 'a' | join}}").render(@context)
@@ -106,7 +104,7 @@ class FiltersTest < Minitest::Test
     @context['objects'] = [TestObject.new('A'), TestObject.new(nil), TestObject.new('C')]
 
     # Test strings
-    assert_equal 'a b c', Template.parse('{{words | compact | join}}').render(@context)
+    assert_equal 'a b c', Template.parse("{{words | compact | join}}").render(@context)
 
     # Test hashes
     assert_equal 'A C', Template.parse("{{hashes | compact: 'a' | map: 'a' | join}}").render(@context)
@@ -116,27 +114,27 @@ class FiltersTest < Minitest::Test
   end
 
   def test_strip_html
-    @context['var'] = '<b>bla blub</a>'
+    @context['var'] = "<b>bla blub</a>"
 
-    assert_equal 'bla blub', Template.parse('{{ var | strip_html }}').render(@context)
+    assert_equal "bla blub", Template.parse("{{ var | strip_html }}").render(@context)
   end
 
   def test_strip_html_ignore_comments_with_html
-    @context['var'] = '<!-- split and some <ul> tag --><b>bla blub</a>'
+    @context['var'] = "<!-- split and some <ul> tag --><b>bla blub</a>"
 
-    assert_equal 'bla blub', Template.parse('{{ var | strip_html }}').render(@context)
+    assert_equal "bla blub", Template.parse("{{ var | strip_html }}").render(@context)
   end
 
   def test_capitalize
-    @context['var'] = 'blub'
+    @context['var'] = "blub"
 
-    assert_equal 'Blub', Template.parse('{{ var | capitalize }}').render(@context)
+    assert_equal "Blub", Template.parse("{{ var | capitalize }}").render(@context)
   end
 
   def test_nonexistent_filter_is_ignored
     @context['var'] = 1000
 
-    assert_equal '1000', Template.parse('{{ var | xyzzy }}').render(@context)
+    assert_equal '1000', Template.parse("{{ var | xyzzy }}").render(@context)
   end
 
   def test_filter_with_keyword_arguments
@@ -148,10 +146,10 @@ class FiltersTest < Minitest::Test
   end
 
   def test_override_object_method_in_filter
-    assert_equal 'tap overridden', Template.parse('{{var | tap}}').render!({ 'var' => 1000 }, filters: [OverrideObjectMethodFilter])
+    assert_equal "tap overridden", Template.parse("{{var | tap}}").render!({ 'var' => 1000 }, filters: [OverrideObjectMethodFilter])
 
     # tap still treated as a non-existent filter
-    assert_equal '1000', Template.parse('{{var | tap}}').render!('var' => 1000)
+    assert_equal "1000", Template.parse("{{var | tap}}").render!({ 'var' => 1000 })
   end
 end
 
@@ -160,15 +158,15 @@ class FiltersInTemplate < Minitest::Test
 
   def test_local_global
     with_global_filter(MoneyFilter) do
-      assert_equal ' 1000$ ', Template.parse('{{1000 | money}}').render!(nil, nil)
+      assert_equal " 1000$ ", Template.parse("{{1000 | money}}").render!(nil, nil)
-      assert_equal ' 1000$ CAD ', Template.parse('{{1000 | money}}').render!(nil, filters: CanadianMoneyFilter)
+      assert_equal " 1000$ CAD ", Template.parse("{{1000 | money}}").render!(nil, filters: CanadianMoneyFilter)
-      assert_equal ' 1000$ CAD ', Template.parse('{{1000 | money}}').render!(nil, filters: [CanadianMoneyFilter])
+      assert_equal " 1000$ CAD ", Template.parse("{{1000 | money}}").render!(nil, filters: [CanadianMoneyFilter])
     end
   end
 
   def test_local_filter_with_deprecated_syntax
-    assert_equal ' 1000$ CAD ', Template.parse('{{1000 | money}}').render!(nil, CanadianMoneyFilter)
+    assert_equal " 1000$ CAD ", Template.parse("{{1000 | money}}").render!(nil, CanadianMoneyFilter)
-    assert_equal ' 1000$ CAD ', Template.parse('{{1000 | money}}').render!(nil, [CanadianMoneyFilter])
+    assert_equal " 1000$ CAD ", Template.parse("{{1000 | money}}").render!(nil, [CanadianMoneyFilter])
   end
 end # FiltersTest
 

test/integration/hash_ordering_test.rb

@@ -1,17 +1,15 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class HashOrderingTest < Minitest::Test
   module MoneyFilter
     def money(input)
-      format(' %d$ ', input)
+      sprintf(' %d$ ', input)
     end
   end
 
   module CanadianMoneyFilter
     def money(input)
-      format(' %d$ CAD ', input)
+      sprintf(' %d$ CAD ', input)
     end
   end
 
@@ -19,7 +17,7 @@ class HashOrderingTest < Minitest::Test
 
   def test_global_register_order
     with_global_filter(MoneyFilter, CanadianMoneyFilter) do
-      assert_equal ' 1000$ CAD ', Template.parse('{{1000 | money}}').render(nil, nil)
+      assert_equal " 1000$ CAD ", Template.parse("{{1000 | money}}").render(nil, nil)
     end
   end
 end

test/integration/legacy_test.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-require 'liquid/legacy'
-
-class FiltersTest < Minitest::Test
-  include Liquid
-
-  def test_constants
-    assert_equal Liquid::FilterSeparator, Liquid::FILTER_SEPARATOR
-    assert_equal Liquid::BlockBody::ContentOfVariable, Liquid::BlockBody::CONTENT_OF_VARIABLE
-  end
-end

test/integration/output_test.rb

@@ -1,9 +1,7 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 module FunnyFilter
-  def make_funny(_input)
+  def make_funny(input)
     'LOL'
   end
 
@@ -11,11 +9,11 @@ module FunnyFilter
     "LOL: #{input}"
   end
 
-  def add_smiley(input, smiley = ':-)')
+  def add_smiley(input, smiley = ":-)")
     "#{input} #{smiley}"
   end
 
-  def add_tag(input, tag = 'p', id = 'foo')
+  def add_tag(input, tag = "p", id = "foo")
     %(<#{tag} id="#{id}">#{input}</#{tag}>)
   end
 
@@ -34,7 +32,7 @@ class OutputTest < Minitest::Test
   def setup
     @assigns = {
       'best_cars' => 'bmw',
-      'car' => { 'bmw' => 'good', 'gm' => 'bad' },
+      'car' => { 'bmw' => 'good', 'gm' => 'bad' }
     }
   end
 
@@ -47,9 +45,9 @@ class OutputTest < Minitest::Test
 
   def test_variable_traversing_with_two_brackets
     text = %({{ site.data.menu[include.menu][include.locale] }})
-    assert_equal 'it works!', Template.parse(text).render!(
+    assert_equal "it works!", Template.parse(text).render!(
-      'site' => { 'data' => { 'menu' => { 'foo' => { 'bar' => 'it works!' } } } },
+      "site" => { "data" => { "menu" => { "foo" => { "bar" => "it works!" } } } },
-      'include' => { 'menu' => 'foo', 'locale' => 'bar' }
+      "include" => { "menu" => "foo", "locale" => "bar" }
     )
   end
 

test/integration/parse_tree_visitor_test.rb

@@ -1,247 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-
-class ParseTreeVisitorTest < Minitest::Test
-  include Liquid
-
-  def test_variable
-    assert_equal(
-      ['test'],
-      visit(%({{ test }}))
-    )
-  end
-
-  def test_varible_with_filter
-    assert_equal(
-      %w[test infilter],
-      visit(%({{ test | split: infilter }}))
-    )
-  end
-
-  def test_dynamic_variable
-    assert_equal(
-      %w[test inlookup],
-      visit(%({{ test[inlookup] }}))
-    )
-  end
-
-  def test_if_condition
-    assert_equal(
-      ['test'],
-      visit(%({% if test %}{% endif %}))
-    )
-  end
-
-  def test_complex_if_condition
-    assert_equal(
-      ['test'],
-      visit(%({% if 1 == 1 and 2 == test %}{% endif %}))
-    )
-  end
-
-  def test_if_body
-    assert_equal(
-      ['test'],
-      visit(%({% if 1 == 1 %}{{ test }}{% endif %}))
-    )
-  end
-
-  def test_unless_condition
-    assert_equal(
-      ['test'],
-      visit(%({% unless test %}{% endunless %}))
-    )
-  end
-
-  def test_complex_unless_condition
-    assert_equal(
-      ['test'],
-      visit(%({% unless 1 == 1 and 2 == test %}{% endunless %}))
-    )
-  end
-
-  def test_unless_body
-    assert_equal(
-      ['test'],
-      visit(%({% unless 1 == 1 %}{{ test }}{% endunless %}))
-    )
-  end
-
-  def test_elsif_condition
-    assert_equal(
-      ['test'],
-      visit(%({% if 1 == 1 %}{% elsif test %}{% endif %}))
-    )
-  end
-
-  def test_complex_elsif_condition
-    assert_equal(
-      ['test'],
-      visit(%({% if 1 == 1 %}{% elsif 1 == 1 and 2 == test %}{% endif %}))
-    )
-  end
-
-  def test_elsif_body
-    assert_equal(
-      ['test'],
-      visit(%({% if 1 == 1 %}{% elsif 2 == 2 %}{{ test }}{% endif %}))
-    )
-  end
-
-  def test_else_body
-    assert_equal(
-      ['test'],
-      visit(%({% if 1 == 1 %}{% else %}{{ test }}{% endif %}))
-    )
-  end
-
-  def test_case_left
-    assert_equal(
-      ['test'],
-      visit(%({% case test %}{% endcase %}))
-    )
-  end
-
-  def test_case_condition
-    assert_equal(
-      ['test'],
-      visit(%({% case 1 %}{% when test %}{% endcase %}))
-    )
-  end
-
-  def test_case_when_body
-    assert_equal(
-      ['test'],
-      visit(%({% case 1 %}{% when 2 %}{{ test }}{% endcase %}))
-    )
-  end
-
-  def test_case_else_body
-    assert_equal(
-      ['test'],
-      visit(%({% case 1 %}{% else %}{{ test }}{% endcase %}))
-    )
-  end
-
-  def test_for_in
-    assert_equal(
-      ['test'],
-      visit(%({% for x in test %}{% endfor %}))
-    )
-  end
-
-  def test_for_limit
-    assert_equal(
-      ['test'],
-      visit(%({% for x in (1..5) limit: test %}{% endfor %}))
-    )
-  end
-
-  def test_for_offset
-    assert_equal(
-      ['test'],
-      visit(%({% for x in (1..5) offset: test %}{% endfor %}))
-    )
-  end
-
-  def test_for_body
-    assert_equal(
-      ['test'],
-      visit(%({% for x in (1..5) %}{{ test }}{% endfor %}))
-    )
-  end
-
-  def test_tablerow_in
-    assert_equal(
-      ['test'],
-      visit(%({% tablerow x in test %}{% endtablerow %}))
-    )
-  end
-
-  def test_tablerow_limit
-    assert_equal(
-      ['test'],
-      visit(%({% tablerow x in (1..5) limit: test %}{% endtablerow %}))
-    )
-  end
-
-  def test_tablerow_offset
-    assert_equal(
-      ['test'],
-      visit(%({% tablerow x in (1..5) offset: test %}{% endtablerow %}))
-    )
-  end
-
-  def test_tablerow_body
-    assert_equal(
-      ['test'],
-      visit(%({% tablerow x in (1..5) %}{{ test }}{% endtablerow %}))
-    )
-  end
-
-  def test_cycle
-    assert_equal(
-      ['test'],
-      visit(%({% cycle test %}))
-    )
-  end
-
-  def test_assign
-    assert_equal(
-      ['test'],
-      visit(%({% assign x = test %}))
-    )
-  end
-
-  def test_capture
-    assert_equal(
-      ['test'],
-      visit(%({% capture x %}{{ test }}{% endcapture %}))
-    )
-  end
-
-  def test_include
-    assert_equal(
-      ['test'],
-      visit(%({% include test %}))
-    )
-  end
-
-  def test_include_with
-    assert_equal(
-      ['test'],
-      visit(%({% include "hai" with test %}))
-    )
-  end
-
-  def test_include_for
-    assert_equal(
-      ['test'],
-      visit(%({% include "hai" for test %}))
-    )
-  end
-
-  def test_preserve_tree_structure
-    assert_equal(
-      [[nil, [
-        [nil, [[nil, [['other', []]]]]],
-        ['test', []],
-        ['xs', []],
-      ]]],
-      traversal(%({% for x in xs offset: test %}{{ other }}{% endfor %})).visit
-    )
-  end
-
-  private
-
-  def traversal(template)
-    ParseTreeVisitor
-      .for(Template.parse(template).root)
-      .add_callback_for(VariableLookup, &:name)
-  end
-
-  def visit(template)
-    traversal(template).visit.flatten.compact
-  end
-end

test/integration/parsing_quirks_test.rb

@@ -1,43 +1,41 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class ParsingQuirksTest < Minitest::Test
   include Liquid
 
   def test_parsing_css
-    text = ' div { font-weight: bold; } '
+    text = " div { font-weight: bold; } "
     assert_equal text, Template.parse(text).render!
   end
 
   def test_raise_on_single_close_bracet
     assert_raises(SyntaxError) do
-      Template.parse('text {{method} oh nos!')
+      Template.parse("text {{method} oh nos!")
     end
   end
 
   def test_raise_on_label_and_no_close_bracets
     assert_raises(SyntaxError) do
-      Template.parse('TEST {{ ')
+      Template.parse("TEST {{ ")
     end
   end
 
   def test_raise_on_label_and_no_close_bracets_percent
     assert_raises(SyntaxError) do
-      Template.parse('TEST {% ')
+      Template.parse("TEST {% ")
     end
   end
 
   def test_error_on_empty_filter
-    assert Template.parse('{{test}}')
+    assert Template.parse("{{test}}")
 
     with_error_mode(:lax) do
-      assert Template.parse('{{|test}}')
+      assert Template.parse("{{|test}}")
     end
 
     with_error_mode(:strict) do
-      assert_raises(SyntaxError) { Template.parse('{{|test}}') }
+      assert_raises(SyntaxError) { Template.parse("{{|test}}") }
-      assert_raises(SyntaxError) { Template.parse('{{test |a|b|}}') }
+      assert_raises(SyntaxError) { Template.parse("{{test |a|b|}}") }
     end
   end
 
@@ -53,20 +51,20 @@ class ParsingQuirksTest < Minitest::Test
   def test_unexpected_characters_syntax_error
     with_error_mode(:strict) do
       assert_raises(SyntaxError) do
-        markup = 'true && false'
+        markup = "true && false"
         Template.parse("{% if #{markup} %} YES {% endif %}")
       end
       assert_raises(SyntaxError) do
-        markup = 'false || true'
+        markup = "false || true"
         Template.parse("{% if #{markup} %} YES {% endif %}")
       end
     end
   end
 
   def test_no_error_on_lax_empty_filter
-    assert Template.parse('{{test |a|b|}}', error_mode: :lax)
+    assert Template.parse("{{test |a|b|}}", error_mode: :lax)
-    assert Template.parse('{{test}}', error_mode: :lax)
+    assert Template.parse("{{test}}", error_mode: :lax)
-    assert Template.parse('{{|test|}}', error_mode: :lax)
+    assert Template.parse("{{|test|}}", error_mode: :lax)
   end
 
   def test_meaningless_parens_lax
@@ -79,9 +77,9 @@ class ParsingQuirksTest < Minitest::Test
 
   def test_unexpected_characters_silently_eat_logic_lax
     with_error_mode(:lax) do
-      markup = 'true && false'
+      markup = "true && false"
       assert_template_result(' YES ', "{% if #{markup} %} YES {% endif %}")
-      markup = 'false || true'
+      markup = "false || true"
       assert_template_result('', "{% if #{markup} %} YES {% endif %}")
     end
   end
@@ -101,7 +99,7 @@ class ParsingQuirksTest < Minitest::Test
       # After the messed up quotes a filter without parameters (reverse) should work
       # but one with parameters (remove) shouldn't be detected.
       assert_template_result('here',  "{{ 'hi there' | split:\"t\"\" | reverse | first}}")
-      assert_template_result('hi ', "{{ 'hi there' | split:\"t\"\" | remove:\"i\" | first}}")
+      assert_template_result('hi ',  "{{ 'hi there' | split:\"t\"\" | remove:\"i\" | first}}")
     end
   end
 
@@ -114,7 +112,7 @@ class ParsingQuirksTest < Minitest::Test
 
   def test_extra_dots_in_ranges
     with_error_mode(:lax) do
-      assert_template_result('12345', '{% for i in (1...5) %}{{ i }}{% endfor %}')
+      assert_template_result('12345', "{% for i in (1...5) %}{{ i }}{% endfor %}")
     end
   end
 

test/integration/render_profiling_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class RenderProfilingTest < Minitest::Test
@@ -74,7 +72,7 @@ class RenderProfilingTest < Minitest::Test
     t = Template.parse("{% include 'a_template' %}", profile: true)
     t.render!
 
-    assert t.profiler.total_render_time >= 0, 'Total render time was not calculated'
+    assert t.profiler.total_render_time >= 0, "Total render time was not calculated"
   end
 
   def test_profiling_uses_include_to_mark_children
@@ -91,7 +89,7 @@ class RenderProfilingTest < Minitest::Test
 
     include_node = t.profiler[1]
     include_node.children.each do |child|
-      assert_equal 'a_template', child.partial
+      assert_equal "a_template", child.partial
     end
   end
 
@@ -101,12 +99,12 @@ class RenderProfilingTest < Minitest::Test
 
     a_template = t.profiler[1]
     a_template.children.each do |child|
-      assert_equal 'a_template', child.partial
+      assert_equal "a_template", child.partial
     end
 
     b_template = t.profiler[2]
     b_template.children.each do |child|
-      assert_equal 'b_template', child.partial
+      assert_equal "b_template", child.partial
     end
   end
 
@@ -116,12 +114,12 @@ class RenderProfilingTest < Minitest::Test
 
     a_template1 = t.profiler[1]
     a_template1.children.each do |child|
-      assert_equal 'a_template', child.partial
+      assert_equal "a_template", child.partial
     end
 
     a_template2 = t.profiler[2]
     a_template2.children.each do |child|
-      assert_equal 'a_template', child.partial
+      assert_equal "a_template", child.partial
     end
   end
 
@@ -130,7 +128,7 @@ class RenderProfilingTest < Minitest::Test
     t.render!
 
     timing_count = 0
-    t.profiler.each do |_timing|
+    t.profiler.each do |timing|
       timing_count += 1
     end
 
@@ -138,7 +136,7 @@ class RenderProfilingTest < Minitest::Test
   end
 
   def test_profiling_marks_children_of_if_blocks
-    t = Template.parse('{% if true %} {% increment test %} {{ test }} {% endif %}', profile: true)
+    t = Template.parse("{% if true %} {% increment test %} {{ test }} {% endif %}", profile: true)
     t.render!
 
     assert_equal 1, t.profiler.length
@@ -146,8 +144,8 @@ class RenderProfilingTest < Minitest::Test
   end
 
   def test_profiling_marks_children_of_for_blocks
-    t = Template.parse('{% for item in collection %} {{ item }} {% endfor %}', profile: true)
+    t = Template.parse("{% for item in collection %} {{ item }} {% endfor %}", profile: true)
-    t.render!('collection' => %w[one two])
+    t.render!({ "collection" => ["one", "two"] })
 
     assert_equal 1, t.profiler.length
     # Will profile each invocation of the for block

test/integration/security_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 module SecurityFilter
@@ -59,22 +57,22 @@ class SecurityTest < Minitest::Test
     current_symbols = Symbol.all_symbols
 
     assigns = { 'drop' => Drop.new }
-    assert_equal '', Template.parse('{{ drop.custom_method_1 }}', assigns).render!
+    assert_equal "", Template.parse("{{ drop.custom_method_1 }}", assigns).render!
-    assert_equal '', Template.parse('{{ drop.custom_method_2 }}', assigns).render!
+    assert_equal "", Template.parse("{{ drop.custom_method_2 }}", assigns).render!
-    assert_equal '', Template.parse('{{ drop.custom_method_3 }}', assigns).render!
+    assert_equal "", Template.parse("{{ drop.custom_method_3 }}", assigns).render!
 
     assert_equal [], (Symbol.all_symbols - current_symbols)
   end
 
   def test_max_depth_nested_blocks_does_not_raise_exception
     depth = Liquid::Block::MAX_DEPTH
-    code = '{% if true %}' * depth + 'rendered' + '{% endif %}' * depth
+    code = "{% if true %}" * depth + "rendered" + "{% endif %}" * depth
-    assert_equal 'rendered', Template.parse(code).render!
+    assert_equal "rendered", Template.parse(code).render!
   end
 
   def test_more_than_max_depth_nested_blocks_raises_exception
     depth = Liquid::Block::MAX_DEPTH + 1
-    code = '{% if true %}' * depth + 'rendered' + '{% endif %}' * depth
+    code = "{% if true %}" * depth + "rendered" + "{% endif %}" * depth
     assert_raises(Liquid::StackLevelError) do
       Template.parse(code).render!
     end

test/integration/standard_filter_test.rb

@@ -1,4 +1,4 @@
-# frozen_string_literal: true
+# encoding: utf-8
 
 require 'test_helper'
 
@@ -17,7 +17,7 @@ class TestThing
     "woot: #{@foo}"
   end
 
-  def [](_whatever)
+  def [](whatever)
     to_s
   end
 
@@ -29,7 +29,7 @@ end
 
 class TestDrop < Liquid::Drop
   def test
-    'testfoo'
+    "testfoo"
   end
 end
 
@@ -37,7 +37,7 @@ class TestEnumerable < Liquid::Drop
   include Enumerable
 
   def each(&block)
-    [{ 'foo' => 1, 'bar' => 2 }, { 'foo' => 2, 'bar' => 1 }, { 'foo' => 3, 'bar' => 3 }].each(&block)
+    [ { "foo" => 1, "bar" => 2 }, { "foo" => 2, "bar" => 1 }, { "foo" => 3, "bar" => 3 } ].each(&block)
   end
 end
 
@@ -65,12 +65,12 @@ class StandardFiltersTest < Minitest::Test
   end
 
   def test_downcase
-    assert_equal 'testing', @filters.downcase('Testing')
+    assert_equal 'testing', @filters.downcase("Testing")
     assert_equal '', @filters.downcase(nil)
   end
 
   def test_upcase
-    assert_equal 'TESTING', @filters.upcase('Testing')
+    assert_equal 'TESTING', @filters.upcase("Testing")
     assert_equal '', @filters.upcase(nil)
   end
 
@@ -91,22 +91,22 @@ class StandardFiltersTest < Minitest::Test
       @filters.slice('foobar', nil)
     end
     assert_raises(Liquid::ArgumentError) do
-      @filters.slice('foobar', 0, '')
+      @filters.slice('foobar', 0, "")
     end
   end
 
   def test_slice_on_arrays
     input = 'foobar'.split(//)
-    assert_equal %w[o o b], @filters.slice(input, 1, 3)
+    assert_equal %w(o o b), @filters.slice(input, 1, 3)
-    assert_equal %w[o o b a r], @filters.slice(input, 1, 1000)
+    assert_equal %w(o o b a r), @filters.slice(input, 1, 1000)
-    assert_equal %w[], @filters.slice(input, 1, 0)
+    assert_equal %w(), @filters.slice(input, 1, 0)
-    assert_equal %w[o], @filters.slice(input, 1, 1)
+    assert_equal %w(o), @filters.slice(input, 1, 1)
-    assert_equal %w[b a r], @filters.slice(input, 3, 3)
+    assert_equal %w(b a r), @filters.slice(input, 3, 3)
-    assert_equal %w[a r], @filters.slice(input, -2, 2)
+    assert_equal %w(a r), @filters.slice(input, -2, 2)
-    assert_equal %w[a r], @filters.slice(input, -2, 1000)
+    assert_equal %w(a r), @filters.slice(input, -2, 1000)
-    assert_equal %w[r], @filters.slice(input, -1)
+    assert_equal %w(r), @filters.slice(input, -1)
-    assert_equal %w[], @filters.slice(input, 100, 10)
+    assert_equal %w(), @filters.slice(input, 100, 10)
-    assert_equal %w[], @filters.slice(input, -100, 10)
+    assert_equal %w(), @filters.slice(input, -100, 10)
   end
 
   def test_truncate
@@ -114,16 +114,16 @@ class StandardFiltersTest < Minitest::Test
     assert_equal '1234567890', @filters.truncate('1234567890', 20)
     assert_equal '...', @filters.truncate('1234567890', 0)
     assert_equal '1234567890', @filters.truncate('1234567890')
-    assert_equal '测试...', @filters.truncate('测试测试测试测试', 5)
+    assert_equal "测试...", @filters.truncate("测试测试测试测试", 5)
-    assert_equal '12341', @filters.truncate('1234567890', 5, 1)
+    assert_equal '12341', @filters.truncate("1234567890", 5, 1)
   end
 
   def test_split
-    assert_equal %w[12 34], @filters.split('12~34', '~')
+    assert_equal ['12', '34'], @filters.split('12~34', '~')
     assert_equal ['A? ', ' ,Z'], @filters.split('A? ~ ~ ~ ,Z', '~ ~ ~')
     assert_equal ['A?Z'], @filters.split('A?Z', '~')
     assert_equal [], @filters.split(nil, ' ')
-    assert_equal %w[A Z], @filters.split('A1Z', 1)
+    assert_equal ['A', 'Z'], @filters.split('A1Z', 1)
   end
 
   def test_escape
@@ -158,10 +158,6 @@ class StandardFiltersTest < Minitest::Test
     assert_equal '1', @filters.url_decode(1)
     assert_equal '2001-02-03', @filters.url_decode(Date.new(2001, 2, 3))
     assert_nil @filters.url_decode(nil)
-    exception = assert_raises Liquid::ArgumentError do
-      @filters.url_decode('%ff')
-    end
-    assert_equal 'Liquid error: invalid byte sequence in UTF-8', exception.message
   end
 
   def test_truncatewords
@@ -169,21 +165,18 @@ class StandardFiltersTest < Minitest::Test
     assert_equal 'one two...', @filters.truncatewords('one two three', 2)
     assert_equal 'one two three', @filters.truncatewords('one two three')
     assert_equal 'Two small (13&#8221; x 5.5&#8221; x 10&#8221; high) baskets fit inside one large basket (13&#8221;...', @filters.truncatewords('Two small (13&#8221; x 5.5&#8221; x 10&#8221; high) baskets fit inside one large basket (13&#8221; x 16&#8221; x 10.5&#8221; high) with cover.', 15)
-    assert_equal '测试测试测试测试', @filters.truncatewords('测试测试测试测试', 5)
+    assert_equal "测试测试测试测试", @filters.truncatewords('测试测试测试测试', 5)
-    assert_equal 'one two1', @filters.truncatewords('one two three', 2, 1)
+    assert_equal 'one two1', @filters.truncatewords("one two three", 2, 1)
   end
 
   def test_strip_html
-    assert_equal 'test', @filters.strip_html('<div>test</div>')
+    assert_equal 'test', @filters.strip_html("<div>test</div>")
     assert_equal 'test', @filters.strip_html("<div id='test'>test</div>")
     assert_equal '', @filters.strip_html("<script type='text/javascript'>document.write('some stuff');</script>")
     assert_equal '', @filters.strip_html("<style type='text/css'>foo bar</style>")
     assert_equal 'test', @filters.strip_html("<div\nclass='multiline'>test</div>")
     assert_equal 'test', @filters.strip_html("<!-- foo bar \n test -->test")
     assert_equal '', @filters.strip_html(nil)
-
-    # Quirk of the existing implementation
-    assert_equal 'foo;', @filters.strip_html('<<<script </script>script>foo;</script>')
   end
 
   def test_join
@@ -194,164 +187,60 @@ class StandardFiltersTest < Minitest::Test
 
   def test_sort
     assert_equal [1, 2, 3, 4], @filters.sort([4, 3, 2, 1])
-    assert_equal [{ 'a' => 1 }, { 'a' => 2 }, { 'a' => 3 }, { 'a' => 4 }], @filters.sort([{ 'a' => 4 }, { 'a' => 3 }, { 'a' => 1 }, { 'a' => 2 }], 'a')
+    assert_equal [{ "a" => 1 }, { "a" => 2 }, { "a" => 3 }, { "a" => 4 }], @filters.sort([{ "a" => 4 }, { "a" => 3 }, { "a" => 1 }, { "a" => 2 }], "a")
-  end
-
-  def test_sort_with_nils
-    assert_equal [1, 2, 3, 4, nil], @filters.sort([nil, 4, 3, 2, 1])
-    assert_equal [{ 'a' => 1 }, { 'a' => 2 }, { 'a' => 3 }, { 'a' => 4 }, {}], @filters.sort([{ 'a' => 4 }, { 'a' => 3 }, {}, { 'a' => 1 }, { 'a' => 2 }], 'a')
   end
 
   def test_sort_when_property_is_sometimes_missing_puts_nils_last
     input = [
-      { 'price' => 4, 'handle' => 'alpha' },
+      { "price" => 4, "handle" => "alpha" },
-      { 'handle' => 'beta' },
+      { "handle" => "beta" },
-      { 'price' => 1, 'handle' => 'gamma' },
+      { "price" => 1, "handle" => "gamma" },
-      { 'handle' => 'delta' },
+      { "handle" => "delta" },
-      { 'price' => 2, 'handle' => 'epsilon' },
+      { "price" => 2, "handle" => "epsilon" }
     ]
     expectation = [
-      { 'price' => 1, 'handle' => 'gamma' },
+      { "price" => 1, "handle" => "gamma" },
-      { 'price' => 2, 'handle' => 'epsilon' },
+      { "price" => 2, "handle" => "epsilon" },
-      { 'price' => 4, 'handle' => 'alpha' },
+      { "price" => 4, "handle" => "alpha" },
-      { 'handle' => 'delta' },
+      { "handle" => "delta" },
-      { 'handle' => 'beta' },
+      { "handle" => "beta" }
     ]
-    assert_equal expectation, @filters.sort(input, 'price')
+    assert_equal expectation, @filters.sort(input, "price")
-  end
-
-  def test_sort_natural
-    assert_equal %w[a B c D], @filters.sort_natural(%w[c D a B])
-    assert_equal [{ 'a' => 'a' }, { 'a' => 'B' }, { 'a' => 'c' }, { 'a' => 'D' }], @filters.sort_natural([{ 'a' => 'D' }, { 'a' => 'c' }, { 'a' => 'a' }, { 'a' => 'B' }], 'a')
-  end
-
-  def test_sort_natural_with_nils
-    assert_equal ['a', 'B', 'c', 'D', nil], @filters.sort_natural([nil, 'c', 'D', 'a', 'B'])
-    assert_equal [{ 'a' => 'a' }, { 'a' => 'B' }, { 'a' => 'c' }, { 'a' => 'D' }, {}], @filters.sort_natural([{ 'a' => 'D' }, { 'a' => 'c' }, {}, { 'a' => 'a' }, { 'a' => 'B' }], 'a')
-  end
-
-  def test_sort_natural_when_property_is_sometimes_missing_puts_nils_last
-    input = [
-      { 'price' => '4', 'handle' => 'alpha' },
-      { 'handle' => 'beta' },
-      { 'price' => '1', 'handle' => 'gamma' },
-      { 'handle' => 'delta' },
-      { 'price' => 2, 'handle' => 'epsilon' },
-    ]
-    expectation = [
-      { 'price' => '1', 'handle' => 'gamma' },
-      { 'price' => 2, 'handle' => 'epsilon' },
-      { 'price' => '4', 'handle' => 'alpha' },
-      { 'handle' => 'delta' },
-      { 'handle' => 'beta' },
-    ]
-    assert_equal expectation, @filters.sort_natural(input, 'price')
-  end
-
-  def test_sort_natural_case_check
-    input = [
-      { 'key' => 'X' },
-      { 'key' => 'Y' },
-      { 'key' => 'Z' },
-      { 'fake' => 't' },
-      { 'key' => 'a' },
-      { 'key' => 'b' },
-      { 'key' => 'c' },
-    ]
-    expectation = [
-      { 'key' => 'a' },
-      { 'key' => 'b' },
-      { 'key' => 'c' },
-      { 'key' => 'X' },
-      { 'key' => 'Y' },
-      { 'key' => 'Z' },
-      { 'fake' => 't' },
-    ]
-    assert_equal expectation, @filters.sort_natural(input, 'key')
-    assert_equal %w[a b c X Y Z], @filters.sort_natural(%w[X Y Z a b c])
   end
 
   def test_sort_empty_array
-    assert_equal [], @filters.sort([], 'a')
+    assert_equal [], @filters.sort([], "a")
-  end
-
-  def test_sort_invalid_property
-    foo = [
-      [1],
-      [2],
-      [3],
-    ]
-
-    assert_raises Liquid::ArgumentError do
-      @filters.sort(foo, 'bar')
-    end
   end
 
   def test_sort_natural_empty_array
-    assert_equal [], @filters.sort_natural([], 'a')
+    assert_equal [], @filters.sort_natural([], "a")
-  end
-
-  def test_sort_natural_invalid_property
-    foo = [
-      [1],
-      [2],
-      [3],
-    ]
-
-    assert_raises Liquid::ArgumentError do
-      @filters.sort_natural(foo, 'bar')
-    end
   end
 
   def test_legacy_sort_hash
-    assert_equal [{ a: 1, b: 2 }], @filters.sort(a: 1, b: 2)
+    assert_equal [{ a: 1, b: 2 }], @filters.sort({ a: 1, b: 2 })
   end
 
   def test_numerical_vs_lexicographical_sort
     assert_equal [2, 10], @filters.sort([10, 2])
-    assert_equal [{ 'a' => 2 }, { 'a' => 10 }], @filters.sort([{ 'a' => 10 }, { 'a' => 2 }], 'a')
+    assert_equal [{ "a" => 2 }, { "a" => 10 }], @filters.sort([{ "a" => 10 }, { "a" => 2 }], "a")
-    assert_equal %w[10 2], @filters.sort(%w[10 2])
+    assert_equal ["10", "2"], @filters.sort(["10", "2"])
-    assert_equal [{ 'a' => '10' }, { 'a' => '2' }], @filters.sort([{ 'a' => '10' }, { 'a' => '2' }], 'a')
+    assert_equal [{ "a" => "10" }, { "a" => "2" }], @filters.sort([{ "a" => "10" }, { "a" => "2" }], "a")
   end
 
   def test_uniq
-    assert_equal ['foo'], @filters.uniq('foo')
+    assert_equal ["foo"], @filters.uniq("foo")
     assert_equal [1, 3, 2, 4], @filters.uniq([1, 1, 3, 2, 3, 1, 4, 3, 2, 1])
-    assert_equal [{ 'a' => 1 }, { 'a' => 3 }, { 'a' => 2 }], @filters.uniq([{ 'a' => 1 }, { 'a' => 3 }, { 'a' => 1 }, { 'a' => 2 }], 'a')
+    assert_equal [{ "a" => 1 }, { "a" => 3 }, { "a" => 2 }], @filters.uniq([{ "a" => 1 }, { "a" => 3 }, { "a" => 1 }, { "a" => 2 }], "a")
     testdrop = TestDrop.new
     assert_equal [testdrop], @filters.uniq([testdrop, TestDrop.new], 'test')
   end
 
   def test_uniq_empty_array
-    assert_equal [], @filters.uniq([], 'a')
+    assert_equal [], @filters.uniq([], "a")
-  end
-
-  def test_uniq_invalid_property
-    foo = [
-      [1],
-      [2],
-      [3],
-    ]
-
-    assert_raises Liquid::ArgumentError do
-      @filters.uniq(foo, 'bar')
-    end
   end
 
   def test_compact_empty_array
-    assert_equal [], @filters.compact([], 'a')
+    assert_equal [], @filters.compact([], "a")
-  end
-
-  def test_compact_invalid_property
-    foo = [
-      [1],
-      [2],
-      [3],
-    ]
-
-    assert_raises Liquid::ArgumentError do
-      @filters.compact(foo, 'bar')
-    end
   end
 
   def test_reverse
@@ -363,87 +252,64 @@ class StandardFiltersTest < Minitest::Test
   end
 
   def test_map
-    assert_equal [1, 2, 3, 4], @filters.map([{ 'a' => 1 }, { 'a' => 2 }, { 'a' => 3 }, { 'a' => 4 }], 'a')
+    assert_equal [1, 2, 3, 4], @filters.map([{ "a" => 1 }, { "a" => 2 }, { "a" => 3 }, { "a" => 4 }], 'a')
     assert_template_result 'abc', "{{ ary | map:'foo' | map:'bar' }}",
-                           'ary' => [{ 'foo' => { 'bar' => 'a' } }, { 'foo' => { 'bar' => 'b' } }, { 'foo' => { 'bar' => 'c' } }]
+      'ary' => [{ 'foo' => { 'bar' => 'a' } }, { 'foo' => { 'bar' => 'b' } }, { 'foo' => { 'bar' => 'c' } }]
   end
 
   def test_map_doesnt_call_arbitrary_stuff
-    assert_template_result '', '{{ "foo" | map: "__id__" }}'
+    assert_template_result "", '{{ "foo" | map: "__id__" }}'
-    assert_template_result '', '{{ "foo" | map: "inspect" }}'
+    assert_template_result "", '{{ "foo" | map: "inspect" }}'
   end
 
   def test_map_calls_to_liquid
     t = TestThing.new
-    assert_template_result 'woot: 1', '{{ foo | map: "whatever" }}', 'foo' => [t]
+    assert_template_result "woot: 1", '{{ foo | map: "whatever" }}', "foo" => [t]
   end
 
   def test_map_on_hashes
-    assert_template_result '4217', '{{ thing | map: "foo" | map: "bar" }}',
+    assert_template_result "4217", '{{ thing | map: "foo" | map: "bar" }}',
-                           'thing' => { 'foo' => [{ 'bar' => 42 }, { 'bar' => 17 }] }
+      "thing" => { "foo" => [ { "bar" => 42 }, { "bar" => 17 } ] }
   end
 
   def test_legacy_map_on_hashes_with_dynamic_key
     template = "{% assign key = 'foo' %}{{ thing | map: key | map: 'bar' }}"
-    hash = { 'foo' => { 'bar' => 42 } }
+    hash = { "foo" => { "bar" => 42 } }
-    assert_template_result '42', template, 'thing' => hash
+    assert_template_result "42", template, "thing" => hash
   end
 
   def test_sort_calls_to_liquid
     t = TestThing.new
-    Liquid::Template.parse('{{ foo | sort: "whatever" }}').render('foo' => [t])
+    Liquid::Template.parse('{{ foo | sort: "whatever" }}').render("foo" => [t])
-    assert t.foo.positive?
+    assert t.foo > 0
   end
 
   def test_map_over_proc
     drop = TestDrop.new
-    p = proc { drop }
+    p = proc{ drop }
     templ = '{{ procs | map: "test" }}'
-    assert_template_result 'testfoo', templ, 'procs' => [p]
+    assert_template_result "testfoo", templ, "procs" => [p]
   end
 
   def test_map_over_drops_returning_procs
     drops = [
       {
-        'proc' => -> { 'foo' },
+        "proc" => ->{ "foo" },
       },
       {
-        'proc' => -> { 'bar' },
+        "proc" => ->{ "bar" },
       },
     ]
     templ = '{{ drops | map: "proc" }}'
-    assert_template_result 'foobar', templ, 'drops' => drops
+    assert_template_result "foobar", templ, "drops" => drops
   end
 
   def test_map_works_on_enumerables
-    assert_template_result '123', '{{ foo | map: "foo" }}', 'foo' => TestEnumerable.new
+    assert_template_result "123", '{{ foo | map: "foo" }}', "foo" => TestEnumerable.new
-  end
-
-  def test_map_returns_empty_on_2d_input_array
-    foo = [
-      [1],
-      [2],
-      [3],
-    ]
-
-    assert_raises Liquid::ArgumentError do
-      @filters.map(foo, 'bar')
-    end
-  end
-
-  def test_map_returns_empty_with_no_property
-    foo = [
-      [1],
-      [2],
-      [3],
-    ]
-    assert_raises Liquid::ArgumentError do
-      @filters.map(foo, nil)
-    end
   end
 
   def test_sort_works_on_enumerables
-    assert_template_result '213', '{{ foo | sort: "bar" | map: "foo" }}', 'foo' => TestEnumerable.new
+    assert_template_result "213", '{{ foo | sort: "bar" | map: "foo" }}', "foo" => TestEnumerable.new
   end
 
   def test_first_and_last_call_to_liquid
@@ -452,37 +318,37 @@ class StandardFiltersTest < Minitest::Test
   end
 
   def test_truncate_calls_to_liquid
-    assert_template_result 'wo...', '{{ foo | truncate: 5 }}', 'foo' => TestThing.new
+    assert_template_result "wo...", '{{ foo | truncate: 5 }}', "foo" => TestThing.new
   end
 
   def test_date
-    assert_equal 'May', @filters.date(Time.parse('2006-05-05 10:00:00'), '%B')
+    assert_equal 'May', @filters.date(Time.parse("2006-05-05 10:00:00"), "%B")
-    assert_equal 'June', @filters.date(Time.parse('2006-06-05 10:00:00'), '%B')
+    assert_equal 'June', @filters.date(Time.parse("2006-06-05 10:00:00"), "%B")
-    assert_equal 'July', @filters.date(Time.parse('2006-07-05 10:00:00'), '%B')
+    assert_equal 'July', @filters.date(Time.parse("2006-07-05 10:00:00"), "%B")
 
-    assert_equal 'May', @filters.date('2006-05-05 10:00:00', '%B')
+    assert_equal 'May', @filters.date("2006-05-05 10:00:00", "%B")
-    assert_equal 'June', @filters.date('2006-06-05 10:00:00', '%B')
+    assert_equal 'June', @filters.date("2006-06-05 10:00:00", "%B")
-    assert_equal 'July', @filters.date('2006-07-05 10:00:00', '%B')
+    assert_equal 'July', @filters.date("2006-07-05 10:00:00", "%B")
 
-    assert_equal '2006-07-05 10:00:00', @filters.date('2006-07-05 10:00:00', '')
+    assert_equal '2006-07-05 10:00:00', @filters.date("2006-07-05 10:00:00", "")
-    assert_equal '2006-07-05 10:00:00', @filters.date('2006-07-05 10:00:00', '')
+    assert_equal '2006-07-05 10:00:00', @filters.date("2006-07-05 10:00:00", "")
-    assert_equal '2006-07-05 10:00:00', @filters.date('2006-07-05 10:00:00', '')
+    assert_equal '2006-07-05 10:00:00', @filters.date("2006-07-05 10:00:00", "")
-    assert_equal '2006-07-05 10:00:00', @filters.date('2006-07-05 10:00:00', nil)
+    assert_equal '2006-07-05 10:00:00', @filters.date("2006-07-05 10:00:00", nil)
 
-    assert_equal '07/05/2006', @filters.date('2006-07-05 10:00:00', '%m/%d/%Y')
+    assert_equal '07/05/2006', @filters.date("2006-07-05 10:00:00", "%m/%d/%Y")
 
-    assert_equal '07/16/2004', @filters.date('Fri Jul 16 01:00:00 2004', '%m/%d/%Y')
+    assert_equal "07/16/2004", @filters.date("Fri Jul 16 01:00:00 2004", "%m/%d/%Y")
-    assert_equal Date.today.year.to_s, @filters.date('now', '%Y')
+    assert_equal "#{Date.today.year}", @filters.date('now', '%Y')
-    assert_equal Date.today.year.to_s, @filters.date('today', '%Y')
+    assert_equal "#{Date.today.year}", @filters.date('today', '%Y')
-    assert_equal Date.today.year.to_s, @filters.date('Today', '%Y')
+    assert_equal "#{Date.today.year}", @filters.date('Today', '%Y')
 
-    assert_nil @filters.date(nil, '%B')
+    assert_nil @filters.date(nil, "%B")
 
-    assert_equal '', @filters.date('', '%B')
+    assert_equal '', @filters.date('', "%B")
 
-    with_timezone('UTC') do
+    with_timezone("UTC") do
-      assert_equal '07/05/2006', @filters.date(1_152_098_955, '%m/%d/%Y')
+      assert_equal "07/05/2006", @filters.date(1152098955, "%m/%d/%Y")
-      assert_equal '07/05/2006', @filters.date('1152098955', '%m/%d/%Y')
+      assert_equal "07/05/2006", @filters.date("1152098955", "%m/%d/%Y")
     end
   end
 
@@ -502,10 +368,10 @@ class StandardFiltersTest < Minitest::Test
   end
 
   def test_remove
-    assert_equal '   ', @filters.remove('a a a a', 'a')
+    assert_equal '   ', @filters.remove("a a a a", 'a')
-    assert_equal '   ', @filters.remove('1 1 1 1', 1)
+    assert_equal '   ', @filters.remove("1 1 1 1", 1)
-    assert_equal 'a a a', @filters.remove_first('a a a a', 'a ')
+    assert_equal 'a a a', @filters.remove_first("a a a a", 'a ')
-    assert_equal ' 1 1 1', @filters.remove_first('1 1 1 1', 1)
+    assert_equal ' 1 1 1', @filters.remove_first("1 1 1 1", 1)
     assert_template_result 'a a a', "{{ 'a a a a' | remove_first: 'a ' }}"
   end
 
@@ -514,148 +380,126 @@ class StandardFiltersTest < Minitest::Test
   end
 
   def test_strip
-    assert_template_result 'ab c', '{{ source | strip }}', 'source' => ' ab c  '
+    assert_template_result 'ab c', "{{ source | strip }}", 'source' => " ab c  "
-    assert_template_result 'ab c', '{{ source | strip }}', 'source' => " \tab c  \n \t"
+    assert_template_result 'ab c', "{{ source | strip }}", 'source' => " \tab c  \n \t"
   end
 
   def test_lstrip
-    assert_template_result 'ab c  ', '{{ source | lstrip }}', 'source' => ' ab c  '
+    assert_template_result 'ab c  ', "{{ source | lstrip }}", 'source' => " ab c  "
-    assert_template_result "ab c  \n \t", '{{ source | lstrip }}', 'source' => " \tab c  \n \t"
+    assert_template_result "ab c  \n \t", "{{ source | lstrip }}", 'source' => " \tab c  \n \t"
   end
 
   def test_rstrip
-    assert_template_result ' ab c', '{{ source | rstrip }}', 'source' => ' ab c  '
+    assert_template_result " ab c", "{{ source | rstrip }}", 'source' => " ab c  "
-    assert_template_result " \tab c", '{{ source | rstrip }}', 'source' => " \tab c  \n \t"
+    assert_template_result " \tab c", "{{ source | rstrip }}", 'source' => " \tab c  \n \t"
   end
 
   def test_strip_newlines
-    assert_template_result 'abc', '{{ source | strip_newlines }}', 'source' => "a\nb\nc"
+    assert_template_result 'abc', "{{ source | strip_newlines }}", 'source' => "a\nb\nc"
-    assert_template_result 'abc', '{{ source | strip_newlines }}', 'source' => "a\r\nb\nc"
+    assert_template_result 'abc', "{{ source | strip_newlines }}", 'source' => "a\r\nb\nc"
   end
 
   def test_newlines_to_br
-    assert_template_result "a<br />\nb<br />\nc", '{{ source | newline_to_br }}', 'source' => "a\nb\nc"
+    assert_template_result "a<br />\nb<br />\nc", "{{ source | newline_to_br }}", 'source' => "a\nb\nc"
   end
 
   def test_plus
-    assert_template_result '2', '{{ 1 | plus:1 }}'
+    assert_template_result "2", "{{ 1 | plus:1 }}"
-    assert_template_result '2.0', "{{ '1' | plus:'1.0' }}"
+    assert_template_result "2.0", "{{ '1' | plus:'1.0' }}"
 
-    assert_template_result '5', "{{ price | plus:'2' }}", 'price' => NumberLikeThing.new(3)
+    assert_template_result "5", "{{ price | plus:'2' }}", 'price' => NumberLikeThing.new(3)
   end
 
   def test_minus
-    assert_template_result '4', '{{ input | minus:operand }}', 'input' => 5, 'operand' => 1
+    assert_template_result "4", "{{ input | minus:operand }}", 'input' => 5, 'operand' => 1
-    assert_template_result '2.3', "{{ '4.3' | minus:'2' }}"
+    assert_template_result "2.3", "{{ '4.3' | minus:'2' }}"
 
-    assert_template_result '5', "{{ price | minus:'2' }}", 'price' => NumberLikeThing.new(7)
+    assert_template_result "5", "{{ price | minus:'2' }}", 'price' => NumberLikeThing.new(7)
   end
 
   def test_abs
-    assert_template_result '17', '{{ 17 | abs }}'
+    assert_template_result "17", "{{ 17 | abs }}"
-    assert_template_result '17', '{{ -17 | abs }}'
+    assert_template_result "17", "{{ -17 | abs }}"
-    assert_template_result '17', "{{ '17' | abs }}"
+    assert_template_result "17", "{{ '17' | abs }}"
-    assert_template_result '17', "{{ '-17' | abs }}"
+    assert_template_result "17", "{{ '-17' | abs }}"
-    assert_template_result '0', '{{ 0 | abs }}'
+    assert_template_result "0", "{{ 0 | abs }}"
-    assert_template_result '0', "{{ '0' | abs }}"
+    assert_template_result "0", "{{ '0' | abs }}"
-    assert_template_result '17.42', '{{ 17.42 | abs }}'
+    assert_template_result "17.42", "{{ 17.42 | abs }}"
-    assert_template_result '17.42', '{{ -17.42 | abs }}'
+    assert_template_result "17.42", "{{ -17.42 | abs }}"
-    assert_template_result '17.42', "{{ '17.42' | abs }}"
+    assert_template_result "17.42", "{{ '17.42' | abs }}"
-    assert_template_result '17.42', "{{ '-17.42' | abs }}"
+    assert_template_result "17.42", "{{ '-17.42' | abs }}"
   end
 
   def test_times
-    assert_template_result '12', '{{ 3 | times:4 }}'
+    assert_template_result "12", "{{ 3 | times:4 }}"
-    assert_template_result '0', "{{ 'foo' | times:4 }}"
+    assert_template_result "0", "{{ 'foo' | times:4 }}"
-    assert_template_result '6', "{{ '2.1' | times:3 | replace: '.','-' | plus:0}}"
+    assert_template_result "6", "{{ '2.1' | times:3 | replace: '.','-' | plus:0}}"
-    assert_template_result '7.25', '{{ 0.0725 | times:100 }}'
+    assert_template_result "7.25", "{{ 0.0725 | times:100 }}"
-    assert_template_result '-7.25', '{{ "-0.0725" | times:100 }}'
+    assert_template_result "-7.25", '{{ "-0.0725" | times:100 }}'
-    assert_template_result '7.25', '{{ "-0.0725" | times: -100 }}'
+    assert_template_result "7.25", '{{ "-0.0725" | times: -100 }}'
-    assert_template_result '4', '{{ price | times:2 }}', 'price' => NumberLikeThing.new(2)
+    assert_template_result "4", "{{ price | times:2 }}", 'price' => NumberLikeThing.new(2)
   end
 
   def test_divided_by
-    assert_template_result '4', '{{ 12 | divided_by:3 }}'
+    assert_template_result "4", "{{ 12 | divided_by:3 }}"
-    assert_template_result '4', '{{ 14 | divided_by:3 }}'
+    assert_template_result "4", "{{ 14 | divided_by:3 }}"
 
-    assert_template_result '5', '{{ 15 | divided_by:3 }}'
+    assert_template_result "5", "{{ 15 | divided_by:3 }}"
-    assert_equal 'Liquid error: divided by 0', Template.parse('{{ 5 | divided_by:0 }}').render
+    assert_equal "Liquid error: divided by 0", Template.parse("{{ 5 | divided_by:0 }}").render
 
-    assert_template_result '0.5', '{{ 2.0 | divided_by:4 }}'
+    assert_template_result "0.5", "{{ 2.0 | divided_by:4 }}"
     assert_raises(Liquid::ZeroDivisionError) do
-      assert_template_result '4', '{{ 1 | modulo: 0 }}'
+      assert_template_result "4", "{{ 1 | modulo: 0 }}"
     end
 
-    assert_template_result '5', '{{ price | divided_by:2 }}', 'price' => NumberLikeThing.new(10)
+    assert_template_result "5", "{{ price | divided_by:2 }}", 'price' => NumberLikeThing.new(10)
   end
 
   def test_modulo
-    assert_template_result '1', '{{ 3 | modulo:2 }}'
+    assert_template_result "1", "{{ 3 | modulo:2 }}"
     assert_raises(Liquid::ZeroDivisionError) do
-      assert_template_result '4', '{{ 1 | modulo: 0 }}'
+      assert_template_result "4", "{{ 1 | modulo: 0 }}"
     end
 
-    assert_template_result '1', '{{ price | modulo:2 }}', 'price' => NumberLikeThing.new(3)
+    assert_template_result "1", "{{ price | modulo:2 }}", 'price' => NumberLikeThing.new(3)
   end
 
   def test_round
-    assert_template_result '5', '{{ input | round }}', 'input' => 4.6
+    assert_template_result "5", "{{ input | round }}", 'input' => 4.6
-    assert_template_result '4', "{{ '4.3' | round }}"
+    assert_template_result "4", "{{ '4.3' | round }}"
-    assert_template_result '4.56', '{{ input | round: 2 }}', 'input' => 4.5612
+    assert_template_result "4.56", "{{ input | round: 2 }}", 'input' => 4.5612
     assert_raises(Liquid::FloatDomainError) do
-      assert_template_result '4', '{{ 1.0 | divided_by: 0.0 | round }}'
+      assert_template_result "4", "{{ 1.0 | divided_by: 0.0 | round }}"
     end
 
-    assert_template_result '5', '{{ price | round }}', 'price' => NumberLikeThing.new(4.6)
+    assert_template_result "5", "{{ price | round }}", 'price' => NumberLikeThing.new(4.6)
-    assert_template_result '4', '{{ price | round }}', 'price' => NumberLikeThing.new(4.3)
+    assert_template_result "4", "{{ price | round }}", 'price' => NumberLikeThing.new(4.3)
   end
 
   def test_ceil
-    assert_template_result '5', '{{ input | ceil }}', 'input' => 4.6
+    assert_template_result "5", "{{ input | ceil }}", 'input' => 4.6
-    assert_template_result '5', "{{ '4.3' | ceil }}"
+    assert_template_result "5", "{{ '4.3' | ceil }}"
     assert_raises(Liquid::FloatDomainError) do
-      assert_template_result '4', '{{ 1.0 | divided_by: 0.0 | ceil }}'
+      assert_template_result "4", "{{ 1.0 | divided_by: 0.0 | ceil }}"
     end
 
-    assert_template_result '5', '{{ price | ceil }}', 'price' => NumberLikeThing.new(4.6)
+    assert_template_result "5", "{{ price | ceil }}", 'price' => NumberLikeThing.new(4.6)
   end
 
   def test_floor
-    assert_template_result '4', '{{ input | floor }}', 'input' => 4.6
+    assert_template_result "4", "{{ input | floor }}", 'input' => 4.6
-    assert_template_result '4', "{{ '4.3' | floor }}"
+    assert_template_result "4", "{{ '4.3' | floor }}"
     assert_raises(Liquid::FloatDomainError) do
-      assert_template_result '4', '{{ 1.0 | divided_by: 0.0 | floor }}'
+      assert_template_result "4", "{{ 1.0 | divided_by: 0.0 | floor }}"
     end
 
-    assert_template_result '5', '{{ price | floor }}', 'price' => NumberLikeThing.new(5.4)
+    assert_template_result "5", "{{ price | floor }}", 'price' => NumberLikeThing.new(5.4)
-  end
-
-  def test_at_most
-    assert_template_result '4', '{{ 5 | at_most:4 }}'
-    assert_template_result '5', '{{ 5 | at_most:5 }}'
-    assert_template_result '5', '{{ 5 | at_most:6 }}'
-
-    assert_template_result '4.5', '{{ 4.5 | at_most:5 }}'
-    assert_template_result '5', '{{ width | at_most:5 }}', 'width' => NumberLikeThing.new(6)
-    assert_template_result '4', '{{ width | at_most:5 }}', 'width' => NumberLikeThing.new(4)
-    assert_template_result '4', '{{ 5 | at_most: width }}', 'width' => NumberLikeThing.new(4)
-  end
-
-  def test_at_least
-    assert_template_result '5', '{{ 5 | at_least:4 }}'
-    assert_template_result '5', '{{ 5 | at_least:5 }}'
-    assert_template_result '6', '{{ 5 | at_least:6 }}'
-
-    assert_template_result '5', '{{ 4.5 | at_least:5 }}'
-    assert_template_result '6', '{{ width | at_least:5 }}', 'width' => NumberLikeThing.new(6)
-    assert_template_result '5', '{{ width | at_least:5 }}', 'width' => NumberLikeThing.new(4)
-    assert_template_result '6', '{{ 5 | at_least: width }}', 'width' => NumberLikeThing.new(6)
   end
 
   def test_append
     assigns = { 'a' => 'bc', 'b' => 'd' }
     assert_template_result('bcd', "{{ a | append: 'd'}}", assigns)
-    assert_template_result('bcd', '{{ a | append: b}}', assigns)
+    assert_template_result('bcd', "{{ a | append: b}}", assigns)
   end
 
   def test_concat
@@ -663,7 +507,7 @@ class StandardFiltersTest < Minitest::Test
     assert_equal [1, 2, 'a'],  @filters.concat([1, 2], ['a'])
     assert_equal [1, 2, 10],   @filters.concat([1, 2], [10])
 
-    assert_raises(Liquid::ArgumentError, 'concat filter requires an array argument') do
+    assert_raises(Liquid::ArgumentError, "concat filter requires an array argument") do
       @filters.concat([1, 2], 10)
     end
   end
@@ -671,16 +515,16 @@ class StandardFiltersTest < Minitest::Test
   def test_prepend
     assigns = { 'a' => 'bc', 'b' => 'a' }
     assert_template_result('abc', "{{ a | prepend: 'a'}}", assigns)
-    assert_template_result('abc', '{{ a | prepend: b}}', assigns)
+    assert_template_result('abc', "{{ a | prepend: b}}", assigns)
   end
 
   def test_default
-    assert_equal 'foo', @filters.default('foo', 'bar')
+    assert_equal "foo", @filters.default("foo", "bar")
-    assert_equal 'bar', @filters.default(nil, 'bar')
+    assert_equal "bar", @filters.default(nil, "bar")
-    assert_equal 'bar', @filters.default('', 'bar')
+    assert_equal "bar", @filters.default("", "bar")
-    assert_equal 'bar', @filters.default(false, 'bar')
+    assert_equal "bar", @filters.default(false, "bar")
-    assert_equal 'bar', @filters.default([], 'bar')
+    assert_equal "bar", @filters.default([], "bar")
-    assert_equal 'bar', @filters.default({}, 'bar')
+    assert_equal "bar", @filters.default({}, "bar")
   end
 
   def test_cannot_access_private_methods
@@ -692,78 +536,6 @@ class StandardFiltersTest < Minitest::Test
     assert_template_result('abc', "{{ 'abc' | date: '%D' }}")
   end
 
-  def test_where
-    input = [
-      { 'handle' => 'alpha', 'ok' => true },
-      { 'handle' => 'beta', 'ok' => false },
-      { 'handle' => 'gamma', 'ok' => false },
-      { 'handle' => 'delta', 'ok' => true },
-    ]
-
-    expectation = [
-      { 'handle' => 'alpha', 'ok' => true },
-      { 'handle' => 'delta', 'ok' => true },
-    ]
-
-    assert_equal expectation, @filters.where(input, 'ok', true)
-    assert_equal expectation, @filters.where(input, 'ok')
-  end
-
-  def test_where_no_key_set
-    input = [
-      { 'handle' => 'alpha', 'ok' => true },
-      { 'handle' => 'beta' },
-      { 'handle' => 'gamma' },
-      { 'handle' => 'delta', 'ok' => true },
-    ]
-
-    expectation = [
-      { 'handle' => 'alpha', 'ok' => true },
-      { 'handle' => 'delta', 'ok' => true },
-    ]
-
-    assert_equal expectation, @filters.where(input, 'ok', true)
-    assert_equal expectation, @filters.where(input, 'ok')
-  end
-
-  def test_where_non_array_map_input
-    assert_equal [{ 'a' => 'ok' }], @filters.where({ 'a' => 'ok' }, 'a', 'ok')
-    assert_equal [], @filters.where({ 'a' => 'not ok' }, 'a', 'ok')
-  end
-
-  def test_where_indexable_but_non_map_value
-    assert_raises(Liquid::ArgumentError) { @filters.where(1, 'ok', true) }
-    assert_raises(Liquid::ArgumentError) { @filters.where(1, 'ok') }
-  end
-
-  def test_where_non_boolean_value
-    input = [
-      { 'message' => 'Bonjour!', 'language' => 'French' },
-      { 'message' => 'Hello!', 'language' => 'English' },
-      { 'message' => 'Hallo!', 'language' => 'German' },
-    ]
-
-    assert_equal [{ 'message' => 'Bonjour!', 'language' => 'French' }], @filters.where(input, 'language', 'French')
-    assert_equal [{ 'message' => 'Hallo!', 'language' => 'German' }], @filters.where(input, 'language', 'German')
-    assert_equal [{ 'message' => 'Hello!', 'language' => 'English' }], @filters.where(input, 'language', 'English')
-  end
-
-  def test_where_array_of_only_unindexable_values
-    assert_nil @filters.where([nil], 'ok', true)
-    assert_nil @filters.where([nil], 'ok')
-  end
-
-  def test_where_no_target_value
-    input = [
-      { 'foo' => false },
-      { 'foo' => true },
-      { 'foo' => 'for sure' },
-      { 'bar' => true },
-    ]
-
-    assert_equal [{ 'foo' => true }, { 'foo' => 'for sure' }], @filters.where(input, 'foo')
-  end
-
   private
 
   def with_timezone(tz)

test/integration/tags/break_tag_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class BreakTagTest < Minitest::Test

test/integration/tags/continue_tag_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class ContinueTagTest < Minitest::Test

test/integration/tags/for_tag_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class ThingWithValue < Liquid::Drop
@@ -25,16 +23,16 @@ class ForTagTest < Minitest::Test
   yo
 
 HERE
-    template = <<~HERE
+    template = <<HERE
-      {%for item in array%}
+{%for item in array%}
-        yo
+  yo
-      {%endfor%}
+{%endfor%}
-    HERE
+HERE
     assert_template_result(expected, template, 'array' => [1, 2, 3])
   end
 
   def test_for_reversed
-    assigns = { 'array' => [1, 2, 3] }
+    assigns = { 'array' => [ 1, 2, 3] }
     assert_template_result('321', '{%for item in array reversed %}{{item}}{%endfor%}', assigns)
   end
 
@@ -42,31 +40,35 @@ HERE
     assert_template_result(' 1  2  3 ', '{%for item in (1..3) %} {{item}} {%endfor%}')
 
     assert_raises(Liquid::ArgumentError) do
-      Template.parse('{% for i in (a..2) %}{% endfor %}').render!('a' => [1, 2])
+      Template.parse('{% for i in (a..2) %}{% endfor %}').render!("a" => [1, 2])
     end
 
-    assert_template_result(' 0  1  2  3 ', '{% for item in (a..3) %} {{item}} {% endfor %}', 'a' => 'invalid integer')
+    assert_template_result(' 0  1  2  3 ', '{% for item in (a..3) %} {{item}} {% endfor %}', "a" => "invalid integer")
   end
 
   def test_for_with_variable_range
-    assert_template_result(' 1  2  3 ', '{%for item in (1..foobar) %} {{item}} {%endfor%}', 'foobar' => 3)
+    assert_template_result(' 1  2  3 ', '{%for item in (1..foobar) %} {{item}} {%endfor%}', "foobar" => 3)
+    assert_template_result(' 1.0  2.0  3.0 ', '{%for item in foobar %} {{item}} {%endfor%}', "foobar" => (1..3.0))
+    assert_template_result(' 1.0  2.0  3.0 ', '{%for item in foobar %} {{item}} {%endfor%}', "foobar" => (1.0..3))
+    assert_template_result(' 1.0  2.0  3.0 ', '{%for item in foobar %} {{item}} {%endfor%}', "foobar" => (1.0..3.0))
+    assert_template_result(' 1.5  2.5 ', '{%for item in foobar %} {{item}} {%endfor%}', "foobar" => (1.5..3))
   end
 
   def test_for_with_hash_value_range
-    foobar = { 'value' => 3 }
+    foobar = { "value" => 3 }
-    assert_template_result(' 1  2  3 ', '{%for item in (1..foobar.value) %} {{item}} {%endfor%}', 'foobar' => foobar)
+    assert_template_result(' 1  2  3 ', '{%for item in (1..foobar.value) %} {{item}} {%endfor%}', "foobar" => foobar)
   end
 
   def test_for_with_drop_value_range
     foobar = ThingWithValue.new
-    assert_template_result(' 1  2  3 ', '{%for item in (1..foobar.value) %} {{item}} {%endfor%}', 'foobar' => foobar)
+    assert_template_result(' 1  2  3 ', '{%for item in (1..foobar.value) %} {{item}} {%endfor%}', "foobar" => foobar)
   end
 
   def test_for_with_variable
     assert_template_result(' 1  2  3 ', '{%for item in array%} {{item}} {%endfor%}', 'array' => [1, 2, 3])
     assert_template_result('123', '{%for item in array%}{{item}}{%endfor%}', 'array' => [1, 2, 3])
     assert_template_result('123', '{% for item in array %}{{item}}{% endfor %}', 'array' => [1, 2, 3])
-    assert_template_result('abcd', '{%for item in array%}{{item}}{%endfor%}', 'array' => %w[a b c d])
+    assert_template_result('abcd', '{%for item in array%}{{item}}{%endfor%}', 'array' => ['a', 'b', 'c', 'd'])
     assert_template_result('a b c', '{%for item in array%}{{item}}{%endfor%}', 'array' => ['a', ' ', 'b', ' ', 'c'])
     assert_template_result('abc', '{%for item in array%}{{item}}{%endfor%}', 'array' => ['a', '', 'b', '', 'c'])
   end
@@ -74,8 +76,8 @@ HERE
   def test_for_helpers
     assigns = { 'array' => [1, 2, 3] }
     assert_template_result(' 1/3  2/3  3/3 ',
-                           '{%for item in array%} {{forloop.index}}/{{forloop.length}} {%endfor%}',
+      '{%for item in array%} {{forloop.index}}/{{forloop.length}} {%endfor%}',
-                           assigns)
+      assigns)
     assert_template_result(' 1  2  3 ', '{%for item in array%} {{forloop.index}} {%endfor%}', assigns)
     assert_template_result(' 0  1  2 ', '{%for item in array%} {{forloop.index0}} {%endfor%}', assigns)
     assert_template_result(' 2  1  0 ', '{%for item in array%} {{forloop.rindex0}} {%endfor%}', assigns)
@@ -87,8 +89,8 @@ HERE
   def test_for_and_if
     assigns = { 'array' => [1, 2, 3] }
     assert_template_result('+--',
-                           '{%for item in array%}{% if forloop.first %}+{% else %}-{% endif %}{%endfor%}',
+      '{%for item in array%}{% if forloop.first %}+{% else %}-{% endif %}{%endfor%}',
-                           assigns)
+      assigns)
   end
 
   def test_for_else
@@ -105,34 +107,6 @@ HERE
     assert_template_result('3456', '{%for i in array limit: 4 offset: 2 %}{{ i }}{%endfor%}', assigns)
   end
 
-  def test_limiting_with_invalid_limit
-    assigns = { 'array' => [1, 2, 3, 4, 5, 6, 7, 8, 9, 0] }
-    template = <<-MKUP
-      {% for i in array limit: true offset: 1 %}
-        {{ i }}
-      {% endfor %}
-    MKUP
-
-    exception = assert_raises(Liquid::ArgumentError) do
-      Template.parse(template).render!(assigns)
-    end
-    assert_equal('Liquid error: invalid integer', exception.message)
-  end
-
-  def test_limiting_with_invalid_offset
-    assigns = { 'array' => [1, 2, 3, 4, 5, 6, 7, 8, 9, 0] }
-    template = <<-MKUP
-      {% for i in array limit: 1 offset: true %}
-        {{ i }}
-      {% endfor %}
-    MKUP
-
-    exception = assert_raises(Liquid::ArgumentError) do
-      Template.parse(template).render!(assigns)
-    end
-    assert_equal('Liquid error: invalid integer', exception.message)
-  end
-
   def test_dynamic_variable_limiting
     assigns = { 'array' => [1, 2, 3, 4, 5, 6, 7, 8, 9, 0] }
     assigns['limit'] = 2
@@ -159,14 +133,14 @@ HERE
       {%for i in array.items offset:continue limit: 3 %}{{i}}{%endfor%}
       next
       {%for i in array.items offset:continue limit: 3 %}{{i}}{%endfor%}
-    MKUP
+      MKUP
     expected = <<-XPCTD
       123
       next
       456
       next
       789
-    XPCTD
+      XPCTD
     assert_template_result(expected, markup, assigns)
   end
 
@@ -178,18 +152,18 @@ HERE
       {%for i in array.items offset:continue limit:3 %}{{i}}{%endfor%}
       next
       {%for i in array.items offset:continue limit:1 %}{{i}}{%endfor%}
-    MKUP
+      MKUP
     expected = <<-XPCTD
       123
       next
       456
       next
       7
-    XPCTD
+      XPCTD
     assert_template_result(expected, markup, assigns)
   end
 
-  def test_pause_resume_big_limit
+  def test_pause_resume_BIG_limit
     assigns = { 'array' => { 'items' => [1, 2, 3, 4, 5, 6, 7, 8, 9, 0] } }
     markup = <<-MKUP
       {%for i in array.items limit:3 %}{{i}}{%endfor%}
@@ -197,18 +171,18 @@ HERE
       {%for i in array.items offset:continue limit:3 %}{{i}}{%endfor%}
       next
       {%for i in array.items offset:continue limit:1000 %}{{i}}{%endfor%}
-    MKUP
+      MKUP
     expected = <<-XPCTD
       123
       next
       456
       next
       7890
-    XPCTD
+      XPCTD
     assert_template_result(expected, markup, assigns)
   end
 
-  def test_pause_resume_big_offset
+  def test_pause_resume_BIG_offset
     assigns = { 'array' => { 'items' => [1, 2, 3, 4, 5, 6, 7, 8, 9, 0] } }
     markup = '{%for i in array.items limit:3 %}{{i}}{%endfor%}
       next
@@ -227,19 +201,19 @@ HERE
     assigns = { 'array' => { 'items' => [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] } }
 
     markup = '{% for i in array.items %}{% break %}{% endfor %}'
-    expected = ''
+    expected = ""
     assert_template_result(expected, markup, assigns)
 
     markup = '{% for i in array.items %}{{ i }}{% break %}{% endfor %}'
-    expected = '1'
+    expected = "1"
     assert_template_result(expected, markup, assigns)
 
     markup = '{% for i in array.items %}{% break %}{{ i }}{% endfor %}'
-    expected = ''
+    expected = ""
     assert_template_result(expected, markup, assigns)
 
     markup = '{% for i in array.items %}{{ i }}{% if i > 3 %}{% break %}{% endif %}{% endfor %}'
-    expected = '1234'
+    expected = "1234"
     assert_template_result(expected, markup, assigns)
 
     # tests to ensure it only breaks out of the local for loop
@@ -267,23 +241,23 @@ HERE
     assigns = { 'array' => { 'items' => [1, 2, 3, 4, 5] } }
 
     markup = '{% for i in array.items %}{% continue %}{% endfor %}'
-    expected = ''
+    expected = ""
     assert_template_result(expected, markup, assigns)
 
     markup = '{% for i in array.items %}{{ i }}{% continue %}{% endfor %}'
-    expected = '12345'
+    expected = "12345"
     assert_template_result(expected, markup, assigns)
 
     markup = '{% for i in array.items %}{% continue %}{{ i }}{% endfor %}'
-    expected = ''
+    expected = ""
     assert_template_result(expected, markup, assigns)
 
     markup = '{% for i in array.items %}{% if i > 3 %}{% continue %}{% endif %}{{ i }}{% endfor %}'
-    expected = '123'
+    expected = "123"
     assert_template_result(expected, markup, assigns)
 
     markup = '{% for i in array.items %}{% if i == 3 %}{% continue %}{% else %}{{ i }}{% endif %}{% endfor %}'
-    expected = '1245'
+    expected = "1245"
     assert_template_result(expected, markup, assigns)
 
     # tests to ensure it only continues the local for loop and not all of them.
@@ -312,41 +286,41 @@ HERE
     # the functionality for backwards compatibility
 
     assert_template_result('test string',
-                           '{%for val in string%}{{val}}{%endfor%}',
+      '{%for val in string%}{{val}}{%endfor%}',
-                           'string' => 'test string')
+      'string' => "test string")
 
     assert_template_result('test string',
-                           '{%for val in string limit:1%}{{val}}{%endfor%}',
+      '{%for val in string limit:1%}{{val}}{%endfor%}',
-                           'string' => 'test string')
+      'string' => "test string")
 
     assert_template_result('val-string-1-1-0-1-0-true-true-test string',
-                           '{%for val in string%}' \
+      '{%for val in string%}' \
-                           '{{forloop.name}}-' \
+      '{{forloop.name}}-' \
-                           '{{forloop.index}}-' \
+      '{{forloop.index}}-' \
-                           '{{forloop.length}}-' \
+      '{{forloop.length}}-' \
-                           '{{forloop.index0}}-' \
+      '{{forloop.index0}}-' \
-                           '{{forloop.rindex}}-' \
+      '{{forloop.rindex}}-' \
-                           '{{forloop.rindex0}}-' \
+      '{{forloop.rindex0}}-' \
-                           '{{forloop.first}}-' \
+      '{{forloop.first}}-' \
-                           '{{forloop.last}}-' \
+      '{{forloop.last}}-' \
-                           '{{val}}{%endfor%}',
+      '{{val}}{%endfor%}',
-                           'string' => 'test string')
+      'string' => "test string")
   end
 
   def test_for_parentloop_references_parent_loop
     assert_template_result('1.1 1.2 1.3 2.1 2.2 2.3 ',
-                           '{% for inner in outer %}{% for k in inner %}' \
+      '{% for inner in outer %}{% for k in inner %}' \
-                           '{{ forloop.parentloop.index }}.{{ forloop.index }} ' \
+      '{{ forloop.parentloop.index }}.{{ forloop.index }} ' \
-                           '{% endfor %}{% endfor %}',
+      '{% endfor %}{% endfor %}',
-                           'outer' => [[1, 1, 1], [1, 1, 1]])
+      'outer' => [[1, 1, 1], [1, 1, 1]])
   end
 
   def test_for_parentloop_nil_when_not_present
     assert_template_result('.1 .2 ',
-                           '{% for inner in outer %}' \
+      '{% for inner in outer %}' \
-                           '{{ forloop.parentloop.index }}.{{ forloop.index }} ' \
+      '{{ forloop.parentloop.index }}.{{ forloop.index }} ' \
-                           '{% endfor %}',
+      '{% endfor %}',
-                           'outer' => [[1, 1, 1], [1, 1, 1]])
+      'outer' => [[1, 1, 1], [1, 1, 1]])
   end
 
   def test_inner_for_over_empty_input
@@ -354,7 +328,7 @@ HERE
   end
 
   def test_blank_string_not_iterable
-    assert_template_result('', '{% for char in characters %}I WILL NOT BE OUTPUT{% endfor %}', 'characters' => '')
+    assert_template_result('', "{% for char in characters %}I WILL NOT BE OUTPUT{% endfor %}", 'characters' => '')
   end
 
   def test_bad_variable_naming_in_for_loop

test/integration/tags/if_else_tag_test.rb

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 require 'test_helper'
 
 class IfElseTagTest < Minitest::Test
@@ -8,7 +6,7 @@ class IfElseTagTest < Minitest::Test
   def test_if
     assert_template_result('  ', ' {% if false %} this text should not go into the output {% endif %} ')
     assert_template_result('  this text should go into the output  ',
-                           ' {% if true %} this text should go into the output {% endif %} ')
+      ' {% if true %} this text should go into the output {% endif %} ')
     assert_template_result('  you rock ?', '{% if false %} you suck {% endif %} {% if true %} you rock {% endif %}?')
   end
 
@@ -51,12 +49,12 @@ class IfElseTagTest < Minitest::Test
 
   def test_comparison_of_expressions_starting_with_and_or_or
     assigns = { 'order' => { 'items_count' => 0 }, 'android' => { 'name' => 'Roy' } }
-    assert_template_result('YES',
+    assert_template_result("YES",
-                           "{% if android.name == 'Roy' %}YES{% endif %}",
+      "{% if android.name == 'Roy' %}YES{% endif %}",
-                           assigns)
+      assigns)
-    assert_template_result('YES',
+    assert_template_result("YES",
-                           '{% if order.items_count == 0 %}YES{% endif %}',
+      "{% if order.items_count == 0 %}YES{% endif %}",
-                           assigns)
+      assigns)
   end
 
   def test_if_and
@@ -77,14 +75,14 @@ class IfElseTagTest < Minitest::Test
     assert_template_result('', '{% if foo.bar %} NO {% endif %}', 'foo' => nil)
     assert_template_result('', '{% if foo.bar %} NO {% endif %}', 'foo' => true)
 
-    assert_template_result(' YES ', '{% if var %} YES {% endif %}', 'var' => 'text')
+    assert_template_result(' YES ', '{% if var %} YES {% endif %}', 'var' => "text")
     assert_template_result(' YES ', '{% if var %} YES {% endif %}', 'var' => true)
     assert_template_result(' YES ', '{% if var %} YES {% endif %}', 'var' => 1)
     assert_template_result(' YES ', '{% if var %} YES {% endif %}', 'var' => {})
     assert_template_result(' YES ', '{% if var %} YES {% endif %}', 'var' => [])
     assert_template_result(' YES ', '{% if "foo" %} YES {% endif %}')
     assert_template_result(' YES ', '{% if foo.bar %} YES {% endif %}', 'foo' => { 'bar' => true })
-    assert_template_result(' YES ', '{% if foo.bar %} YES {% endif %}', 'foo' => { 'bar' => 'text' })
+    assert_template_result(' YES ', '{% if foo.bar %} YES {% endif %}', 'foo' => { 'bar' => "text" })
     assert_template_result(' YES ', '{% if foo.bar %} YES {% endif %}', 'foo' => { 'bar' => 1 })
     assert_template_result(' YES ', '{% if foo.bar %} YES {% endif %}', 'foo' => { 'bar' => {} })
     assert_template_result(' YES ', '{% if foo.bar %} YES {% endif %}', 'foo' => { 'bar' => [] })
@@ -92,11 +90,11 @@ class IfElseTagTest < Minitest::Test
     assert_template_result(' YES ', '{% if var %} NO {% else %} YES {% endif %}', 'var' => false)
     assert_template_result(' YES ', '{% if var %} NO {% else %} YES {% endif %}', 'var' => nil)
     assert_template_result(' YES ', '{% if var %} YES {% else %} NO {% endif %}', 'var' => true)
-    assert_template_result(' YES ', '{% if "foo" %} YES {% else %} NO {% endif %}', 'var' => 'text')
+    assert_template_result(' YES ', '{% if "foo" %} YES {% else %} NO {% endif %}', 'var' => "text")
 
     assert_template_result(' YES ', '{% if foo.bar %} NO {% else %} YES {% endif %}', 'foo' => { 'bar' => false })
     assert_template_result(' YES ', '{% if foo.bar %} YES {% else %} NO {% endif %}', 'foo' => { 'bar' => true })
-    assert_template_result(' YES ', '{% if foo.bar %} YES {% else %} NO {% endif %}', 'foo' => { 'bar' => 'text' })
+    assert_template_result(' YES ', '{% if foo.bar %} YES {% else %} NO {% endif %}', 'foo' => { 'bar' => "text" })
     assert_template_result(' YES ', '{% if foo.bar %} NO {% else %} YES {% endif %}', 'foo' => { 'notbar' => true })
     assert_template_result(' YES ', '{% if foo.bar %} NO {% else %} YES {% endif %}', 'foo' => {})
     assert_template_result(' YES ', '{% if foo.bar %} NO {% else %} YES {% endif %}', 'notfoo' => { 'bar' => true })
@@ -134,7 +132,7 @@ class IfElseTagTest < Minitest::Test
   end
 
   def test_syntax_error_no_variable
-    assert_raises(SyntaxError) { assert_template_result('', '{% if jerry == 1 %}') }
+    assert_raises(SyntaxError){ assert_template_result('', '{% if jerry == 1 %}') }
   end
 
   def test_syntax_error_no_expression
@@ -156,7 +154,7 @@ class IfElseTagTest < Minitest::Test
     Condition.operators['contains'] = :[]
 
     assert_template_result('yes',
-                           %({% if 'gnomeslab-and-or-liquid' contains 'gnomeslab-and-or-liquid' %}yes{% endif %}))
+      %({% if 'gnomeslab-and-or-liquid' contains 'gnomeslab-and-or-liquid' %}yes{% endif %}))
   ensure
     Condition.operators['contains'] = original_op
   end
@@ -168,7 +166,7 @@ class IfElseTagTest < Minitest::Test
   end
 
   def test_multiple_conditions
-    tpl = '{% if a or b and c %}true{% else %}false{% endif %}'
+    tpl = "{% if a or b and c %}true{% else %}false{% endif %}"
 
     tests = {
       [true, true, true] => true,