kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-01 16:05:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

job parsing: fix panic when variable validation is missing condition (#16018)

Browse Source
This commit is contained in:
Tim Gross
2023-02-01 16:41:03 -05:00
committed by GitHub
parent 67f8f22df7
commit 00d5749a4b
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/16018.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:bug
parser: Fixed a panic in the job spec parser when a variable validation block was missing its condition
```

11
jobspec2/types.variables.go
View File

@@ -95,6 +95,17 @@ func (v *Variable) validateValue(val VariableAssignment) (diags hcl.Diagnostics)
for _, validation := range v.Validations { for _, validation := range v.Validations {
const errInvalidCondition = "Invalid variable validation result" const errInvalidCondition = "Invalid variable validation result"
if validation.Condition == nil {
diags = append(diags, &hcl.Diagnostic{
Severity: hcl.DiagError,
Summary: "Invalid variable validation specification",
Detail: "validation requires a condition.",
Subject: validation.DeclRange.Ptr(),
EvalContext: hclCtx,
})
continue
}
result, moreDiags := validation.Condition.Value(hclCtx) result, moreDiags := validation.Condition.Value(hclCtx)
diags = append(diags, moreDiags...) diags = append(diags, moreDiags...)
if !result.IsKnown() { if !result.IsKnown() {