diff --git a/api/jobs_test.go b/api/jobs_test.go index 194470494..f14bd7b49 100644 --- a/api/jobs_test.go +++ b/api/jobs_test.go @@ -12,41 +12,34 @@ import ( "github.com/hashicorp/nomad/testutil" "github.com/kr/pretty" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" ) func TestJobs_Register(t *testing.T) { t.Parallel() + require := require.New(t) + c, s := makeClient(t, nil, nil) defer s.Stop() jobs := c.Jobs() // Listing jobs before registering returns nothing resp, qm, err := jobs.List(nil) - if err != nil { - t.Fatalf("err: %s", err) - } + require.Nil(err) assertQueryMeta(t, qm) - if n := len(resp); n != 0 { - t.Fatalf("expected 0 jobs, got: %d", n) - } + require.Emptyf(resp, "expected 0 jobs, got: %d", len(resp)) // Create a job and attempt to register it job := testJob() resp2, wm, err := jobs.Register(job, nil) - if err != nil { - t.Fatalf("err: %s", err) - } - if resp2 == nil || resp2.EvalID == "" { - t.Fatalf("missing eval id") - } + require.Nil(err) + require.NotNil(resp2) + require.NotEmpty(resp2.EvalID) assertWriteMeta(t, wm) // Query the jobs back out again - resp, qm, err = jobs.List(nil) - if err != nil { - t.Fatalf("err: %s", err) - } - assertQueryMeta(t, qm) + resp, _, err = jobs.List(nil) + require.Nil(err) // Check that we got the expected response if len(resp) != 1 || resp[0].ID != *job.ID { diff --git a/api/util_test.go b/api/util_test.go index 9aceee0bf..c6f99018e 100644 --- a/api/util_test.go +++ b/api/util_test.go @@ -7,6 +7,7 @@ import ( ) func assertQueryMeta(t *testing.T, qm *QueryMeta) { + t.Helper() if qm.LastIndex == 0 { t.Fatalf("bad index: %d", qm.LastIndex) } @@ -16,6 +17,7 @@ func assertQueryMeta(t *testing.T, qm *QueryMeta) { } func assertWriteMeta(t *testing.T, wm *WriteMeta) { + t.Helper() if wm.LastIndex == 0 { t.Fatalf("bad index: %d", wm.LastIndex) }