From 11472408e149d95dc084cb178cfb53d173704632 Mon Sep 17 00:00:00 2001 From: Phil Renaud Date: Thu, 12 May 2022 16:09:19 -0400 Subject: [PATCH] Visual diff tests seed-stabilized by default (#12965) * Seed-stabilization by default * Hide right-column of topology viz route * Remove seedless run from thee test:* suite * Related evals paths render too late * Vis:Hidden another topo viz unstable item --- ui/.percy.yml | 7 ++++++- ui/config/environment.js | 10 ++++++++++ ui/mirage/faker.js | 6 +++++- ui/package.json | 3 ++- 4 files changed, 23 insertions(+), 3 deletions(-) diff --git a/ui/.percy.yml b/ui/.percy.yml index f1d7dc7d5..ce3263988 100644 --- a/ui/.percy.yml +++ b/ui/.percy.yml @@ -2,6 +2,11 @@ version: 1 snapshot: # Hide high-variability data from Percy snapshots; helps make sure that randomized data doesn't cause a visual diff. percy-css: | - table td { + .topo-viz { + display: none; + } + .related-evaluations path, + .related-evaluations circle + .dashboard-metric { visibility: hidden; } \ No newline at end of file diff --git a/ui/config/environment.js b/ui/config/environment.js index 5e0e595b1..418a0dcfe 100644 --- a/ui/config/environment.js +++ b/ui/config/environment.js @@ -6,6 +6,12 @@ if (process.env.USE_MIRAGE) { USE_MIRAGE = process.env.USE_MIRAGE == 'true'; } +let USE_PERCY = true; + +if (process.env.USE_PERCY) { + USE_PERCY = process.env.USE_PERCY == 'true'; +} + module.exports = function (environment) { let ENV = { modulePrefix: 'nomad-ui', @@ -31,6 +37,10 @@ module.exports = function (environment) { mirageWithRegions: true, showStorybookLink: process.env.STORYBOOK_LINK === 'true', }, + + percy: { + enabled: USE_PERCY, + }, }; if (environment === 'development') { diff --git a/ui/mirage/faker.js b/ui/mirage/faker.js index 72653f193..87f781d41 100644 --- a/ui/mirage/faker.js +++ b/ui/mirage/faker.js @@ -3,7 +3,11 @@ import config from 'nomad-ui/config/environment'; const searchIncludesSeed = window.location.search.includes('faker-seed'); -if (config.environment !== 'test' || searchIncludesSeed) { +if ( + config.environment !== 'test' || + config.percy.enabled || + searchIncludesSeed +) { if (searchIncludesSeed) { const params = new URLSearchParams(window.location.search); const seed = parseInt(params.get('faker-seed')); diff --git a/ui/package.json b/ui/package.json index 5221ff80a..aea8df5d1 100644 --- a/ui/package.json +++ b/ui/package.json @@ -22,7 +22,8 @@ "test": "npm-run-all lint test:*", "test:ember": "percy exec -- ember test", "local:qunitdom": "ember test --server --query=dockcontainer", - "local:exam": "ember exam --server --load-balance --parallel=4" + "local:exam": "ember exam --server --load-balance --parallel=4", + "seedless-test": "USE_PERCY=false ember test" }, "husky": { "hooks": {