From 1b5eedc07ad4a55643eecd330d4684568ff9ae0a Mon Sep 17 00:00:00 2001 From: twunderlich-grapl <88346193+twunderlich-grapl@users.noreply.github.com> Date: Mon, 7 Nov 2022 14:14:57 -0500 Subject: [PATCH] Fix s3 example URLs in the artifacts docs (#15123) * Fix s3 URLs so that they work Unfortunately, s3 urls prefixed with https:// do NOT work with the underlying go-getter library. As such, this fixes the examples so that they are working examples that won't cause problems for people reading the docs. See discussion in https://github.com/hashicorp/nomad/issues/1113 circa 2016. * Use s3:// protocol schema for artifact examples Per the discussion in https://github.com/hashicorp/nomad/pull/15123, we're going to use the explicit s3 protocol in the examples since that is the likeliest to work in all scenarios --- website/content/docs/job-specification/artifact.mdx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/content/docs/job-specification/artifact.mdx b/website/content/docs/job-specification/artifact.mdx index 1daa4f9c8..a87b46e3d 100644 --- a/website/content/docs/job-specification/artifact.mdx +++ b/website/content/docs/job-specification/artifact.mdx @@ -210,7 +210,7 @@ This example uses path-based notation on a publicly-accessible bucket: ```hcl artifact { - source = "https://my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz" + source = "s3://my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz" } ``` @@ -240,7 +240,7 @@ Alternatively you can use virtual hosted style: ```hcl artifact { - source = "https://my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz" + source = "s3://my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz" } ```