From 3a88718b2ebd6ff85ad3d6c588d3257ec3cc629a Mon Sep 17 00:00:00 2001 From: Charlie Voiselle Date: Wed, 15 Nov 2017 18:20:59 +0000 Subject: [PATCH 1/2] Dropped loglevel for AWS fingerprinter env reads Certain environments use WARN for serious logging; however, it's very possible to have machines without some of the fingerprinted keys (public-ipv4 and public-hostname specifcally). Setting log level to INFO seems more consistent with this possibility. --- client/fingerprint/env_aws.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/fingerprint/env_aws.go b/client/fingerprint/env_aws.go index cd1ff888b..1f5874d10 100644 --- a/client/fingerprint/env_aws.go +++ b/client/fingerprint/env_aws.go @@ -108,7 +108,7 @@ func (f *EnvAWSFingerprint) Fingerprint(cfg *config.Config, node *structs.Node) for k, unique := range keys { res, err := client.Get(metadataURL + k) if res.StatusCode != http.StatusOK { - f.logger.Printf("[WARN]: fingerprint.env_aws: Could not read value for attribute %q", k) + f.logger.Printf("[INFO]: fingerprint.env_aws: Could not read value for attribute %q", k) continue } if err != nil { From 83aa6251c1df3b2d567062e5eca027d8fedbf56c Mon Sep 17 00:00:00 2001 From: Charlie Voiselle Date: Thu, 16 Nov 2017 14:13:03 -0500 Subject: [PATCH 2/2] Lowered to DEBUG from AD feedback --- client/fingerprint/env_aws.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/fingerprint/env_aws.go b/client/fingerprint/env_aws.go index 1f5874d10..b442f49ff 100644 --- a/client/fingerprint/env_aws.go +++ b/client/fingerprint/env_aws.go @@ -108,7 +108,7 @@ func (f *EnvAWSFingerprint) Fingerprint(cfg *config.Config, node *structs.Node) for k, unique := range keys { res, err := client.Get(metadataURL + k) if res.StatusCode != http.StatusOK { - f.logger.Printf("[INFO]: fingerprint.env_aws: Could not read value for attribute %q", k) + f.logger.Printf("[DEBUG]: fingerprint.env_aws: Could not read value for attribute %q", k) continue } if err != nil {