From 2d95f0602675e2172d40662a80a3675279e56ebb Mon Sep 17 00:00:00 2001 From: Karan Sharma Date: Mon, 6 Jun 2022 18:52:59 +0530 Subject: [PATCH] feat: Warn if bootstrap_expect is even number (#12961) --- command/agent/command.go | 3 +++ command/agent/command_test.go | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/command/agent/command.go b/command/agent/command.go index e6e3a4bdb..eef8e97d2 100644 --- a/command/agent/command.go +++ b/command/agent/command.go @@ -436,6 +436,9 @@ func (c *Command) IsValidConfig(config, cmdConfig *Config) bool { if config.Server.Enabled && config.Server.BootstrapExpect == 1 { c.Ui.Error("WARNING: Bootstrap mode enabled! Potentially unsafe operation.") } + if config.Server.Enabled && config.Server.BootstrapExpect%2 == 0 { + c.Ui.Error("WARNING: Number of bootstrap servers should ideally be set to an odd number.") + } } // ProtocolVersion has never been used. Warn if it is set as someone diff --git a/command/agent/command_test.go b/command/agent/command_test.go index 582d72e66..7d221966c 100644 --- a/command/agent/command_test.go +++ b/command/agent/command_test.go @@ -44,6 +44,10 @@ func TestCommand_Args(t *testing.T) { []string{"-data-dir=" + tmpDir, "-server", "-bootstrap-expect=1"}, "WARNING: Bootstrap mode enabled!", }, + { + []string{"-data-dir=" + tmpDir, "-server", "-bootstrap-expect=2"}, + "Number of bootstrap servers should ideally be set to an odd number", + }, { []string{"-server"}, "Must specify \"data_dir\" config option or \"data-dir\" CLI flag",