From 3052e7477adeb0ee967d192c347ad4def0a9275d Mon Sep 17 00:00:00 2001 From: Sean Chittenden Date: Wed, 8 Jun 2016 02:25:32 -0400 Subject: [PATCH] Move the start of the UniversalExecutor's consulSyncer to initialize once This should be handled via a sync.Once primative, but I don't want to unpack that atm. --- client/driver/executor/executor.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/driver/executor/executor.go b/client/driver/executor/executor.go index 0196650a8..8e22f0fb7 100644 --- a/client/driver/executor/executor.go +++ b/client/driver/executor/executor.go @@ -483,6 +483,7 @@ func (e *UniversalExecutor) SyncServices(ctx *ConsulContext) error { cs.SetServiceRegPrefix(consul.GenerateServicePrefix(e.ctx.AllocID, e.ctx.Task.Name)) cs.SetAddrFinder(e.ctx.Task.FindHostAndPortFor) e.consulSyncer = cs + go e.consulSyncer.Run() } if e.ctx != nil { syncerFn := func() error { @@ -492,7 +493,6 @@ func (e *UniversalExecutor) SyncServices(ctx *ConsulContext) error { } e.consulSyncer.AddPeriodicHandler(e.ctx.AllocID, syncerFn) } - go e.consulSyncer.Run() err := e.consulSyncer.SyncServices() // Attempt to register immediately return err }