From 37ad9476073d2215fbff06e80d9296ebc253c07f Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Wed, 15 Jul 2020 11:23:49 -0400 Subject: [PATCH] comment compat concern in fsm.go --- nomad/fsm.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/nomad/fsm.go b/nomad/fsm.go index ca043d4e8..98a65590b 100644 --- a/nomad/fsm.go +++ b/nomad/fsm.go @@ -555,6 +555,8 @@ func (n *nomadFSM) applyUpsertJob(buf []byte, index uint64) interface{} { } } + // COMPAT: Prior to Nomad 0.12.x evaluations were submitted in a separate Raft log, + // so this may be nil during server upgrades. if req.Eval != nil { req.Eval.JobModifyIndex = index if err := n.upsertEvals(index, []*structs.Evaluation{req.Eval}); err != nil { @@ -583,6 +585,8 @@ func (n *nomadFSM) applyDeregisterJob(buf []byte, index uint64) interface{} { return nil }) + // COMPAT: Prior to Nomad 0.12.x evaluations were submitted in a separate Raft log, + // so this may be nil during server upgrades. // always attempt upsert eval even if job deregister fail if req.Eval != nil { req.Eval.JobModifyIndex = index