From 422d62df8982857b8b40bc9431f5bca8ac2c776d Mon Sep 17 00:00:00 2001 From: Seth Hoenig Date: Thu, 2 May 2024 08:53:45 -0500 Subject: [PATCH] checklist: remove steps for openapi for rpc (#20515) --- contributing/checklist-rpc-endpoint.md | 9 --------- 1 file changed, 9 deletions(-) diff --git a/contributing/checklist-rpc-endpoint.md b/contributing/checklist-rpc-endpoint.md index 5fdd4129a..8aacee0c4 100644 --- a/contributing/checklist-rpc-endpoint.md +++ b/contributing/checklist-rpc-endpoint.md @@ -39,15 +39,6 @@ Prefer adding a new message to changing any existing RPC messages. * RPCs triggered by an internal process may not need support * Check ACLs as an optimization -* [ ] Endpoint added/updated in the [`nomad-openapi`](https://github.com/hashicorp/nomad-openapi) repository. - * New endpoints will need to be configured in that repository's `generator` package. - * Updated endpoints may require the `generator` configuration to change, especially if parameters or headers change. - * If the accepted or returned `struct` schema changes, the Nomad version references in `generator/go.mod` will need - to be updated. Once the version is updated, regenerate the spec and all all clients so that the new schema is - reflected in the spec and thus the generated models. - * If `QueryOptions`, `QueryMeta`, `WriteOptions`, or `WriteMeta` change, the `v1` framework will need to updated to - support the change. - * [ ] `nomad/core_sched.go` sends many RPCs * `ServersMeetMinimumVersion` asserts that the server cluster is upgraded, so use this to guard sending the new RPC, else send the old RPC