From 455e75492c9fc2f0c9417aa9c0ebab74f22d69fe Mon Sep 17 00:00:00 2001 From: Michael Schurter Date: Mon, 19 Nov 2018 15:12:30 -0500 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: nickethier --- drivers/docker/coordinator.go | 2 +- drivers/docker/driver.go | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/docker/coordinator.go b/drivers/docker/coordinator.go index b5190eaf1..457e14eb8 100644 --- a/drivers/docker/coordinator.go +++ b/drivers/docker/coordinator.go @@ -70,7 +70,7 @@ type dockerCoordinatorConfig struct { // logger is the logger the coordinator should use logger hclog.Logger - // cleanup marks whether images should be deleting when the reference count + // cleanup marks whether images should be deleted when the reference count // is zero cleanup bool diff --git a/drivers/docker/driver.go b/drivers/docker/driver.go index c2ff9868a..e998992ed 100644 --- a/drivers/docker/driver.go +++ b/drivers/docker/driver.go @@ -683,9 +683,7 @@ func (d *Driver) createContainerConfig(task *drivers.TaskConfig, driverConfig *T } hostConfig := &docker.HostConfig{ - // Convert MB to bytes. This is an absolute value. Memory: task.Resources.LinuxResources.MemoryLimitBytes, - // Convert Mhz to shares. This is a relative value. CPUShares: task.Resources.LinuxResources.CPUShares, // Binds are used to mount a host volume into the container. We mount a