From 46b012fd3bf892d91238fd98bc7c562d9756102e Mon Sep 17 00:00:00 2001
From: Preetha Appan <preetha@hashicorp.com>
Date: Sun, 31 Mar 2019 09:46:23 -0500
Subject: [PATCH] Add e2e test with raw exec job for verifying allocation
 resource stats

---
 e2e/allocstats/allocstats.go        | 88 +++++++++++++++++++++++++++++
 e2e/allocstats/input/raw_exec.nomad | 17 ++++++
 e2e/e2e_test.go                     |  1 +
 3 files changed, 106 insertions(+)
 create mode 100644 e2e/allocstats/allocstats.go
 create mode 100644 e2e/allocstats/input/raw_exec.nomad

diff --git a/e2e/allocstats/allocstats.go b/e2e/allocstats/allocstats.go
new file mode 100644
index 000000000..d6186d5b1
--- /dev/null
+++ b/e2e/allocstats/allocstats.go
@@ -0,0 +1,88 @@
+package allocstats
+
+import (
+	"github.com/hashicorp/nomad/e2e/framework"
+	"github.com/stretchr/testify/require"
+
+	"fmt"
+
+	"time"
+
+	"github.com/hashicorp/nomad/api"
+	"github.com/hashicorp/nomad/e2e/e2eutil"
+	"github.com/hashicorp/nomad/helper/uuid"
+	"github.com/hashicorp/nomad/testutil"
+)
+
+type BasicAllocStatsTest struct {
+	framework.TC
+	jobIds []string
+}
+
+func init() {
+	framework.AddSuites(&framework.TestSuite{
+		Component:   "AllocationStats",
+		CanRunLocal: true,
+		Cases: []framework.TestCase{
+			new(BasicAllocStatsTest),
+		},
+	})
+}
+
+func (tc *BasicAllocStatsTest) BeforeAll(f *framework.F) {
+	// Ensure cluster has leader before running tests
+	e2eutil.WaitForLeader(f.T(), tc.Nomad())
+	// Ensure that we have four client nodes in ready state
+	e2eutil.WaitForNodesReady(f.T(), tc.Nomad(), 1)
+}
+
+// TestResourceStats is an end to end test for resource utilization
+// This runs a raw exec job.
+// TODO(preetha) - add more test cases with more realistic resource utilization
+func (tc *BasicAllocStatsTest) TestResourceStats(f *framework.F) {
+	nomadClient := tc.Nomad()
+	uuid := uuid.Generate()
+	jobId := "allocstats" + uuid[0:8]
+	tc.jobIds = append(tc.jobIds, jobId)
+	allocs := e2eutil.RegisterAndWaitForAllocs(f.T(), nomadClient, "allocstats/input/raw_exec.nomad", jobId)
+
+	require := require.New(f.T())
+	require.Len(allocs, 1)
+
+	// Wait till alloc is running
+	allocID := allocs[0].ID
+	e2eutil.WaitForAllocRunning(f.T(), nomadClient, allocID)
+
+	// Get client for node the alloc is running on
+	nodeClient, err := nomadClient.GetNodeClient(allocs[0].NodeID, nil)
+	require.Nil(err)
+	allocsClient := nodeClient.Allocations()
+
+	// Verify allocation resource stats
+	// This job file should result in non zero CPU and Memory stats
+	testutil.WaitForResultRetries(500, func() (bool, error) {
+		time.Sleep(time.Millisecond * 100)
+		allocStatsResp, err := allocsClient.Stats(&api.Allocation{ID: allocID}, nil)
+		if err != nil {
+			return false, fmt.Errorf("unexpected error getting alloc stats: %v", err)
+		}
+		resourceUsage := allocStatsResp.ResourceUsage
+		cpuStatsValid := resourceUsage.CpuStats.TotalTicks > 0 && resourceUsage.CpuStats.Percent > 0
+		memStatsValid := resourceUsage.MemoryStats.RSS > 0
+		return cpuStatsValid && memStatsValid, fmt.Errorf("expected non zero resource usage, but was: %v", resourceUsage)
+	}, func(err error) {
+		f.T().Fatalf("invalid resource usage : %v", err)
+	})
+
+}
+
+func (tc *BasicAllocStatsTest) AfterEach(f *framework.F) {
+	nomadClient := tc.Nomad()
+	jobs := nomadClient.Jobs()
+	// Stop all jobs in test
+	for _, id := range tc.jobIds {
+		jobs.Deregister(id, true, nil)
+	}
+	// Garbage collect
+	nomadClient.System().GarbageCollect()
+}
diff --git a/e2e/allocstats/input/raw_exec.nomad b/e2e/allocstats/input/raw_exec.nomad
new file mode 100644
index 000000000..7c158c4d0
--- /dev/null
+++ b/e2e/allocstats/input/raw_exec.nomad
@@ -0,0 +1,17 @@
+job "test_raw" {
+  datacenters = ["dc1"]
+  type        = "service"
+
+  group "test" {
+   count = 1
+
+    task "test1" {
+      driver = "raw_exec"
+
+      config {
+        command = "bash"
+        args    = ["-c", "var=10000;while true; do a=$(awk -v x=$var 'BEGIN{print sqrt(x)}'); ((var++)); done" ]
+      } 
+    }
+}
+}
diff --git a/e2e/e2e_test.go b/e2e/e2e_test.go
index 5a3580955..8e1b58ee5 100644
--- a/e2e/e2e_test.go
+++ b/e2e/e2e_test.go
@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	_ "github.com/hashicorp/nomad/e2e/affinities"
+	_ "github.com/hashicorp/nomad/e2e/allocstats"
 	_ "github.com/hashicorp/nomad/e2e/clientstate"
 	_ "github.com/hashicorp/nomad/e2e/consul"
 	_ "github.com/hashicorp/nomad/e2e/consultemplate"