From 52411e40a2a642df2e5d99ee6af830eea6a97741 Mon Sep 17 00:00:00 2001
From: Michael Lange <dingoeatingfuzz@gmail.com>
Date: Tue, 10 Jul 2018 19:33:22 -0700
Subject: [PATCH] Use PageObject for job definition tests

---
 ui/tests/acceptance/job-definition-test.js | 7 ++++---
 ui/tests/pages/jobs/job/definition.js      | 7 +++++++
 2 files changed, 11 insertions(+), 3 deletions(-)
 create mode 100644 ui/tests/pages/jobs/job/definition.js

diff --git a/ui/tests/acceptance/job-definition-test.js b/ui/tests/acceptance/job-definition-test.js
index 5a5478fb8..65736df28 100644
--- a/ui/tests/acceptance/job-definition-test.js
+++ b/ui/tests/acceptance/job-definition-test.js
@@ -1,6 +1,7 @@
-import { findAll, currentURL, visit } from 'ember-native-dom-helpers';
+import { currentURL } from 'ember-native-dom-helpers';
 import { test } from 'qunit';
 import moduleForAcceptance from 'nomad-ui/tests/helpers/module-for-acceptance';
+import Definition from 'nomad-ui/tests/pages/jobs/job/definition';
 
 let job;
 
@@ -9,7 +10,7 @@ moduleForAcceptance('Acceptance | job definition', {
     server.create('node');
     server.create('job');
     job = server.db.jobs[0];
-    visit(`/jobs/${job.id}/definition`);
+    Definition.visit({ id: job.id });
   },
 });
 
@@ -18,7 +19,7 @@ test('visiting /jobs/:job_id/definition', function(assert) {
 });
 
 test('the job definition page contains a json viewer component', function(assert) {
-  assert.ok(findAll('[data-test-definition-view]').length, 'JSON viewer found');
+  assert.ok(Definition.jsonViewer, 'JSON viewer found');
 });
 
 test('the job definition page requests the job to display in an unmutated form', function(assert) {
diff --git a/ui/tests/pages/jobs/job/definition.js b/ui/tests/pages/jobs/job/definition.js
new file mode 100644
index 000000000..789d0cabc
--- /dev/null
+++ b/ui/tests/pages/jobs/job/definition.js
@@ -0,0 +1,7 @@
+import { create, isPresent, visitable } from 'ember-cli-page-object';
+
+export default create({
+  visit: visitable('/jobs/:id/definition'),
+
+  jsonViewer: isPresent('[data-test-definition-view]'),
+});