From 5bfa35ab81e09820c191d20fd8cda44bc64068c7 Mon Sep 17 00:00:00 2001 From: Preetha Appan Date: Wed, 8 May 2019 10:54:22 -0500 Subject: [PATCH] fix typo and add one more test scenario --- client/servers/manager.go | 2 +- client/servers/manager_test.go | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/client/servers/manager.go b/client/servers/manager.go index d65fd43e0..1cc61e8f4 100644 --- a/client/servers/manager.go +++ b/client/servers/manager.go @@ -204,7 +204,7 @@ func (m *Manager) SetServers(servers Servers) bool { // Determine if they are equal equal := m.serversAreEqual(servers) - // If server list is equal don't change the list and return immediatly + // If server list is equal don't change the list and return immediately // This prevents unnecessary shuffling of a failed server that was moved to the // bottom of the list if equal { diff --git a/client/servers/manager_test.go b/client/servers/manager_test.go index 8442d1e6f..1c13889a7 100644 --- a/client/servers/manager_test.go +++ b/client/servers/manager_test.go @@ -74,6 +74,11 @@ func TestServers_SetServers(t *testing.T) { require.False(m.SetServers([]*servers.Server{s1, s2})) after := m.GetServers() require.Equal(before, after) + + // Send a shuffled list, verify original order doesn't change + require.False(m.SetServers([]*servers.Server{s2, s1})) + afterShuffledInput := m.GetServers() + require.Equal(after, afterShuffledInput) } func TestServers_FindServer(t *testing.T) {