From 63dd00a2f348c6cd555e1a1d033d63b9fe7441d2 Mon Sep 17 00:00:00 2001 From: Diptanu Choudhury Date: Thu, 2 Jun 2016 17:14:15 -0400 Subject: [PATCH] Enqueing metrics only if they are not nil --- client/client.go | 6 +++--- client/task_runner.go | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/client/client.go b/client/client.go index b8a36d70c..340f28b86 100644 --- a/client/client.go +++ b/client/client.go @@ -1337,10 +1337,10 @@ func (c *Client) collectHostStats() { c.logger.Printf("[DEBUG] client: error fetching host resource usage stats: %v", err) continue } - c.resourceUsageLock.RLock() - c.resourceUsage.Enqueue(ru) - c.resourceUsageLock.RUnlock() if ru != nil { + c.resourceUsageLock.RLock() + c.resourceUsage.Enqueue(ru) + c.resourceUsageLock.RUnlock() c.emitStats(ru) } next.Reset(c.config.StatsCollectionInterval) diff --git a/client/task_runner.go b/client/task_runner.go index b16cfe5a1..a8a91f2dd 100644 --- a/client/task_runner.go +++ b/client/task_runner.go @@ -474,10 +474,10 @@ func (r *TaskRunner) collectResourceUsageStats() { if err != nil { r.logger.Printf("[DEBUG] client: error fetching stats of task %v: %v", r.task.Name, err) } - r.resourceUsageLock.Lock() - r.resourceUsage.Enqueue(ru) - r.resourceUsageLock.Unlock() if ru != nil { + r.resourceUsageLock.Lock() + r.resourceUsage.Enqueue(ru) + r.resourceUsageLock.Unlock() r.emitStats(ru) } next.Reset(r.config.StatsCollectionInterval)