use comment ignores (#9448)

Use targetted ignore comments for the cases where we are bound by
backward compatibility.

I've left some file based linters, especially when the file is riddled
with linter voilations (e.g. enum names), or if it's a property of the
file (e.g. package and file names).

I encountered an odd behavior related to RPC_REQUEST_RESPONSE_UNIQUE and
RPC_REQUEST_STANDARD_NAME.  Apparently, if they target a `stream` type,
we must separate them into separate lines so that the ignore comment
targets the type specifically.
This commit is contained in:
Mahmood Ali
2020-11-25 16:03:01 -05:00
committed by GitHub
parent 101ae734e8
commit 6d57a1c69b
10 changed files with 35 additions and 22 deletions

View File

@@ -7,9 +7,8 @@ build:
lint:
use:
- DEFAULT
allow_comment_ignores: true
ignore_only:
ENUM_NO_ALLOW_ALIAS:
- plugins/drivers/proto/driver.proto
ENUM_VALUE_PREFIX:
- plugins/base/proto/base.proto
- plugins/drivers/proto/driver.proto
@@ -27,11 +26,6 @@ lint:
- plugins/shared/structs/proto/attribute.proto
- plugins/shared/structs/proto/recoverable_error.proto
- plugins/shared/structs/proto/stats.proto
FIELD_LOWER_SNAKE_CASE:
- plugins/base/proto/base.proto
- plugins/device/proto/device.proto
- plugins/drivers/proto/driver.proto
- plugins/shared/hclspec/hcl_spec.proto
PACKAGE_VERSION_SUFFIX:
- client/logmon/proto/logmon.proto
- drivers/docker/docklog/proto/docker_logger.proto
@@ -43,14 +37,6 @@ lint:
- plugins/shared/structs/proto/attribute.proto
- plugins/shared/structs/proto/recoverable_error.proto
- plugins/shared/structs/proto/stats.proto
RPC_REQUEST_RESPONSE_UNIQUE:
- drivers/shared/executor/proto/executor.proto
- plugins/drivers/proto/driver.proto
RPC_REQUEST_STANDARD_NAME:
- drivers/shared/executor/proto/executor.proto
RPC_RESPONSE_STANDARD_NAME:
- drivers/shared/executor/proto/executor.proto
- plugins/drivers/proto/driver.proto
SERVICE_SUFFIX:
- client/logmon/proto/logmon.proto
- drivers/docker/docklog/proto/docker_logger.proto