From 7820df53ca2eb0839bb1a3de842a5c8071b9767a Mon Sep 17 00:00:00 2001 From: Phil Renaud Date: Tue, 5 Mar 2024 08:49:58 -0500 Subject: [PATCH] [ui]] Percy Stabilization (#20061) * Some actions and inline-chart stabilization * Weird little semicolon, are you my undoing? --- .../allocations/allocation/task/index.hbs | 2 +- ui/tests/acceptance/actions-test.js | 27 ++++++++++++++++--- ui/tests/acceptance/job-status-panel-test.js | 3 +++ 3 files changed, 28 insertions(+), 4 deletions(-) diff --git a/ui/app/templates/allocations/allocation/task/index.hbs b/ui/app/templates/allocations/allocation/task/index.hbs index 5b4221061..abeade2fe 100644 --- a/ui/app/templates/allocations/allocation/task/index.hbs +++ b/ui/app/templates/allocations/allocation/task/index.hbs @@ -223,7 +223,7 @@
diff --git a/ui/tests/acceptance/actions-test.js b/ui/tests/acceptance/actions-test.js index 0b861da8f..fa5b8c58d 100644 --- a/ui/tests/acceptance/actions-test.js +++ b/ui/tests/acceptance/actions-test.js @@ -162,7 +162,11 @@ module('Acceptance | actions', function (hooks) { "The first action's dropdown subcontent exists" ); - await percySnapshot(assert); + await percySnapshot(assert, { + percyCSS: ` + .allocation-row td { display: none; } + `, + }); // run on a random alloc await Actions.titleActions.multiAllocActions[0].subActions[0].click(); @@ -333,11 +337,28 @@ module('Acceptance | actions', function (hooks) { Actions.flyout.actions.isPresent, 'Flyout has actions dropdown on task page' ); - await percySnapshot(assert); + await percySnapshot(assert, { + percyCSS: ` + g.tick { visibility: hidden; }; + .recent-events-table td { + display: none; + } + .inline-definitions { visibility: hidden; } + `, + }); // Clear finished actions and take a snapshot await click('button[data-test-clear-finished-actions]'); - await percySnapshot('Cleared actions/flyout open state'); + + await percySnapshot('Cleared actions/flyout open state', { + percyCSS: ` + g.tick { visibility: hidden; } + .recent-events-table td { + display: none; + } + .inline-definitions { visibility: hidden; } + `, + }); // Close flyout; global button is no longer present await Actions.flyout.close(); diff --git a/ui/tests/acceptance/job-status-panel-test.js b/ui/tests/acceptance/job-status-panel-test.js index 9ca0e6198..be98f631f 100644 --- a/ui/tests/acceptance/job-status-panel-test.js +++ b/ui/tests/acceptance/job-status-panel-test.js @@ -530,6 +530,7 @@ module('Acceptance | job status panel', function (hooks) { { percyCSS: ` .allocation-row td { display: none; } + .inline-chart { visibility: hidden; } `, } ); @@ -545,6 +546,7 @@ module('Acceptance | job status panel', function (hooks) { { percyCSS: ` .allocation-row td { display: none; } + .inline-chart { visibility: hidden; } `, } ); @@ -588,6 +590,7 @@ module('Acceptance | job status panel', function (hooks) { { percyCSS: ` .allocation-row td { display: none; } + .inline-chart { visibility: hidden; } `, } );