kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-07 02:45:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

refactor: volume request modes to be generic between DHV/CSI (#24896)

Browse Source 
When we implemented CSI, the types of the fields for access mode and attachment
mode on volume requests were defined with a prefix "CSI". This gets confusing
now that we have dynamic host volumes using the same fields. Fortunately the
original was a typedef on string, and the Go API in the `api` package just uses
strings directly, so we can change the name of the type without breaking
backwards compatibility for the msgpack wire format.

Update the names to `VolumeAccessMode` and `VolumeAttachmentMode`. Keep the CSI
and DHV specific value constant names for these fields (they aren't currently
1:1), so that we can easily differentiate in a given bit of code which values
are valid.

Ref: https://github.com/hashicorp/nomad/pull/24881#discussion_r1920702890
This commit is contained in:
Tim Gross
2025-01-24 10:37:48 -05:00
committed by GitHub
parent b4d71f6693
commit 7add04eb0f
12 changed files with 76 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/pluginmanager/csimanager/interface.go
View File

@@ -29,8 +29,8 @@ func (mi *MountInfo) Copy() *MountInfo {
type UsageOptions struct {
ReadOnly bool
AttachmentMode structs.CSIVolumeAttachmentMode
AccessMode structs.CSIVolumeAccessMode
AttachmentMode structs.VolumeAttachmentMode
AccessMode structs.VolumeAccessMode
MountOptions *structs.CSIMountOptions
}