From 7d3e21fcb3c14be7c581033ee51d5e86a6d321cb Mon Sep 17 00:00:00 2001 From: Chris Bednarski Date: Fri, 11 Dec 2015 15:20:32 -0800 Subject: [PATCH] Add lint check for log.Printf usage --- Makefile | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3f8362668..82d9df435 100644 --- a/Makefile +++ b/Makefile @@ -48,8 +48,12 @@ vet: @echo "--> Running go tool vet $(VETARGS) ." @go tool vet $(VETARGS) . ; if [ $$? -eq 1 ]; then \ echo ""; \ - echo "Vet found suspicious constructs. Please check the reported constructs"; \ - echo "and fix them if necessary before submitting the code for reviewal."; \ + echo "[LINT] Vet found suspicious constructs. Please check the reported constructs"; \ + echo "and fix them if necessary before submitting the code for review."; \ + fi + + @git grep -n `echo "log"".Print"` ; if [ $$? -eq 0 ]; then \ + echo "[LINT] Found "log"".Printf" calls. These should use Nomad's logger instead."; \ fi web: