From 825c2ffca98bc22d9677218b2b9374ca1953cf0c Mon Sep 17 00:00:00 2001 From: Nick Ethier Date: Wed, 14 Nov 2018 16:04:03 -0500 Subject: [PATCH] nomad: only lookup job is disable_dispatched_job_summary_metrics is set --- nomad/leader.go | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/nomad/leader.go b/nomad/leader.go index c77b53876..83faa99a1 100644 --- a/nomad/leader.go +++ b/nomad/leader.go @@ -624,12 +624,15 @@ func (s *Server) publishJobSummaryMetrics(stopCh chan struct{}) { break } summary := raw.(*structs.JobSummary) - job, err := state.JobByID(ws, summary.Namespace, summary.JobID) - if err != nil { - s.logger.Printf("[ERR] nomad: failed to lookup job for summary: %v", err) - } - if s.config.DisableDispatchedJobSummaryMetrics && job.Dispatched { - continue + if s.config.DisableDispatchedJobSummaryMetrics { + job, err := state.JobByID(ws, summary.Namespace, summary.JobID) + if err != nil { + s.logger.Printf("[ERR] nomad: failed to lookup job for summary: %v", err) + continue + } + if job.Dispatched { + continue + } } s.iterateJobSummaryMetrics(summary) }