From a921c21c8ea2d4c9ef7852e4f6c51d14e5241e4f Mon Sep 17 00:00:00 2001 From: Danielle Lancashire Date: Fri, 16 Aug 2019 15:01:50 +0200 Subject: [PATCH] docker: Fix issue where an exec may never timeout --- drivers/docker/driver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/docker/driver.go b/drivers/docker/driver.go index 4242db4aa..20b27626b 100644 --- a/drivers/docker/driver.go +++ b/drivers/docker/driver.go @@ -1323,7 +1323,7 @@ func (d *Driver) ExecTaskStreaming(ctx context.Context, taskID string, opts *dri const execTerminatingTimeout = 3 * time.Second start := time.Now() var res *docker.ExecInspect - for res == nil || res.Running || time.Since(start) > execTerminatingTimeout { + for (res == nil || res.Running) && time.Since(start) <= execTerminatingTimeout { res, err = client.InspectExec(exec.ID) if err != nil { return nil, fmt.Errorf("failed to inspect exec result: %v", err)