From 8b8e21dc0eefa438b141941adc1d8bae480f51e3 Mon Sep 17 00:00:00 2001
From: Piotr Kazmierczak <470696+pkazmierczak@users.noreply.github.com>
Date: Thu, 28 Aug 2025 17:29:13 +0200
Subject: [PATCH] scheduler: check if system job deploy is complete before
 other guards (#26651)

---
 scheduler/reconciler/reconcile_node.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scheduler/reconciler/reconcile_node.go b/scheduler/reconciler/reconcile_node.go
index 302967bcd..6f97de0a3 100644
--- a/scheduler/reconciler/reconcile_node.go
+++ b/scheduler/reconciler/reconcile_node.go
@@ -428,7 +428,9 @@ func (nr *NodeReconciler) computeForNode(
 			result.Place = append(result.Place, allocTuple)
 		}
 
+		// check if deployment is place ready or complete
 		deploymentPlaceReady := !deploymentPaused && !deploymentFailed
+		deploymentComplete = nr.isDeploymentComplete(tg.Name, result)
 
 		// in this case there's nothing to do
 		if existingDeployment || tg.Update.IsEmpty() || (dstate.DesiredTotal == 0 && dstate.DesiredCanaries == 0) || !deploymentPlaceReady {
@@ -444,8 +446,6 @@ func (nr *NodeReconciler) computeForNode(
 		if maxParallel != 0 {
 			nr.createDeployment(job, tg, dstate, len(result.Update), liveAllocs)
 		}
-
-		deploymentComplete = nr.isDeploymentComplete(tg.Name, result)
 	}
 
 	return result, deploymentComplete