From 8c2ce12ef9f4c1382b4b44bbd0f103f5d3fe1757 Mon Sep 17 00:00:00 2001
From: Jai Bhagat <jaybhagat841@gmail.com>
Date: Mon, 3 Jan 2022 11:13:18 -0500
Subject: [PATCH] refactor:  compute jobClientStatus in summary backing class
 component

---
 .../job-page/parts/job-client-status-summary.js       | 11 ++++++++++-
 .../components/job-page/parameterized-child.hbs       |  5 +----
 .../job-page/parts/job-client-status-summary.hbs      |  3 ++-
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/ui/app/components/job-page/parts/job-client-status-summary.js b/ui/app/components/job-page/parts/job-client-status-summary.js
index 6625e6705..e583aae24 100644
--- a/ui/app/components/job-page/parts/job-client-status-summary.js
+++ b/ui/app/components/job-page/parts/job-client-status-summary.js
@@ -1,13 +1,22 @@
 import Component from '@ember/component';
 import { action, computed } from '@ember/object';
+import { inject as service } from '@ember/service';
 import { classNames } from '@ember-decorators/component';
 import classic from 'ember-classic-decorator';
+import jobClientStatus from 'nomad-ui/utils/properties/job-client-status';
 
 @classic
 @classNames('boxed-section')
 export default class JobClientStatusSummary extends Component {
+  @service store;
+
+  @jobClientStatus('nodes', 'job') jobClientStatus;
+
+  get nodes() {
+    return this.store.peekAll('node');
+  }
+
   job = null;
-  jobClientStatus = null;
   gotoClients() {}
 
   @computed
diff --git a/ui/app/templates/components/job-page/parameterized-child.hbs b/ui/app/templates/components/job-page/parameterized-child.hbs
index 30e4beb77..1029bbab7 100644
--- a/ui/app/templates/components/job-page/parameterized-child.hbs
+++ b/ui/app/templates/components/job-page/parameterized-child.hbs
@@ -18,10 +18,7 @@
         </span>
       </:before-namespace>
     </jobPage.ui.StatsBox>
-    <jobPage.ui.JobClientStatusSummary
-      @gotoClients={{this.gotoClients}}
-      @jobClientStatus={{this.jobClientStatus}}
-    />
+    <jobPage.ui.JobClientStatusSummary @gotoClients={{this.gotoClients}} />
     <jobPage.ui.Summary @forceCollapsed={{@job.hasClientStatus}} />
     <jobPage.ui.PlacementFailures />
     <jobPage.ui.TaskGroups
diff --git a/ui/app/templates/components/job-page/parts/job-client-status-summary.hbs b/ui/app/templates/components/job-page/parts/job-client-status-summary.hbs
index b1bf9661d..9d79deae0 100644
--- a/ui/app/templates/components/job-page/parts/job-client-status-summary.hbs
+++ b/ui/app/templates/components/job-page/parts/job-client-status-summary.hbs
@@ -1,4 +1,4 @@
-{{#if @job.hasClientStatus}}
+{{#if this.job.hasClientStatus}}
   <ListAccordion
     data-test-job-summary
     @source={{array this.job}}
@@ -35,6 +35,7 @@
       </div>
     </a.head>
     <a.body>
+      {{debugger}}
       <JobClientStatusBar
         @onSliceClick={{action this.onSliceClick}}
         @job={{this.job}}