From 9d190a643ede393042c0bc0a336a8ace50ef3a93 Mon Sep 17 00:00:00 2001 From: Buck Doyle Date: Tue, 28 Jul 2020 12:59:14 -0500 Subject: [PATCH] Add acceptance test accessibility auditing and fixes (#8455) This introduces ember-a11y-testing to acceptance tests via a helper wrapper that allows us to globally ignore rules that we can address separately. It also adds fixes for the aXe rules that were failing. --- ui/app/components/stepper-input.js | 4 - ui/app/templates/components/agent-monitor.hbs | 2 +- ui/app/templates/components/copy-button.hbs | 1 + ui/app/templates/components/gauge-chart.hbs | 2 +- ui/app/templates/components/global-header.hbs | 6 +- ui/app/templates/components/job-editor.hbs | 2 + ui/app/templates/components/json-viewer.hbs | 1 + .../templates/components/list-pagination.hbs | 8 +- .../components/list-pagination/list-pager.hbs | 2 +- ui/app/templates/components/search-box.hbs | 3 +- ui/app/templates/components/stepper-input.hbs | 5 +- ui/app/templates/components/task-log.hbs | 2 +- ui/app/templates/settings/tokens.hbs | 4 +- ui/package.json | 4 + ui/tests/acceptance/allocation-detail-test.js | 6 + .../acceptance/application-errors-test.js | 9 ++ ui/tests/acceptance/behaviors/fs.js | 7 + ui/tests/acceptance/client-detail-test.js | 7 + ui/tests/acceptance/client-monitor-test.js | 7 + ui/tests/acceptance/clients-list-test.js | 12 ++ ui/tests/acceptance/exec-test.js | 7 + ui/tests/acceptance/job-allocations-test.js | 10 ++ ui/tests/acceptance/job-definition-test.js | 6 + ui/tests/acceptance/job-deployments-test.js | 7 + ui/tests/acceptance/job-detail-test.js | 8 ++ ui/tests/acceptance/job-evaluations-test.js | 6 + ui/tests/acceptance/job-run-test.js | 7 + ui/tests/acceptance/job-versions-test.js | 6 + ui/tests/acceptance/jobs-list-test.js | 7 + ui/tests/acceptance/namespaces-test.js | 7 + .../acceptance/plugin-allocations-test.js | 14 ++ ui/tests/acceptance/plugin-detail-test.js | 7 + ui/tests/acceptance/plugins-list-test.js | 7 + ui/tests/acceptance/regions-test.js | 7 + ui/tests/acceptance/server-detail-test.js | 6 + ui/tests/acceptance/server-monitor-test.js | 7 + ui/tests/acceptance/servers-list-test.js | 8 ++ ui/tests/acceptance/task-detail-test.js | 6 + ui/tests/acceptance/task-group-detail-test.js | 7 + ui/tests/acceptance/task-logs-test.js | 6 + ui/tests/acceptance/token-test.js | 7 + ui/tests/acceptance/volume-detail-test.js | 7 + ui/tests/acceptance/volumes-list-test.js | 7 + ui/tests/helpers/a11y-audit.js | 16 +++ ui/yarn.lock | 136 +++++++++++------- 45 files changed, 341 insertions(+), 72 deletions(-) create mode 100644 ui/tests/helpers/a11y-audit.js diff --git a/ui/app/components/stepper-input.js b/ui/app/components/stepper-input.js index 933cb4115..8509c3534 100644 --- a/ui/app/components/stepper-input.js +++ b/ui/app/components/stepper-input.js @@ -61,10 +61,6 @@ export default class StepperInput extends Component { e.target.select(); } - @action focusInput() { - this.element.querySelector('.stepper-input-input').focus(); - } - update(value) { debounce(this, sendUpdateAction, value, this.debounce); } diff --git a/ui/app/templates/components/agent-monitor.hbs b/ui/app/templates/components/agent-monitor.hbs index d7aeba09f..f462c9ad8 100644 --- a/ui/app/templates/components/agent-monitor.hbs +++ b/ui/app/templates/components/agent-monitor.hbs @@ -10,7 +10,7 @@ @onChange={{action this.setLevel}} as |level|> Level: {{capitalize level}} - diff --git a/ui/app/templates/components/copy-button.hbs b/ui/app/templates/components/copy-button.hbs index 28287ff79..4246a2d71 100644 --- a/ui/app/templates/components/copy-button.hbs +++ b/ui/app/templates/components/copy-button.hbs @@ -16,6 +16,7 @@ @clipboardText={{this.clipboardText}} @success={{perform this.indicateSuccess}} @error={{action (mut this.state) "error"}} + @title="Copy" > {{x-icon 'copy-action'}} diff --git a/ui/app/templates/components/gauge-chart.hbs b/ui/app/templates/components/gauge-chart.hbs index 3c3ce6e5a..700e50070 100644 --- a/ui/app/templates/components/gauge-chart.hbs +++ b/ui/app/templates/components/gauge-chart.hbs @@ -1,4 +1,4 @@ - + diff --git a/ui/app/templates/components/global-header.hbs b/ui/app/templates/components/global-header.hbs index cd8451e9e..5a6b50e4f 100644 --- a/ui/app/templates/components/global-header.hbs +++ b/ui/app/templates/components/global-header.hbs @@ -1,9 +1,9 @@ - @@ -19,7 +19,7 @@ -