From bb6c86d2a4c0d59c26570b837500c4cc06dcc81b Mon Sep 17 00:00:00 2001
From: Phil Renaud <phil.renaud@hashicorp.com>
Date: Wed, 15 Nov 2023 10:05:12 -0500
Subject: [PATCH] Shows the client/node name alongside alloc short ID if the
 job is sys/sysbatch (#19051)

---
 .changelog/19051.txt                            |  3 +++
 .../job-status/individual-allocation.hbs        |  5 +++--
 .../job-status/individual-allocation.js         | 17 +++++++++++++++++
 3 files changed, 23 insertions(+), 2 deletions(-)
 create mode 100644 .changelog/19051.txt
 create mode 100644 ui/app/components/job-status/individual-allocation.js

diff --git a/.changelog/19051.txt b/.changelog/19051.txt
new file mode 100644
index 000000000..a259edf28
--- /dev/null
+++ b/.changelog/19051.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+ui: for system and sysbatch jobs, now show client name on hover in job panel
+```
diff --git a/ui/app/components/job-status/individual-allocation.hbs b/ui/app/components/job-status/individual-allocation.hbs
index aed881622..323645b57 100644
--- a/ui/app/components/job-status/individual-allocation.hbs
+++ b/ui/app/components/job-status/individual-allocation.hbs
@@ -2,8 +2,9 @@
   Copyright (c) HashiCorp, Inc.
   SPDX-License-Identifier: BUSL-1.1
 ~}}
-
-<Hds::TooltipButton @text="{{get @allocation "shortId"}}" aria-label="Allocation" @extraTippyOptions={{hash trigger=(if (eq @status "unplaced") "manual")}}>
+<Hds::TooltipButton
+  @text="{{if this.showClient (concat this.nodeName " - " (get @allocation "shortId")) (get @allocation "shortId")}}"
+aria-label="Allocation" @extraTippyOptions={{hash trigger=(if (eq @status "unplaced") "manual")}}>
   <ConditionalLinkTo
     @condition={{not (eq @status "unplaced")}}
     @route="allocations.allocation"
diff --git a/ui/app/components/job-status/individual-allocation.js b/ui/app/components/job-status/individual-allocation.js
new file mode 100644
index 000000000..a0d78a2bd
--- /dev/null
+++ b/ui/app/components/job-status/individual-allocation.js
@@ -0,0 +1,17 @@
+/**
+ * Copyright (c) HashiCorp, Inc.
+ * SPDX-License-Identifier: BUSL-1.1
+ */
+
+// @ts-check
+import Component from '@glimmer/component';
+import { alias } from '@ember/object/computed';
+
+export default class JobStatusIndividualAllocationComponent extends Component {
+  @alias('args.allocation.job.type') jobType;
+  @alias('args.allocation.node.name') nodeName;
+
+  get showClient() {
+    return this.jobType === 'system' || this.jobType === 'sysbatch';
+  }
+}