From bbdceca358978b7c9b048a4e633b8d756a0b8aa2 Mon Sep 17 00:00:00 2001 From: Alex Dadgar Date: Fri, 9 Oct 2015 11:29:59 -0700 Subject: [PATCH] Better parsing of raw_exec option and updated docs --- client/driver/raw_exec.go | 8 ++++++-- website/source/docs/drivers/raw_exec.html.md | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/client/driver/raw_exec.go b/client/driver/raw_exec.go index ae8e6ab63..cdc41e676 100644 --- a/client/driver/raw_exec.go +++ b/client/driver/raw_exec.go @@ -46,8 +46,12 @@ func NewRawExecDriver(ctx *DriverContext) Driver { func (d *RawExecDriver) Fingerprint(cfg *config.Config, node *structs.Node) (bool, error) { // Check that the user has explicitly enabled this executor. - enabled := strings.ToLower(cfg.ReadDefault(rawExecConfigOption, "false")) - if enabled == "1" || enabled == "true" { + enabled, err := strconv.ParseBool(cfg.ReadDefault(rawExecConfigOption, "false")) + if err != nil { + return false, fmt.Errorf("Failed to parse %v option: %v", rawExecConfigOption, err) + } + + if enabled { d.logger.Printf("[WARN] driver.raw_exec: raw exec is enabled. Only enable if needed") node.Attributes["driver.raw_exec"] = "1" return true, nil diff --git a/website/source/docs/drivers/raw_exec.html.md b/website/source/docs/drivers/raw_exec.html.md index fdbcb956c..35b0c95bf 100644 --- a/website/source/docs/drivers/raw_exec.html.md +++ b/website/source/docs/drivers/raw_exec.html.md @@ -11,8 +11,8 @@ description: |- Name: `raw_exec` The `raw_exec` driver is used to execute a command for a task without any -resource isolation. As such, it should be used with extreme care and is disabled -by default. +isolation. Further, the task is started as the same user as the Nomad process. +As such, it should be used with extreme care and is disabled by default. ## Task Configuration