From bdf023afaa75bfe8082e946b965ee04d65e1712f Mon Sep 17 00:00:00 2001 From: James Rasell Date: Fri, 3 Oct 2025 07:30:49 +0100 Subject: [PATCH] server: Log contextual server parts when Serf node joins or leaves. (#26848) When a Nomad server joined or left the cluster via Serf, we emit a log message to indicate this. It was previously using a single kv context to detail the server name, dc, and address which likely was created before the switch to hclog and use of contextual logging. This change splits the log message, so that each server part is a kv entry, which will be easier to parse with log collecting tools. --- nomad/serf.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nomad/serf.go b/nomad/serf.go index 9d5534a6d..05c635f5e 100644 --- a/nomad/serf.go +++ b/nomad/serf.go @@ -59,7 +59,7 @@ func (s *Server) nodeJoin(me serf.MemberEvent) { s.logger.Warn("non-server in gossip pool", "member", m.Name) continue } - s.logger.Info("adding server", "server", parts) + s.logger.Info("adding server", "name", parts.Name, "addr", parts.Addr, "dc", parts.Datacenter) // Check if this server is known found := false @@ -243,7 +243,7 @@ func (s *Server) nodeFailed(me serf.MemberEvent) { if !ok { continue } - s.logger.Info("removing server", "server", parts) + s.logger.Info("removing server", "name", parts.Name, "addr", parts.Addr, "dc", parts.Datacenter) // Remove the server if known s.peerLock.Lock()