From d75aa8f99a4792b5c42c2e2b2d98519f7c4eb55b Mon Sep 17 00:00:00 2001 From: Michael Lange Date: Wed, 7 Nov 2018 16:08:26 -0800 Subject: [PATCH] Fix a bug where with-watchers wasn't bubbling the willTransition event The impact was the application error was no longer being nulled out, causing the application error to continue to be shown after transitioning. This never happened in apps since it's not possible to transition away from the error screen. --- ui/app/mixins/with-watchers.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/app/mixins/with-watchers.js b/ui/app/mixins/with-watchers.js index c9690dbdf..ef3337866 100644 --- a/ui/app/mixins/with-watchers.js +++ b/ui/app/mixins/with-watchers.js @@ -33,6 +33,9 @@ export default Mixin.create(WithVisibilityDetection, { actions: { willTransition() { this.cancelAllWatchers(); + + // Bubble the action up to the application route + return true; }, }, });