client: Remove created directory when mkdir plugin fails to chown. (#26194)

The mkdir plugin creates the directory and then chowns it. In the
event the chown command fails, we should attempt to remove the
directory. Without this, we leave directories on the client in
partial failure situations.

client/hostvolumemanager/host_volume_plugin.go

@@ -138,6 +138,15 @@ func (p *HostVolumePluginMkdir) Create(_ context.Context,
 	// Chown note: A uid or gid of -1 means to not change that value.
 	if err = os.Chown(path, params.Uid, params.Gid); err != nil {
 		log.Error("error changing owner/group", "error", err, "uid", params.Uid, "gid", params.Gid)
+
+		// Failing to change ownership is fatal for this plugin. Since we have
+		// already created the directory, we should attempt to clean it.
+		// Otherwise, the operator must do this manually.
+		if err := os.RemoveAll(path); err != nil {
+			log.Error("failed to remove directory after create failure",
+				"error", err)
+		}
+
 		return nil, fmt.Errorf("error changing owner/group: %w", err)
 	}