From 41bf4e8ecf3a1c029a815ba773d6cf81cd174532 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Fri, 22 Nov 2019 13:22:14 -0500 Subject: [PATCH] docs: address more GH-6762 review comments Incorporate suggestions in https://github.com/hashicorp/nomad/pull/6762#pullrequestreview-321716747 [ci skip] --- website/source/docs/drivers/docker.html.md | 10 +++++----- website/source/guides/upgrade/upgrade-specific.html.md | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/website/source/docs/drivers/docker.html.md b/website/source/docs/drivers/docker.html.md index 6adadd745..1ca370818 100644 --- a/website/source/docs/drivers/docker.html.md +++ b/website/source/docs/drivers/docker.html.md @@ -922,8 +922,8 @@ containers that Nomad starts yet does not manage or track. Though rare, they lead to unexpectedly running services, potentially with stale versions. When Docker daemon becomes unavailable as Nomad starts a task, it is possible -for Docker to successfully start the container and fails the API call with 500 -error code. In such cases, Nomad retries and eventually aims to kill such +for Docker to successfully start the container but return a 500 error code from +the API call. In such cases, Nomad retries and eventually aims to kill such containers. However, if the Docker Engine remains unhealthy, subsequent retries and stop attempts may still fail, and the started container becomes a dangling container that Nomad no longer manages. @@ -933,9 +933,9 @@ containers with a `com.hashicorp.nomad.allocation_id` label, or match Nomad's conventions for naming and bind-mounts (i.e. `/alloc`, `/secrets`, `local`). Containers that don't match Nomad container patterns are left untouched. -Operators can run the reaper in a dry run mode, where it only logs dangling -container ids without killing them, or simply disable it through -the `gc.dangling_containers` config stanza. +Operators can run the reaper in a dry-run mode, where it only logs dangling +container ids without killing them, or disable it by setting the +`gc.dangling_containers` config stanza. ### Docker for Windows diff --git a/website/source/guides/upgrade/upgrade-specific.html.md b/website/source/guides/upgrade/upgrade-specific.html.md index 9afb6d291..e626a37c2 100644 --- a/website/source/guides/upgrade/upgrade-specific.html.md +++ b/website/source/guides/upgrade/upgrade-specific.html.md @@ -21,7 +21,7 @@ Nomad 0.10.2 addresses an issue occurring in heavily loaded clients, where containers are started without being properly managed by Nomad. Nomad 0.10.2 introduced a reaper that detects and kills such containers. -Operators may opt to run reaper in a dry mode or disabling it through a client config. +Operators may opt to run reaper in a dry-mode or disabling it through a client config. For more information, see [Docker Dangling containers][dangling-containers].