From ee8cf15e733454ee867d308090be7d57f0ec5d6e Mon Sep 17 00:00:00 2001 From: Phil Renaud Date: Wed, 14 Jun 2023 12:45:36 -0400 Subject: [PATCH] [ui] Job status panel: tooltips on individual allocs (#17514) * Tooltip on individual allocs in the panel * Isolate allocation cells to their own component * Tipsy trigger * Aria label for failed-or-lost tooltips * Buildfix * Try adding percy exec back to exam run --- .../job-status/allocation-status-block.hbs | 27 +-- .../job-status/allocation-status-row.hbs | 29 +-- .../components/job-status/failed-or-lost.hbs | 16 +- .../job-status/individual-allocation.hbs | 29 +++ ui/app/styles/components.scss | 2 +- .../styles/components/job-status-panel.scss | 2 +- .../{tooltip.scss => tooltip_legacy.scss} | 0 ui/package.json | 6 +- ui/yarn.lock | 191 ++++++++++++++---- 9 files changed, 199 insertions(+), 103 deletions(-) create mode 100644 ui/app/components/job-status/individual-allocation.hbs rename ui/app/styles/components/{tooltip.scss => tooltip_legacy.scss} (100%) diff --git a/ui/app/components/job-status/allocation-status-block.hbs b/ui/app/components/job-status/allocation-status-block.hbs index 36a4b8c0e..fc51e8d60 100644 --- a/ui/app/components/job-status/allocation-status-block.hbs +++ b/ui/app/components/job-status/allocation-status-block.hbs @@ -10,26 +10,13 @@ {{#if this.countToShow}}
{{#each (range 0 this.countToShow) as |i|}} - - {{#if (and (eq @status "running") (not @steady))}} - {{#if (eq @canary "canary")}} - - {{/if}} - - {{#if (eq @health "healthy")}} - - {{else}} - - {{/if}} - - {{/if}} - + {{/each}}
{{/if}} diff --git a/ui/app/components/job-status/allocation-status-row.hbs b/ui/app/components/job-status/allocation-status-row.hbs index bae52fd87..f94fd6ef4 100644 --- a/ui/app/components/job-status/allocation-status-row.hbs +++ b/ui/app/components/job-status/allocation-status-row.hbs @@ -36,28 +36,13 @@ {{#each-in allocsByHealth as |canary allocsByCanary|}} {{#if (gt allocsByCanary.length 0)}} {{#each (range 0 allocsByCanary.length) as |i|}} - - {{#unless @steady}} - {{#if (eq canary "canary")}} - - {{/if}} - {{#if (eq status "running")}} - - {{#if (eq health "healthy")}} - - {{else}} - - {{/if}} - - {{/if}} - {{/unless}} - + {{/each}} {{/if}} {{/each-in}} diff --git a/ui/app/components/job-status/failed-or-lost.hbs b/ui/app/components/job-status/failed-or-lost.hbs index 0e224e3db..12959363c 100644 --- a/ui/app/components/job-status/failed-or-lost.hbs +++ b/ui/app/components/job-status/failed-or-lost.hbs @@ -8,13 +8,9 @@