From f4d71b4303bca56f8a0da860e6d521e1cda5adec Mon Sep 17 00:00:00 2001
From: Michael Schurter <schmichael@hashicorp.com>
Date: Mon, 2 Oct 2017 15:23:29 -0700
Subject: [PATCH] Deployment.Allocations ACL enforcement

---
 nomad/deployment_endpoint.go           |  7 +++
 nomad/deployment_endpoint_test.go      | 74 ++++++++++++++++++++++++++
 website/source/api/deployments.html.md |  6 +--
 3 files changed, 84 insertions(+), 3 deletions(-)

diff --git a/nomad/deployment_endpoint.go b/nomad/deployment_endpoint.go
index 94e254255..05c9fcfe6 100644
--- a/nomad/deployment_endpoint.go
+++ b/nomad/deployment_endpoint.go
@@ -307,6 +307,13 @@ func (d *Deployment) Allocations(args *structs.DeploymentSpecificRequest, reply
 	}
 	defer metrics.MeasureSince([]string{"nomad", "deployment", "allocations"}, time.Now())
 
+	// Check namespace read-job permissions
+	if aclObj, err := d.srv.resolveToken(args.SecretID); err != nil {
+		return err
+	} else if aclObj != nil && !aclObj.AllowNsOp(args.RequestNamespace(), acl.NamespaceCapabilityReadJob) {
+		return structs.ErrPermissionDenied
+	}
+
 	// Setup the blocking query
 	opts := blockingOptions{
 		queryOpts: &args.QueryOptions,
diff --git a/nomad/deployment_endpoint_test.go b/nomad/deployment_endpoint_test.go
index b32e9a250..cc540391f 100644
--- a/nomad/deployment_endpoint_test.go
+++ b/nomad/deployment_endpoint_test.go
@@ -1065,6 +1065,80 @@ func TestDeploymentEndpoint_Allocations(t *testing.T) {
 	assert.Equal(a.ID, resp.Allocations[0].ID, "Allocation ID")
 }
 
+func TestDeploymentEndpoint_Allocations_ACL(t *testing.T) {
+	t.Parallel()
+	s1, root := testACLServer(t, nil)
+	defer s1.Shutdown()
+	codec := rpcClient(t, s1)
+	testutil.WaitForLeader(t, s1.RPC)
+	assert := assert.New(t)
+
+	// Create the register request
+	j := mock.Job()
+	d := mock.Deployment()
+	d.JobID = j.ID
+	a := mock.Alloc()
+	a.DeploymentID = d.ID
+	summary := mock.JobSummary(a.JobID)
+	state := s1.fsm.State()
+
+	assert.Nil(state.UpsertJob(998, j), "UpsertJob")
+	assert.Nil(state.UpsertJobSummary(999, summary), "UpsertJobSummary")
+	assert.Nil(state.UpsertDeployment(1000, d), "UpsertDeployment")
+	assert.Nil(state.UpsertAllocs(1001, []*structs.Allocation{a}), "UpsertAllocs")
+
+	// Create the namespace policy and tokens
+	validToken := CreatePolicyAndToken(t, state, 1001, "test-valid",
+		NamespacePolicy(structs.DefaultNamespace, "", []string{acl.NamespaceCapabilityReadJob}))
+	invalidToken := CreatePolicyAndToken(t, state, 1003, "test-invalid",
+		NamespacePolicy(structs.DefaultNamespace, "", []string{acl.NamespaceCapabilityListJobs}))
+
+	get := &structs.DeploymentSpecificRequest{
+		DeploymentID: d.ID,
+		QueryOptions: structs.QueryOptions{
+			Region:    "global",
+			Namespace: structs.DefaultNamespace,
+		},
+	}
+
+	// Try with no token and expect permission denied
+	{
+		var resp structs.DeploymentUpdateResponse
+		err := msgpackrpc.CallWithCodec(codec, "Deployment.Allocations", get, &resp)
+		assert.NotNil(err)
+		assert.Equal(err.Error(), structs.ErrPermissionDenied.Error())
+	}
+
+	// Try with an invalid token
+	{
+		get.SecretID = invalidToken.SecretID
+		var resp structs.DeploymentUpdateResponse
+		err := msgpackrpc.CallWithCodec(codec, "Deployment.Allocations", get, &resp)
+		assert.NotNil(err)
+		assert.Equal(err.Error(), structs.ErrPermissionDenied.Error())
+	}
+
+	// Lookup the allocations with a valid token
+	{
+		get.SecretID = validToken.SecretID
+		var resp structs.AllocListResponse
+		assert.Nil(msgpackrpc.CallWithCodec(codec, "Deployment.Allocations", get, &resp), "RPC")
+		assert.EqualValues(1001, resp.Index, "Wrong Index")
+		assert.Len(resp.Allocations, 1, "Allocations")
+		assert.Equal(a.ID, resp.Allocations[0].ID, "Allocation ID")
+	}
+
+	// Lookup the allocations with a root token
+	{
+		get.SecretID = root.SecretID
+		var resp structs.AllocListResponse
+		assert.Nil(msgpackrpc.CallWithCodec(codec, "Deployment.Allocations", get, &resp), "RPC")
+		assert.EqualValues(1001, resp.Index, "Wrong Index")
+		assert.Len(resp.Allocations, 1, "Allocations")
+		assert.Equal(a.ID, resp.Allocations[0].ID, "Allocation ID")
+	}
+}
+
 func TestDeploymentEndpoint_Allocations_Blocking(t *testing.T) {
 	t.Parallel()
 	s1 := testServer(t, nil)
diff --git a/website/source/api/deployments.html.md b/website/source/api/deployments.html.md
index d5d5c6eff..e9163bf0b 100644
--- a/website/source/api/deployments.html.md
+++ b/website/source/api/deployments.html.md
@@ -139,9 +139,9 @@ The table below shows this endpoint's support for
 [blocking queries](/api/index.html#blocking-queries) and
 [required ACLs](/api/index.html#acls).
 
-| Blocking Queries | ACL Required |
-| ---------------- | ------------ |
-| `YES`            | `none`       |
+| Blocking Queries | ACL Required         |
+| ---------------- | -------------------- |
+| `YES`            | `namespace:read-job` |
 
 ### Parameters