kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-01 16:05:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

populate Nomad token for task runner update hooks (#16266)

Browse Source 
The `TaskUpdateRequest` struct we send to task runner update hooks was not
populating the Nomad token that we get from the task runner (which we do for the
Vault token). This results in task runner hooks like the template hook
overwriting the Nomad token with the zero value for the token. This causes
in-place updates of a task to break templates (but not other uses that rely on
identity but don't currently bother to update it, like the identity hook).
This commit is contained in:
Tim Gross
2023-02-27 10:48:13 -05:00
committed by GitHub
parent 7c56fd5073
commit f619b0bd7a
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.changelog/16266.txt Normal file
View File

@@ -0,0 +1,3 @@
```release-note:bug
template: Fixed a bug where the template runner's Nomad token would be erased by in-place updates to a task
```

1
client/allocrunner/taskrunner/task_runner_hooks.go
View File

@@ -487,6 +487,7 @@ func (tr *TaskRunner) updateHooks() {
// Build the request // Build the request
req := interfaces.TaskUpdateRequest{ req := interfaces.TaskUpdateRequest{
NomadToken: tr.getNomadToken(),
VaultToken: tr.getVaultToken(), VaultToken: tr.getVaultToken(),
Alloc: alloc, Alloc: alloc,
TaskEnv: tr.envBuilder.Build(), TaskEnv: tr.envBuilder.Build(),