From f6efac6c1225d375a34fc3cbbdc1f559b5d4e1d0 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Tue, 4 Dec 2018 09:04:04 -0500 Subject: [PATCH] no t.Parallel() in excutor table driven tests (#4948) When `t.Parallel()` is used inside a `t.Run()` sub-set, the closure doesn't behave as expected, and some cases effectively get skipped. More details can be found in https://gist.github.com/posener/92a55c4cd441fc5e5e85f27bca008721 --- drivers/shared/executor/executor_test.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/shared/executor/executor_test.go b/drivers/shared/executor/executor_test.go index 1c274a382..05ab48938 100644 --- a/drivers/shared/executor/executor_test.go +++ b/drivers/shared/executor/executor_test.go @@ -79,7 +79,6 @@ func TestExecutor_Start_Invalid(pt *testing.T) { invalid := "/bin/foobar" for name, factory := range executorFactories { pt.Run(name, func(t *testing.T) { - t.Parallel() require := require.New(t) execCmd, allocDir := testExecutorCommand(t) execCmd.Cmd = invalid @@ -98,7 +97,6 @@ func TestExecutor_Start_Wait_Failure_Code(pt *testing.T) { pt.Parallel() for name, factory := range executorFactories { pt.Run(name, func(t *testing.T) { - t.Parallel() require := require.New(t) execCmd, allocDir := testExecutorCommand(t) execCmd.Cmd = "/bin/date" @@ -121,7 +119,6 @@ func TestExecutor_Start_Wait(pt *testing.T) { pt.Parallel() for name, factory := range executorFactories { pt.Run(name, func(t *testing.T) { - t.Parallel() require := require.New(t) execCmd, allocDir := testExecutorCommand(t) execCmd.Cmd = "/bin/echo" @@ -157,7 +154,6 @@ func TestExecutor_WaitExitSignal(pt *testing.T) { pt.Parallel() for name, factory := range executorFactories { pt.Run(name, func(t *testing.T) { - t.Parallel() require := require.New(t) execCmd, allocDir := testExecutorCommand(t) execCmd.Cmd = "/bin/sleep" @@ -191,7 +187,6 @@ func TestExecutor_Start_Kill(pt *testing.T) { pt.Parallel() for name, factory := range executorFactories { pt.Run(name, func(t *testing.T) { - t.Parallel() require := require.New(t) execCmd, allocDir := testExecutorCommand(t) execCmd.Cmd = "/bin/sleep"