Updates based on feedback provided by dadgar.

This commit is contained in:
James Rasell
2017-08-16 21:33:11 +01:00
parent 113e9b0c33
commit fe481ae0dd
4 changed files with 28 additions and 30 deletions

View File

@@ -292,7 +292,6 @@ func (a *Agent) clientConfig() (*clientconfig.Config, error) {
conf.Node.Name = a.config.NodeName
conf.Node.Meta = a.config.Client.Meta
conf.Node.NodeClass = a.config.Client.NodeClass
conf.Node.Build = fmt.Sprintf("%s%s", a.config.Version, a.config.VersionPrerelease)
// Set up the HTTP advertise address
conf.Node.HTTPAddr = a.config.AdvertiseAddrs.HTTP

View File

@@ -148,37 +148,40 @@ func (c *NodeStatusCommand) Run(args []string) int {
// Format the nodes list
out := make([]string, len(nodes)+1)
out[0] = "ID|DC|Name|Class|"
if c.verbose {
out[0] += "Version|"
}
out[0] += "Drain|Status"
if c.list_allocs {
out[0] = "ID|DC|Name|Class|Build|Drain|Status|Running Allocs"
} else {
out[0] = "ID|DC|Name|Class|Build|Drain|Status"
out[0] += "|Running Allocs"
}
for i, node := range nodes {
out[i+1] = fmt.Sprintf("%s|%s|%s|%s",
limit(node.ID, c.length),
node.Datacenter,
node.Name,
node.NodeClass)
if c.verbose {
out[i+1] += fmt.Sprintf("|%s",
node.Version)
}
out[i+1] += fmt.Sprintf("|%v|%s",
node.Drain,
node.Status)
if c.list_allocs {
numAllocs, err := getRunningAllocs(client, node.ID)
if err != nil {
c.Ui.Error(fmt.Sprintf("Error querying node allocations: %s", err))
return 1
}
out[i+1] = fmt.Sprintf("%s|%s|%s|%s|%s|%v|%s|%v",
limit(node.ID, c.length),
node.Datacenter,
node.Name,
node.NodeClass,
node.Build,
node.Drain,
node.Status,
out[i+1] += fmt.Sprintf("|%v",
len(numAllocs))
} else {
out[i+1] = fmt.Sprintf("%s|%s|%s|%s|%s|%v|%s",
limit(node.ID, c.length),
node.Datacenter,
node.Name,
node.NodeClass,
node.Build,
node.Drain,
node.Status)
}
}
@@ -222,14 +225,13 @@ func (c *NodeStatusCommand) Run(args []string) int {
// Format the nodes list that matches the prefix so that the user
// can create a more specific request
out := make([]string, len(nodes)+1)
out[0] = "ID|DC|Name|Class|Build|Drain|Status"
out[0] = "ID|DC|Name|Class|Drain|Status"
for i, node := range nodes {
out[i+1] = fmt.Sprintf("%s|%s|%s|%s|%s|%v|%s",
out[i+1] = fmt.Sprintf("%s|%s|%s|%s|%v|%s",
limit(node.ID, c.length),
node.Datacenter,
node.Name,
node.NodeClass,
node.Build,
node.Drain,
node.Status)
}