From ff2d9de592ed1918ebdbd8223743d847ec88acc6 Mon Sep 17 00:00:00 2001 From: Tim Gross Date: Fri, 26 Apr 2024 09:36:09 -0400 Subject: [PATCH] Revert "E2E: skip Vault 1.16.1 for JWT compatibility test (#20301)" (#20484) This reverts commit 45b36371a12ffae5b5bfaaeadb08f801fb6bc98d. Now that Vault 1.16.2 has shipped, the E2E test will pick up only a working version. Closes: https://github.com/hashicorp/nomad/issues/20298 --- e2e/vaultcompat/vaultcompat_test.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/e2e/vaultcompat/vaultcompat_test.go b/e2e/vaultcompat/vaultcompat_test.go index 8432833d0..7cf273324 100644 --- a/e2e/vaultcompat/vaultcompat_test.go +++ b/e2e/vaultcompat/vaultcompat_test.go @@ -43,11 +43,6 @@ var ( // 1.11.0 is when Vault added support for `user_claim_json_pointer`. // https://github.com/hashicorp/vault/pull/15593 minJWTVersion = goversion.Must(goversion.NewVersion("1.11.0")) - - // skipJWTVersion is a version that has a known issue with JWT. Once 1.16.2 - // ships, we can remove this as it won't be downloaded and tested anymore. - // See: https://github.com/hashicorp/nomad/issues/20298 - skipJWTVersion = goversion.Must(goversion.NewVersion("1.16.1")) ) func TestVaultCompat(t *testing.T) { @@ -75,7 +70,7 @@ func testVaultBuild(t *testing.T, b build) { testVaultLegacy(t, b) }) - if version.GreaterThanOrEqual(minJWTVersion) && !version.Equal(skipJWTVersion) { + if version.GreaterThanOrEqual(minJWTVersion) { t.Run("jwt", func(t *testing.T) { testVaultJWT(t, b) })