Commit Graph

1872 Commits

Author SHA1 Message Date
Michael Schurter
435a6bddce consul: remove services with/without canary tags
Guard against Canary being set to false at the same time as an
allocation is being stopped: this could cause RemoveTask to be called
with the wrong Canary value and leaking a service.

Deleting both Canary values is the safest route.
2018-05-07 14:55:01 -05:00
Michael Schurter
17c6eb8629 consul: support canary tags for services
Also refactor Consul ServiceClient to take a struct instead of a massive
set of arguments. Meant updating a lot of code but it should be far
easier to extend in the future as you will only need to update a single
struct instead of every single call site.

Adds an e2e test for canary tags.
2018-05-07 14:55:01 -05:00
Alex Dadgar
20df5aea5b Canary tags structs 2018-05-07 14:50:01 -05:00
Alex Dadgar
8be599af94 Mark canaries on creation, and unmark on promotion 2018-05-07 14:50:01 -05:00
Alex Dadgar
eb6a99a6d8 CLI 2018-05-07 14:50:01 -05:00
Alex Dadgar
15c3abf816 Initial implementation 2018-05-07 14:50:01 -05:00
Michael Schurter
bd4e761c29 Merge pull request #4251 from hashicorp/f-grpc-checks
Support Consul gRPC Health Checks
2018-05-04 14:55:16 -07:00
Michael Schurter
f2f6dab332 Merge pull request #4234 from hashicorp/b-4159
Fix race in StreamFramer and truncation in api/AllocFS.Logs
2018-05-04 14:24:07 -07:00
Michael Schurter
905bef8f2d consul: make grpc checks more like http checks 2018-05-04 11:08:11 -07:00
Michael Schurter
93356e7d70 consul: initial grpc implementation
Needs to be more like http.
2018-05-04 11:08:11 -07:00
Michael Schurter
758e1cb7f3 cli: expand drain info for node status 2018-05-04 10:32:25 -07:00
Nick Ethier
e3151f04fc command: remove all comments from short init jobspec 2018-05-03 15:34:56 -04:00
Michael Schurter
6858c520b2 framer: fix early exit/truncation in framer 2018-05-02 10:46:16 -07:00
Michael Schurter
8776cf8a80 client: use a bytes.Reader for reading a []byte 2018-05-02 10:46:16 -07:00
Michael Schurter
63dad441b4 client: ensure cancel is always called when func exits 2018-05-02 10:46:16 -07:00
Michael Schurter
564854dd97 client: give pipe conns meaningful names 2018-05-02 10:46:16 -07:00
Michael Schurter
a7c71c1cdc client: reset encoders between uses
According to go/codec's docs, Reset(...) should be called on
Decoders/Encoders before reuse:

https://godoc.org/github.com/ugorji/go/codec

I could find no evidence that *not* calling Reset() caused bugs, but
might as well do what the docs say?
2018-05-02 10:46:16 -07:00
Nick Ethier
57d7f428ae command: add '-short' flag to init command that emits minimal jobspec 2018-05-01 12:51:13 -04:00
Alex Dadgar
9a4295aa9c generated files 2018-04-26 16:28:58 -07:00
Alex Dadgar
15623e52cd Fix command line 2018-04-26 15:46:22 -07:00
James Rasell
805b5278e7 Update node-drain logging message to clearer for operators.
This change updates the console log message when performing a node
drain and particulary when a node has marked all allocs for
migration. Previously it logged 'drain complete' which was a little
confusing to operators as the node is not drained at this point.

Closes #4183
2018-04-24 07:50:01 +01:00
Michael Schurter
443c1f3f3f Merge pull request #4178 from hashicorp/f-sort-drivers
cli: sort drivers in `node status <node_id>`
2018-04-20 14:03:26 -07:00
Michael Schurter
972e861410 consul: periodically reconcile services/checks
Periodically sync services and checks from Nomad to Consul. This is
mostly useful when testing with the Consul dev agent which does not
persist state across restarts. However, this is a reasonable safety
measure to prevent skew between Consul's state and Nomad's
services+checks.

Also modernized the test suite a bit.
2018-04-19 15:45:42 -07:00
Nick Ethier
95d9eb9bf3 Merge pull request #4138 from hashicorp/i-hcl-json-endpoint
HCL to JSON api endpoint
2018-04-19 14:18:34 -04:00
Nick Ethier
73b94f5767 Merge pull request #4176 from hashicorp/i-cli-error-help
Improve help text when invalid arguments are given
2018-04-19 12:45:22 -04:00
Nick Ethier
f1364fbbad command: fix job dispatch arg check 2018-04-18 21:21:43 -04:00
Michael Schurter
29da24b77b test: build with mock_driver by default
`make release` and `make prerelease` set a `release` tag to disable
enabling the `mock_driver`
2018-04-18 14:45:33 -07:00
Michael Schurter
91cd1a2258 cli: sort drivers in node status <node_id> 2018-04-18 14:30:44 -07:00
Nick Ethier
0216a8e377 command: use ':' instead of ',' in error msg 2018-04-18 13:55:51 -04:00
Nick Ethier
4a4ed06db1 command: update tests to check for new error message 2018-04-18 13:51:17 -04:00
Nick Ethier
5d39f68f89 command: fix misspelling in comment 2018-04-18 12:19:53 -04:00
Nick Ethier
45b0ce9177 command: improve help text when invalid arguments are given 2018-04-18 12:02:11 -04:00
Nick Ethier
4303941098 command/agent: fix url in jobs parse ep test 2018-04-16 19:21:09 -04:00
Nick Ethier
c5945204a6 command/agent: fix ptr ref in job endpoint test 2018-04-16 19:21:09 -04:00
Nick Ethier
14c44da757 command/agent: add Canonicalize option to parse args 2018-04-16 19:21:09 -04:00
Nick Ethier
03f5c2f6f9 command/agent: add HCL mock for parse endpoint 2018-04-16 19:21:09 -04:00
Nick Ethier
b2b999249b command/agent: add /v1/jobs/parse endpoint
The parse endpoint accepts a hcl jobspec body within a json object
and returns the parsed json object for the job. This allows users to
register jobs with the nomad json api without specifically needing
a nomad binary to parse their hcl encoded jobspec file.
2018-04-16 19:21:06 -04:00
Alex Dadgar
8a80a5f7c5 Version bump and generated files 2018-04-12 16:21:50 -07:00
Alex Dadgar
725f36a7ca Non-verbose driver formatting and don't display non-detected 2018-04-12 11:26:00 -07:00
Preetha Appan
a74865de5f Add link to autopilot guide in operator autopilot CLI help text 2018-04-12 09:02:32 -05:00
Preetha
f52b9fa5b6 Merge pull request #4136 from hashicorp/f-eval-status-show-waituntil
Show wait until value in eval status if it is set
2018-04-11 14:49:29 -05:00
Preetha Appan
2ec37d3e61 Show wait until value in eval status if it is set 2018-04-11 14:01:42 -05:00
Preetha
06412a5b1a Merge pull request #4127 from hashicorp/b-autopilot-removepeer-fixes
Add node id persistence
2018-04-10 16:05:00 -05:00
Preetha Appan
f8427c847d minor code review fix 2018-04-10 15:33:01 -05:00
Preetha Appan
ffb622fbfd Dev mode should never persist nodeid 2018-04-10 12:34:14 -05:00
Preetha Appan
1ba9feb3b7 Lint fixes 2018-04-10 11:22:16 -05:00
Preetha Appan
86ced8aef2 Use preconfigured nodeID if there isn't a persisted node ID, and persist it if its not persisted. 2018-04-10 08:47:33 -05:00
Alex Dadgar
5194f5d6c7 WIP: Not setting node id properlperly 2018-04-09 18:01:28 -07:00
Michael Schurter
1b1a8d44fd cli: remove outdated hints
Hints no longer apply in the 0.8 Node RPC world.
2018-04-09 12:09:47 -07:00
Chelsea Holland Komlo
bf89de322f correctly initialize array length 2018-04-09 10:51:08 -04:00