Alex Dadgar
a9e3a41407
Enable more linters
2017-09-26 15:26:33 -07:00
Alex Dadgar
f23ac5f083
Non-locked accessors to common Node fields
...
This PR removes locking around commonly accessed node attributes that do
not need to be locked. The locking could cause nodes to TTL as the
heartbeat code path was acquiring a lock that could be held for an
excessively long time. An example of this is when Vault is inaccessible,
since the fingerprint is run with a lock held but the Vault
fingerprinter makes the API calls with a large timeout.
Fixes https://github.com/hashicorp/nomad/issues/2689
2017-09-14 14:08:26 -07:00
Alex Dadgar
db261cd0c7
Fix invalid CPU stats on Windows
...
This PR fixes an issue introduced in Nomad 0.6.0 due to
https://github.com/shirou/gopsutil/issues/420 . The issue arised from the
fact that the Windows stats from gopsutil reports CPUs in
percentages where we expected ticks.
2017-09-10 15:30:48 -07:00
James Nugent
3a5082022d
client: Guard against "NaN" values from floats
...
This commit protects against finding `0.NaN` tokens in JSON streams
because of infinity representation on serialization.
2017-09-08 16:21:07 -05:00
Michael Schurter
7a84cbe02a
Squelch logspam when unable to get disk usage stats
...
To reproduce logspam:
```
$ docker plugin install --grant-all-permissions vieux/sshfs
$ nomad agent -dev
...
2017/08/25 17:09:03.282868 [WARN] client: error fetching host disk usage stats for /var/lib/docker/plugins/a8b4a69b07e5180f828d19e1e9e102ccc0e26f9c9939eaef85357260c30b20a7/rootfs/mnt/volumes: permission denied
... repeats every collection period ...
```
2017-08-28 12:04:32 -07:00
Alex Dadgar
47d48bdaee
Fix nil dereference
2017-01-10 14:14:58 -08:00
Diptanu Choudhury
7ebe4a6972
Added comments
2016-12-20 10:49:48 -08:00
Diptanu Choudhury
61e534d684
Making the gc allocator understand real disk usage
2016-12-16 18:34:59 -08:00
Diptanu Choudhury
41d7ebc5c5
Refactored hoststats collector
2016-12-14 15:07:42 -08:00
Christoffer Kylvåg
c3df9dd73f
#1680 : Continue after not being able to stat a mountpoint
2016-12-13 12:28:57 +01:00
Kenjiro Nakayama
50ca5c7f71
Update after the review
2016-08-11 10:53:33 +09:00
Kenjiro Nakayama
fbb2d5cd5d
Return error when client failed to collect host stats
2016-08-11 09:38:28 +09:00
Alex Dadgar
0b3a39b47f
guard against NaN
2016-06-20 10:29:46 -07:00
Alex Dadgar
591104f848
Merge pull request #1260 from hashicorp/f-alloc-stats-struct
...
Allocation resources returned in a struct
2016-06-12 11:18:57 -07:00
Alex Dadgar
020f8b05d3
only support latest and remove ring buffer
2016-06-12 09:32:38 -07:00
Diptanu Choudhury
53a57cae79
Fix the calculation of total ticks for docker and exec
2016-06-12 18:08:35 +02:00
Diptanu Choudhury
658362d248
Removing un-used code
2016-06-12 01:23:49 +02:00
Diptanu Choudhury
73f5c29e38
Fixed the calculation of the host node ticks
2016-06-12 01:14:51 +02:00
Diptanu Choudhury
d1fdd27f86
Moving the clkspeed code to helper
2016-06-11 17:31:49 +02:00
Diptanu Choudhury
304403a2f8
Extracted a method for getting clock speed
2016-06-11 02:07:28 +02:00
Diptanu Choudhury
358cdf8f63
Calculating total ticks consumed in the nomad client
2016-06-10 23:14:33 +02:00
Diptanu Choudhury
c13e750a02
Calculating the cpu ticks in nomad client
2016-06-10 22:22:32 +02:00
Alex Dadgar
693c8f9e42
Alloc-status only shows measured statistics and fixes to CPU calculations
2016-06-10 10:38:29 -07:00
Diptanu Choudhury
15e79c3783
Changing the api of the stats endpoints
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
0b868e07cb
Initializing the ring buffer with no cells
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
71d3361f79
creating the host cpu percent calculator lazily
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
73f05942f2
Refactored the api for NewHostStatsCollector
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
584c1e34fb
Incorporated review comments for executor
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
4491c2b0e8
Added disk usage to node status
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
1183037d56
Added uptime to node stats
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
aee9db02d5
Showing host resource usage stats
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
458b7014e4
Added a test for calculating cpu stats
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
3dc28bd871
Stopping stats collection of tasks which has been destroyed
2016-05-28 19:59:20 -07:00
Diptanu Choudhury
df68129e5a
Added some docs
2016-05-28 19:59:03 -07:00
Diptanu Choudhury
b7158be541
Added locks to RingBuf
2016-05-28 19:59:03 -07:00
Diptanu Choudhury
98068678f1
Implemented nomad cpu percentage calculator
2016-05-28 19:59:03 -07:00
Diptanu Choudhury
30cbfe1f71
Implemented cpu stats
2016-05-28 19:51:22 -07:00
Diptanu Choudhury
1f12e90b9b
Returning nil if peek is called before any value is enqueued
2016-05-28 19:42:34 -07:00
Diptanu Choudhury
7d8196d7ea
Added some documentation
2016-05-28 19:42:34 -07:00
Diptanu Choudhury
fe8f640cc8
Collecting host stats
2016-05-28 19:42:34 -07:00
Diptanu Choudhury
eda53e3bcb
Added a ringbuff datastructure
2016-05-28 19:42:34 -07:00
