Commit Graph

541 Commits

Author SHA1 Message Date
Alex Dadgar
ad4c26a1e3 review comments 2018-11-07 11:31:52 -08:00
Alex Dadgar
a36b682cf4 review comments 2018-11-07 10:33:22 -08:00
Alex Dadgar
ea5fd244f6 allocs fit checks if devices get oversubscribed 2018-11-07 10:33:22 -08:00
Alex Dadgar
dcbf9bdbab Split device accounter and allocator 2018-11-07 10:32:03 -08:00
Alex Dadgar
7ab3ce4bde affinities 2018-11-07 10:32:03 -08:00
Alex Dadgar
77ad27de60 assign devices 2018-11-07 10:32:03 -08:00
Preetha Appan
ea5d8cb625 update preemption tests to use new node resource structs
also includes a fix to remove unnecessary subtraction of network mbits
2018-11-02 17:59:53 -05:00
Preetha
6aa0c7ffa9 Merge pull request #4794 from hashicorp/f-preemption-systemjobs
Preemption for system jobs
2018-11-02 16:28:06 -05:00
Preetha Appan
97cf4e1d7a Address more minor code review feedback 2018-11-02 16:26:34 -05:00
Preetha Appan
c49a3e20c5 Fix test setup 2018-11-02 16:06:25 -05:00
Preetha Appan
1380acbf56 dereference safely 2018-11-02 15:58:59 -05:00
Preetha Appan
8235919158 Fix static port preemption to be device aware 2018-11-02 13:07:24 -05:00
Preetha Appan
0015095b57 Handle static port preemption when there are multiple devices
Also added test case
2018-11-02 09:09:50 -05:00
Preetha Appan
06ad182026 Plumb alloc resource cache in a few more places.
also removed now unused method
2018-11-01 16:44:43 -05:00
Preetha Appan
3ad7b3fb5b More review comments 2018-11-01 16:36:11 -05:00
Preetha Appan
993b6a272a Cleaner way to exit early, and fixed a couple more places reading from alloc.Resources 2018-11-01 16:15:58 -05:00
Preetha Appan
22d156f5a0 review comments 2018-11-01 12:01:59 -05:00
Preetha Appan
4a35d62887 Fix formatting of allocation score metrics 2018-10-30 12:03:23 -05:00
Preetha Appan
17344a7f3a Introduce interface with multiple implementations for resource distance 2018-10-30 11:06:32 -05:00
Preetha Appan
35635ba39a refactor preemption code to use method recievers and setters for common fields 2018-10-30 11:06:32 -05:00
Preetha Appan
4cc21fbcfa more minor cleanup 2018-10-30 11:06:32 -05:00
Preetha Appan
21432d69dc More style and readablity fixes from review 2018-10-30 11:06:32 -05:00
Preetha Appan
655689a743 Preempted allocations should be removed from proposed allocations 2018-10-30 11:06:32 -05:00
Preetha Appan
a960cced8c comments 2018-10-30 11:06:32 -05:00
Preetha Appan
9f35923db0 fix end to end scheduler test to use new resource structs correctly 2018-10-30 11:06:32 -05:00
Preetha Appan
24b393483a Modify preemption code to use new style of resource structs 2018-10-30 11:06:32 -05:00
Preetha Appan
6966e3c3e8 Make preemption config a struct to allow for enabling based on scheduler type 2018-10-30 11:06:32 -05:00
Preetha Appan
2143fa2ab7 Use scheduler config from state store to enable/disable preemption 2018-10-30 11:06:32 -05:00
Preetha Appan
fd6bff2332 Fix linting and better comments 2018-10-30 11:06:32 -05:00
Preetha Appan
715d869499 Implement preemption for system jobs.
This commit implements an allocation selection algorithm for finding
allocations to preempt. It currently special cases network resource asks
from others (cpu/memory/disk/iops).
2018-10-30 11:06:32 -05:00
Preetha Appan
b7de9570e2 Merge branch 'f-fix-resource-type' of github.com:hashicorp/nomad into f-fix-resource-type 2018-10-16 18:30:12 -05:00
Preetha Appan
851bfb2af7 fix linting 2018-10-16 18:29:49 -05:00
Alex Dadgar
5e67b37aad use int64 2018-10-16 15:34:32 -07:00
Preetha Appan
3ca71ae935 Change CPU/Disk/MemoryMB to int everywhere in new resource structs 2018-10-16 16:21:42 -05:00
Alex Dadgar
9776141240 review comments 2018-10-15 15:31:13 -07:00
Alex Dadgar
ef82a33329 Check constraints on devices 2018-10-14 13:35:47 -07:00
Alex Dadgar
08e0d2502f rework device checker 2018-10-13 16:47:53 -07:00
Alex Dadgar
670c7e57dc add to stack 2018-10-13 12:27:49 -07:00
Alex Dadgar
d52130cc4b Device feasability checker 2018-10-13 12:27:49 -07:00
Preetha Appan
dfc76b3e1f Fix bug in reconciler where terminal allocs on a job already stopped were unnecessarily updated 2018-10-08 21:03:49 -05:00
Alex Dadgar
e30b20e65e renames 2018-10-04 14:57:25 -07:00
Alex Dadgar
0f2f4797cb fixing tests 2018-10-04 14:26:19 -07:00
Alex Dadgar
49c2d4f775 Scheduler uses allocated resources 2018-10-02 17:08:25 -07:00
Preetha Appan
47e22f6b7c Add failed follow up to the list of allowed eval trigger reasons
needs unit test
2018-09-25 10:49:55 -07:00
Alex Dadgar
ed53038e04 Unique TriggerBy for blocked evals
Give blocked evals a unique triggerby reason to make debugging a chain
of evaluations easier.
2018-09-24 14:47:49 -07:00
Alex Dadgar
260b566c91 server 2018-09-15 16:23:13 -07:00
Alex Dadgar
14b65c3378 Failed/paused deployments do not block migrations
This PR changes behavior of the scheduler such that a task group with a
deployment that is failed or paused will not cause the scheduler to skip
migrations.

The reason for this change is that it causes a bad UX when draining
nodes with allocations that are part of a failed/paused deployment.
These operations should not be coupled in any way and this remedies
that.

Prior behavior was still correct, but required either jobs to
transistion to a healthy state or for the node to hit its drain
deadline.
2018-09-10 15:28:45 -07:00
Alex Dadgar
a5a26db04a Merge pull request #4642 from hashicorp/b-vet
Fix vet errors and use newer go version in travis
2018-09-04 17:04:02 -07:00
Alex Dadgar
da0bec03c1 Fix make check errors 2018-09-04 16:03:52 -07:00
Preetha Appan
a2284d0f3e code review feedback 2018-09-04 16:10:11 -05:00