Commit Graph

1165 Commits

Author SHA1 Message Date
Alex Dadgar
7515f778a9 Thread through warnings about deprecations 2017-05-09 20:52:47 -07:00
Alex Dadgar
d606e98a6e New update block; still need to handle the upgrade path 2017-05-08 17:44:26 -07:00
Michael Schurter
d7f95245ec Merge pull request #2608 from hashicorp/f-test-verify_https_client
Test verify_https_client behavior and skip Consul HTTPS health checks when enabled
2017-05-04 17:36:13 -07:00
Michael Schurter
d1d34bf019 Remove extra Travis logging 2017-05-04 17:35:54 -07:00
Michael Schurter
e07235e883 Adding logging for Travis 2017-05-03 15:18:48 -07:00
Alex Dadgar
3642434293 Fix tests 2017-05-03 15:14:19 -07:00
Michael Schurter
c1d0de5bd2 Don't reuse transport/client 2017-05-03 13:26:55 -07:00
Kate Taggart
6ea156b565 responding to feedback on PR: remove Region from Node struct, some grammatical niceties. 2017-05-03 12:45:59 -07:00
Kate Taggart
4a4417d556 I think I did it. 2017-05-03 12:45:59 -07:00
Michael Schurter
77d9b417c1 Skip https health check if verify_https_client is true 2017-05-03 12:19:02 -07:00
Michael Schurter
a2d453ad14 Fix error check for consul skip tls verify support 2017-05-02 17:38:18 -07:00
Michael Schurter
26609bc832 Extensively test verify_https_client behavior
verify_https_client support added in #2587
2017-05-02 16:48:16 -07:00
Michael Schurter
d227780b63 Merge pull request #2587 from weargoggles/patch-1
Verification options for TLS
2017-05-02 10:36:41 -07:00
Pete Wildsmith
b16409ac54 update test 2017-04-30 15:40:04 +01:00
Pete Wildsmith
36f595480e address feedback 2017-04-29 08:26:12 +01:00
Pete Wildsmith
a4ad6eb319 reduce to one configuration option
There should be just one option, verify_https_client, which
controls incoming and outgoing validation for the HTTPS wrapper
2017-04-28 10:45:09 +01:00
Pete Wildsmith
6ca05757ee fix config parse test 2017-04-26 21:13:54 +01:00
Pete Wildsmith
54e5dd6ff1 Verification options allowed in TLS config 2017-04-25 23:35:47 +01:00
Pete Wildsmith
44a91c395f Copy TLSConfig verification flags in server create 2017-04-25 23:33:12 +01:00
Alex Dadgar
6a9af5a216 Agent test 2017-04-20 11:14:06 -07:00
Alex Dadgar
99e9f2aaaa Agent revert 2017-04-20 11:14:06 -07:00
Michael Schurter
58430bf062 Fix consul test build on Windows 2017-04-19 16:14:11 -07:00
Michael Schurter
b9ea2765ec Thanks go vet! 2017-04-19 13:05:41 -07:00
Michael Schurter
4cf34edb29 Skip checks with TLSSkipVerify if it's unsupported
Fixes #2218
2017-04-19 12:45:34 -07:00
Michael Schurter
7c67166510 Add TLSSkipVerify support to api and parser 2017-04-19 12:45:34 -07:00
Michael Schurter
64057d48fe Use go-version instead of manual version parsing 2017-04-19 12:42:48 -07:00
Michael Schurter
6d9e61bb51 Use spiffy new Go 1.8 subtest feature 2017-04-19 12:42:48 -07:00
Michael Schurter
5948daf4f7 Forgot an important word 2017-04-19 12:42:48 -07:00
Michael Schurter
346838381b Only register HTTPS agent check when Consul>=0.7.2
Support for TLSSkipVerify in other checks coming soon!
2017-04-19 12:42:48 -07:00
Michael Schurter
f0bec63174 Explain weird timer logic 2017-04-19 12:42:48 -07:00
Michael Schurter
de3d78365e Metricsify new Consul client 2017-04-19 12:42:48 -07:00
Michael Schurter
d3f3af8bf9 Always fail script checks when deadline exceeded 2017-04-19 12:42:48 -07:00
Michael Schurter
465cc5157b Test script check exit codes 2017-04-19 12:42:47 -07:00
Michael Schurter
6a56b0efc6 Follow _testing.go convention for testing tools 2017-04-19 12:42:47 -07:00
Michael Schurter
927b265854 Rework to account for ports not being in IDs
Previous implementation assumed all struct fields were included in
service and check IDs. Service IDs never include port labels and check
IDs *optionally* include port labels, so lots of things had to change.

Added a really big test to exercise this.
2017-04-19 12:42:47 -07:00
Michael Schurter
7de3adaf87 Remove commits return value
...and still protect against leaking agent entries in Consul on
shutdown.
2017-04-19 12:42:47 -07:00
Michael Schurter
5d75efc397 Explain PortLabel handling in RegisterAgent 2017-04-19 12:42:47 -07:00
Michael Schurter
48269c36b0 Plumb alloc id + task name into script check logs 2017-04-19 12:42:47 -07:00
Michael Schurter
80617a9c1a Stop being lazy and just type out struct{}{} 2017-04-19 12:42:47 -07:00
Michael Schurter
7ac9215fb7 Use nifty testtask sleep command for xplat compat 2017-04-19 12:42:47 -07:00
Michael Schurter
4002d87a6b Add comments, clarify names, fix PR comments 2017-04-19 12:42:47 -07:00
Michael Schurter
b4c7d92936 Explain cleanup defer in test 2017-04-19 12:42:47 -07:00
Michael Schurter
a3fc76b63a Fix comment to reflect reality 2017-04-19 12:42:47 -07:00
Michael Schurter
63a8307255 Move ScriptExecutor to driver 2017-04-19 12:42:47 -07:00
Michael Schurter
b4e40efa15 Fix shutdown when consul is down 2017-04-19 12:42:47 -07:00
Michael Schurter
80882f3e0e Switch ServiceClient to synchronizing state
Previously it applied a stream of operations. Reconciling state is less
complex and error prone at the cost of slightly higher CPU/memory usage.
2017-04-19 12:42:47 -07:00
Michael Schurter
b6937912d8 Add UpdateTask method instead of Remove/Add 2017-04-19 12:42:47 -07:00
Michael Schurter
7930d35925 Remove some lies 2017-04-19 12:42:47 -07:00
Michael Schurter
e13b149628 Remove unused syncInterval 2017-04-19 12:42:47 -07:00
Michael Schurter
10cb924b2c Refactor Consul Syncer into new ServiceClient
Fixes #2478 #2474 #1995 #2294

The new client only handles agent and task service advertisement. Server
discovery is mostly unchanged.

The Nomad client agent now handles all Consul operations instead of the
executor handling task related operations. When upgrading from an
earlier version of Nomad existing executors will be told to deregister
from Consul so that the Nomad agent can re-register the task's services
and checks.

Drivers - other than qemu - now support an Exec method for executing
abritrary commands in a task's environment. This is used to implement
script checks.

Interfaces are used extensively to avoid interacting with Consul in
tests that don't assert any Consul related behavior.
2017-04-19 12:42:47 -07:00