Commit Graph

19516 Commits

Author SHA1 Message Date
Lang Martin
dd7016b847 csi: plugins track jobs in addition to allocations, and use job information to set expected counts (#8699)
* nomad/structs/csi: add explicit job support
* nomad/state/state_store: capture job updates directly
* api/nodes: CSIInfo needs the AllocID
* command/agent/csi_endpoint: AllocID was missing
Co-authored-by: Tim Gross <tgross@hashicorp.com>
2020-08-27 17:20:00 -04:00
Tim Gross
faa54b6288 changelog: batch of bug fixes for 0.12.4 (#8767) 2020-08-27 16:22:46 -04:00
Tim Gross
78c99bf34f lint: check for go.mod or go.sum drift (#8765) 2020-08-27 16:21:07 -04:00
Tim Gross
7fdd6431b0 fix committed go.sum merge conflict (#8764) 2020-08-27 15:35:52 -04:00
Seth Hoenig
c5c332cf76 Merge pull request #8761 from hashicorp/b-consul-op-token-check
consul/connect: make use of task kind to determine service name in consul token checks
2020-08-27 14:08:33 -05:00
Tim Gross
a79d679236 MRD: deregister regions that are dropped on update (#8763)
This changeset is the OSS hooks for what will be implemented in ENT.
2020-08-27 14:54:45 -04:00
Tim Gross
63db66b1c4 tests: allow API test server to respect NOMAD_TEST_LOG_LEVEL (#8760) 2020-08-27 14:36:17 -04:00
Seth Hoenig
65ef854880 consul/connect: make use of task kind to determine service name in consul token checks
When consul.allow_unauthenticated is set to false, the job_endpoint hook validates
that a `-consul-token` is provided and validates the token against the privileges
inherent to a Consul Service Identity policy for all the Connect enabled services
defined in the job.

Before, the check was assuming the service was of type sidecar-proxy. This fixes the
check to use the type of the task so we can distinguish between the different connect
types.
2020-08-27 12:14:40 -05:00
Drew Bailey
4b7aee5db9 Merge pull request #8758 from hashicorp/drewbailey-patch-1
fix changelog entry placement
2020-08-27 11:47:49 -04:00
Drew Bailey
10cb2415b9 fix changelog entry placement 2020-08-27 11:47:01 -04:00
Chris Baker
2d04019dfa Merge pull request #8753 from hashicorp/b-scaling-policy-delete-job-prefix
resolve prefix bugs around job scaling policies
2020-08-27 10:04:21 -05:00
Buck Doyle
4628640e0e Fix tragique formatting 2020-08-27 09:38:34 -05:00
Chris Baker
1ea550d08e state_store/fix the prefix bugs for scaling policies documented in 1a9318 2020-08-27 04:25:37 +00:00
Chris Baker
1a9318ad6c documenting tests for prefix bugs around job scaling policies 2020-08-27 03:22:13 +00:00
Tim Gross
39925e70fc e2e: minor TF refactor to split out vars and outputs (#8752) 2020-08-26 17:00:36 -04:00
Seth Hoenig
48ae1de4a8 Merge pull request #8709 from hashicorp/f-cc-ingress
consul/connect: add initial support for ingress gateways
2020-08-26 15:50:08 -05:00
Tim Gross
42312bc6fa e2e: move systemd unit files into Packer build (#8751) 2020-08-26 16:45:09 -04:00
Seth Hoenig
a46ba7f4ac Merge branch 'master' into f-cc-ingress 2020-08-26 15:31:05 -05:00
Seth Hoenig
1dca7eb688 consul/connect: use context cancel more safely 2020-08-26 14:23:31 -05:00
Seth Hoenig
abd38b3a86 consul/connect: fixup some comments and context timeout 2020-08-26 13:17:16 -05:00
Buck Doyle
0d885bec09 Remove prestart tasks table
My suggestion is that this table isn’t sufficiently useful to
keep around with the combinatoric explosion of other lifecycle
phases. The logic was that someone might wonder “why isn’t my
main task starting?” and this table would show that the prestart
tasks hadn’t yet completed. One might wonder the same about
any task that has prerequisites, so should a poststart task have
a table that shows main tasks? And so on.

Since the route hierarchy guarantees that one has already passed
through a template that shows the lifecycle chart before one
can reach the template where this table is displayed, I believe
this table is redundant. It also conveys information in a more
abstract way than the chart, which is dense and more easily
understood, to me.
2020-08-26 09:58:44 -05:00
Buck Doyle
14bfb9a53c Add poststart and poststop lifecycle phases 2020-08-26 09:55:42 -05:00
Mahmood Ali
6f6a93b262 Handle migration of non-deployment jobs
This handles the case where a job when from no-deployment to deployment
with canaries.

Consider a case where a `max_parallel=0` job is submitted as version 0,
then an update is submitted with `max_parallel=1, canary=1` as verion 1.
In this case, we will have 1 canary alloc, and all remaining allocs will
be version 0.  Until the deployment is promoted, we ought to replace the
canaries with version 0 job (which isn't associated with a deployment).
2020-08-26 10:36:34 -04:00
Mahmood Ali
1afd4155c8 Merge pull request #8691 from hashicorp/b-reschedule-job-versions
Respect alloc job version for lost/failed allocs
2020-08-25 18:02:45 -04:00
Mahmood Ali
f075bcc811 Update scheduler/reconcile.go
Co-authored-by: Chris Baker <1675087+cgbaker@users.noreply.github.com>
2020-08-25 17:37:19 -04:00
Mahmood Ali
3a28b85b8a simplify canary check
`(alloc.DeploymentStatus == nil || !alloc.DeploymentStatus.IsCanary())`
and `!alloc.DeploymentStatus.IsCanary()` are equivalent.
2020-08-25 17:37:19 -04:00
Mahmood Ali
92bb3728c9 tweak stack job manipulation
To address review comments
2020-08-25 17:37:19 -04:00
Mahmood Ali
cb038b1a8c Have Plan.AppendAlloc accept the job 2020-08-25 17:22:09 -04:00
Mahmood Ali
3e3dff6d7e Merge pull request #8729 from hashicorp/b-assorted-fixes-20200824
Assorted small fixes
2020-08-25 12:30:53 -04:00
Mahmood Ali
f733752f9e Merge pull request #8741 from hashicorp/fix-security-model-broken-links
Fix Broken Learn Guide Links in Security Model
2020-08-25 12:27:59 -04:00
Roger Berlind
30129c313d Merge pull request #8739 from hashicorp/remove-preemption-from-enterprise
remove preemption, add cross-namespace queries
2020-08-25 12:02:16 -04:00
Buck Doyle
5eddb14a33 Add component accessibility auditing and fixes (#8679)
This continues #8455 by adding accessibility audits to component integration
tests and fixing associated errors. It adds audits to existing tests rather than
adding separate ones to facilitate auditing the various permutations a
component’s rendering can go through.

It also adds linting to ensure audits happen in component tests. This
necessitated consolidating test files that were scattered.
2020-08-25 10:56:02 -05:00
Kent 'picat' Gruber
443014469b Fix broken guide links + small authn/authz wording adjustments 2020-08-25 11:46:34 -04:00
Mahmood Ali
cacf2a254d fixup! handle when hcl parser panics 2020-08-25 11:28:55 -04:00
Drew Bailey
b511af94e6 Merge pull request #8738 from hashicorp/ent-changelog
changelog entry for enterprise bug
2020-08-25 11:16:41 -04:00
Drew Bailey
9e211b7edf changelog entry for enterprise bug 2020-08-25 11:16:11 -04:00
Roger Berlind
72d2727dca remove preemption, add cross-namespace queries
remove preemption from summary of governance and policy module since it is now OSS.
add cross-namespace queries to that same sentence.
2020-08-25 11:13:40 -04:00
Tim Gross
d6ad3be8bd csi: fix panic in serializing nil allocs in volume API (#8735)
- fix panic in serializing nil allocs in volume API
- prevent potential panic in serializing plugin allocs
2020-08-25 10:13:05 -04:00
Mahmood Ali
7414102027 clarify PathEscapesAllocDir specification
Clarify how to handle prefix value and path traversal within the alloc
dir but outside the prefix directory.
2020-08-24 20:44:26 -04:00
Mahmood Ali
88ac2a1860 validate parameterized job request meta
Fixes a bug where `keys` metadata wasn't populated, as we iterated over
the empty newly-created `keys` map rather than the request Meta field.
2020-08-24 20:39:01 -04:00
Mahmood Ali
1479f353c0 handle when hcl parser panics
Apparently `\` followed by a digit number can cause hcl parser to panic!
Will fix in hcl library, but using a hammer to squash any similar issue
here.
2020-08-24 20:35:58 -04:00
Mahmood Ali
3dcf60a61e close file when done reading 2020-08-24 20:22:42 -04:00
Mahmood Ali
b84bd95b6a don't lock if ref is nil
Ensure that d.mu is only dereferenced if d is not-nil, to avoid a null
dereference panic.
2020-08-24 20:19:40 -04:00
Jamie Finnigan
d787c28de0 Merge pull request #8728 from hashicorp/gh_sec_pol
remove local SECURITY.md in favor of org-wide policy
2020-08-24 16:03:51 -07:00
Jamie Finnigan
1fae3623d0 remove local SECURITY.md in favor of org-wide policy 2020-08-24 15:41:28 -07:00
Michael Lange
adb06104a8 Merge pull request #8714 from hashicorp/f-ui/always-show-scale-event-accordion
UI: Always show the scaling events accordion
2020-08-24 11:07:31 -07:00
Michael Lange
3c8a7d3daf Always show the scaling events accordion 2020-08-24 10:34:34 -07:00
Seth Hoenig
db8020f4eb consul/connect: fixup tests to use new consul sdk 2020-08-24 12:02:41 -05:00
Seth Hoenig
f4ea3a5c74 consul/connect: update consul to match current 2020-08-24 10:48:27 -05:00
Seth Hoenig
7e3362cfca Merge pull request #8715 from greut/consul-v1.7.7
Consul v1.7.7
2020-08-24 10:43:46 -05:00