Chelsea Holland Komlo
ae10b638db
code review fixes
2017-12-07 13:46:25 -05:00
Chelsea Holland Komlo
927c0a4d88
change location of default kill signal
2017-12-06 17:48:25 -05:00
Chelsea Holland Komlo
9e49836d4f
move kill_signal to task level, extend to docker
2017-12-06 14:36:39 -05:00
Chelsea Holland Komlo
584644287e
get KillTimeout in seconds, not nanoseconds
2017-12-01 10:43:00 -05:00
Chelsea Holland Komlo
9a719cbea2
Support StopTimeout for Docker tasksw
...
Update github.com/fsouza/go-dockerclient
2017-11-29 14:33:05 -05:00
Preetha Appan
ee4b4d859d
Better error validation, and added test case for invalid sysctl inputs
2017-11-20 12:07:18 -06:00
Preetha Appan
0d4797711b
Address some review comments
2017-11-20 11:15:09 -06:00
Preetha Appan
9e07471e48
Fix gofmt warnings
2017-11-18 09:23:09 -06:00
Samuel BERTHE
e6c0372318
review(docker driver): sysctls -> sysctl + ulimits -> ulimit
2017-11-17 16:30:45 -06:00
Samuel BERTHE
d15f01d7df
💄
2017-11-17 16:03:22 -06:00
Samuel BERTHE
84a089433d
feat(docker driver): adds sysctls and ulimits configs
2017-11-17 16:03:22 -06:00
Preetha Appan
929a781ae4
Add default value for cgroup permissions for device if not set
2017-11-13 09:56:54 -06:00
Preetha Appan
b0c03e45ff
Remove unnecessary check since validate method already checks this
2017-11-13 09:56:54 -06:00
Preetha Appan
85c5218b78
Add support for passing device into docker driver
2017-11-13 09:56:54 -06:00
Jonathan Ballet
15114e448e
docker: changed OOM killed error message
2017-10-27 20:30:52 +02:00
Jonathan Ballet
e5a790753d
docker: log that a container has been killed by the OOM killer
...
Fix : #2203 (at least for Docker tasks)
2017-10-27 18:05:27 +02:00
Alex Dadgar
039c1f84c6
docker tests
2017-10-19 16:49:57 -07:00
Michael Schurter
4a6255b6c6
Add logging around moby/moby#32648 bug
2017-10-18 10:44:03 -07:00
Adam Stankiewicz
79eccb2b1e
Remove AllocID from ExecutorContext
2017-10-13 17:07:49 +02:00
Michael Schurter
900e708577
Properly autodetect Docker IP in Windows
...
Our Docker network plugin autodetection code was erroneously treating
Window's default network `nat` as a plugin and defaulting to it instead
of the host.
Fixes #3218
2017-09-27 16:49:23 -07:00
Alex Dadgar
a9e3a41407
Enable more linters
2017-09-26 15:26:33 -07:00
epipho
56d591b119
Fix incorrect docker stats
2017-09-16 00:43:03 -04:00
Alex Dadgar
1bed4b41d9
Merge pull request #3187 from hashicorp/b-windows-docker
...
Fix MemorySwappiness on Windows Docker
2017-09-11 09:56:49 -07:00
Alex Dadgar
7148b65306
Fix MemorySwappiness on Windows Docker
...
Fixes https://github.com/hashicorp/nomad/issues/3181
2017-09-10 17:46:45 -07:00
Alex Dadgar
9206105e69
Fix docker user specified syslogging
2017-09-10 14:57:48 -07:00
Alex Dadgar
d8d4fb877b
Merge pull request #3148 from clinta/purge-stopped
...
Always purge stopped containers
2017-09-05 17:18:05 -07:00
Alex Dadgar
4cab1781f6
Fix repo name passed to docker credential helpers
...
This PR fixes the server url passed to docker credential helpers and
fixes stderr capture.
Fixes https://github.com/hashicorp/nomad/issues/2957
2017-09-05 16:43:21 -07:00
Alex Dadgar
b9f51ce61c
Parse Docker mounts correctly ( #3163 )
...
* Parse Docker mounts correctly
This PR fixes the parsing of Docker mounts and adds testing to ensure no
regressions.
Fixes https://github.com/hashicorp/nomad/issues/3156
* Review feedback
2017-09-05 14:02:57 -07:00
Clint Armstrong
786c09f7e4
Always purge stopped containers
2017-08-31 14:28:48 -04:00
Clint Armstrong
cfffce07a0
fix logging re-init
2017-08-30 12:36:31 -04:00
Alex Dadgar
ba1eecbf7f
Merge pull request #3073 from clinta/docker-500
...
Allow retry of 500 API errors to be handled by restart policies
2017-08-24 16:57:36 -07:00
Alex Dadgar
bf072b61fc
resolve feedback
2017-08-23 14:17:00 -07:00
Alex Dadgar
8099655836
Clean up docker mounts
2017-08-22 14:12:44 -07:00
Clint Armstrong
6b98ddfb1e
Allow retry of 500 API errors to be handled by restart policies
2017-08-22 14:04:46 -04:00
Michael Schurter
ad940977fa
Merge pull request #3021 from clinta/docker-mount2
...
Expose docker mount options
2017-08-17 16:57:09 -07:00
Clint Armstrong
1378f03052
restrict mount to volume type
2017-08-17 09:52:13 -04:00
Alex Dadgar
c26ecb7092
Add version package
...
This PR adds a version package and consolidates version strings into a
Version struct.
2017-08-16 15:44:21 -07:00
Clint Armstrong
c71ac6a825
expose mount options to nomad
2017-08-10 12:37:17 -04:00
Jan De Cooman
ce8550d6fb
fixed typo
2017-08-09 14:44:38 +02:00
Jan De Cooman
b4ec045e9a
added dnsoptions to the docker driver
2017-08-09 13:30:06 +02:00
Luke Farnell
7a56971508
fixed all spelling mistakes for goreport
2017-08-07 17:13:05 -04:00
Michael Schurter
56f697580b
Fix nil panic in Docker error condition
...
Fixes #2835
Yet another bug caused by overwriting container and then trying to
reference container.ID in the err handling block. Did a quick audit of
docker.go and it seems to be the last offender. See #2804 for previous
bug.
2017-07-14 10:48:19 -07:00
Michael Schurter
5ab252fe43
Merge pull request #2797 from hashicorp/f-2785-docker-bridge-ip
...
Add driver.docker.bridge_ip node attribute
2017-07-07 16:20:20 -07:00
Michael Schurter
024d5a8edc
Remove debug logging
2017-07-07 16:19:42 -07:00
Michael Schurter
c47860f928
Don't panic in container list/remove/inspect race
...
Fixes #2802
While it's hard to reproduce the theoretical race is:
1. This goroutine calls ListContainers()
2. Another goroutine removes a container X
3. This goroutine attempts to InspectContainer(X)
However, this bug could be hit in the much simpler case of
InspectContainer() timing out.
In those cases an error is returned and the old code attempted to wrap
the error with the now-nil container.ID. Storing the container ID fixes
that panic.
2017-07-07 15:10:59 -07:00
Michael Schurter
38bf16d2ef
Add driver.docker.bridge_ip node attribute
...
Fixes #2785
2017-07-07 10:14:10 -07:00
Michael Schurter
4f150e1650
Merge pull request #2786 from hashicorp/f-docker-auth-soft-fail
...
Default to auth hard fail but optionally soft fail
2017-07-06 13:25:56 -07:00
Michael Schurter
58186bfb88
Merge branch 'master' into master
2017-07-06 12:09:36 -07:00
Michael Schurter
3aae173432
Default to auth hard fail but optionally soft fail
2017-07-06 11:35:34 -07:00
Michael Schurter
c5e9c4b7b0
Merge pull request #2744 from aep/master
...
Do not fail when no docker registry auth is available
2017-07-06 11:04:11 -07:00
